Skip to content

Fix fuzz_builtin_int fuzzer reproducibility#145890

Open
StanFromIreland wants to merge 1 commit intopython:mainfrom
StanFromIreland:fix-fuzz_builtin_int-reproducability
Open

Fix fuzz_builtin_int fuzzer reproducibility#145890
StanFromIreland wants to merge 1 commit intopython:mainfrom
StanFromIreland:fix-fuzz_builtin_int-reproducability

Conversation

@StanFromIreland
Copy link
Member

While trying to reproduce https://oss-fuzz.com/testcase-detail/6342648498814976, I realised we are randomising the base, even for the same testcase. I propose we instead use the first byte, so as to ensure reproducibility.

@StanFromIreland
Copy link
Member Author

Requesting @python/fuzzers.

This was not done automatically, because per the error:

Unknown owner on line 135: make sure the team @python/fuzzers exists, is publicly visible, and has write access to the repository

@python/organization-owners, can you please add it to the team to fix this?

@coderanger
Copy link
Member

@StanFromIreland Can you confirm everyone on the team already has write access? (I can diff permissions later if you are unsure)

@StanFromIreland
Copy link
Member Author

@coderanger, "write access" doesn’t actually give write access in CPython (e.g., this is the level it is for the triage team: https://github.com/orgs/python/teams/python-triage/repositories).

@coderanger
Copy link
Member

I did try adding at triage but that didn't make the CODEOWNERS validation happy :) Might have just been some stuck caching though?

Copy link
Member

@ammaraskar ammaraskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah whoops, good catch. Yeah, the intention was to use a stable hash function here. Using byte 0 works as well.

@hugovk
Copy link
Member

hugovk commented Mar 13, 2026

When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

https://github.com/orgs/python/teams/fuzzers/repositories?type=source shows "Role: Write", so that should be okay.

Visibility:

gh api orgs/python/teams/fuzzers --jq '{privacy: .privacy}'
{
  "privacy": "closed"
}

To change it, an admin can go to https://github.com/orgs/python/teams/fuzzers/edit > select visible:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants