Fix fuzz_builtin_int fuzzer reproducibility#145890
Fix fuzz_builtin_int fuzzer reproducibility#145890StanFromIreland wants to merge 1 commit intopython:mainfrom
fuzz_builtin_int fuzzer reproducibility#145890Conversation
|
Requesting @python/fuzzers. This was not done automatically, because per the error:
@python/organization-owners, can you please add it to the team to fix this? |
|
@StanFromIreland Can you confirm everyone on the team already has write access? (I can diff permissions later if you are unsure) |
|
@coderanger, "write access" doesn’t actually give write access in CPython (e.g., this is the level it is for the triage team: https://github.com/orgs/python/teams/python-triage/repositories). |
|
I did try adding at |
ammaraskar
left a comment
There was a problem hiding this comment.
Aah whoops, good catch. Yeah, the intention was to use a stable hash function here. Using byte 0 works as well.
https://github.com/orgs/python/teams/fuzzers/repositories?type=source shows "Role: Write", so that should be okay. Visibility: ❯ gh api orgs/python/teams/fuzzers --jq '{privacy: .privacy}'
{
"privacy": "closed"
}To change it, an admin can go to https://github.com/orgs/python/teams/fuzzers/edit > select visible:
|

While trying to reproduce https://oss-fuzz.com/testcase-detail/6342648498814976, I realised we are randomising the base, even for the same testcase. I propose we instead use the first byte, so as to ensure reproducibility.