gh-142518: Annotate PyDict_* C APIs for thread safety#145875
Open
lysnikolaou wants to merge 1 commit intopython:mainfrom
Open
gh-142518: Annotate PyDict_* C APIs for thread safety#145875lysnikolaou wants to merge 1 commit intopython:mainfrom
lysnikolaou wants to merge 1 commit intopython:mainfrom
Conversation
39 tasks
| # Dictionary objects (Doc/c-api/dict.rst) | ||
|
|
||
| # Type checks - read ob_type pointer, always safe | ||
| PyDict_Check:atomic: |
Contributor
There was a problem hiding this comment.
I don't think these need to be annotated. PyDict_Check falls in the category of type checks, and reading type of a object is safe in free-threading in general, we can perhaps add this separately but it doesn't look useful to add this to every type check function
Member
Author
There was a problem hiding this comment.
My view is more information is better than less. Since it's just one line in a .dat file and not something that will require a substantial maintenance effort, it's good to have it. Making things more easily discoverable is a strong argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--145875.org.readthedocs.build/