Skip to content

gh-129374: adds quoting detection to csv sniffer#134416

Open
aterrel wants to merge 4 commits into
python:mainfrom
aterrel:gh-129374-csv-quoted-strings
Open

gh-129374: adds quoting detection to csv sniffer#134416
aterrel wants to merge 4 commits into
python:mainfrom
aterrel:gh-129374-csv-quoted-strings

Conversation

@aterrel

@aterrel aterrel commented May 21, 2025

Copy link
Copy Markdown

@bedevere-app

bedevere-app Bot commented May 21, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 25, 2026
@serhiy-storchaka

Copy link
Copy Markdown
Member

Thank you for working on this, but the sniffer was rewritten on the main branch (gh-83273) and this patch no longer applies.

Detecting quoting would fit in a _detect_*() method for the chosen combination, next to _detect_doublequote(), but it needs to know which fields were quoted, and the reader does not report this. Note also that QUOTE_NONNUMERIC changes how the dialect reads the data: unquoted fields are converted to floats. This is worth deciding in the issue first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants