GH-106008: Make implicit boolean conversions explicit#106003
Merged
brandtbucher merged 18 commits intopython:mainfrom Jun 29, 2023
Merged
GH-106008: Make implicit boolean conversions explicit#106003brandtbucher merged 18 commits intopython:mainfrom
brandtbucher merged 18 commits intopython:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and specialize them!
This adds a new
TO_BOOLbytecode that prefixes allUNARY_NOT,POP_JUMP_IF_TRUE, andPOP_JUMP_IF_FALSEinstructions, which now require an exact boolean. We also use a spare bit inCOMPARE_OP's oparg to indicate whether the result should be converted to bool (this saves aTO_BOOLfor most branches, and is a no-op for allCOMPARE_OPspecializations)."0% faster". Stats show a 93.5% hit rate for the new instructions.
📚 Documentation preview 📚: https://cpython-previews--106003.org.readthedocs.build/