Skip to content

Make tests pass on Python 2.6 - #89

Merged
brian-brazil merged 1 commit into
prometheus:masterfrom
hynek:master
Jul 14, 2016
Merged

brian-brazil merged 1 commit into
prometheus:masterfrom
hynek:master

Conversation

@hynek

@hynek hynek commented Jul 8, 2016

Copy link
Copy Markdown
Contributor

As discussed in #86, this adds Python 2.6 support for the tests and CI.

Since 2.6’s stdlib doesn’t support test skipping, we have to resort to using the back port unittest2.

There are a few ways to make it less ugly:

  • use unittest2 unconditionally everywhere. has also the benefit of a consistent test environment.
  • do the dance once in a helper module (say tests/utils.py) and then just import unittest from there.
  • use pytest for skipping

@brian-brazil
brian-brazil merged commit bc2f2bc into prometheus:master Jul 14, 2016
@brian-brazil

Copy link
Copy Markdown
Contributor

Having anyone on 2.6 have to install an extra module for testing seems fine to me.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants