Skip to content

Python2.7 - AssertionError: Status must be a string #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Geethree wants to merge 1 commit into from
Closed

Python2.7 - AssertionError: Status must be a string #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prometheus_client/exposition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def prometheus_app(environ, start_response):
# Bake output
status, header, output = _bake_output(registry, accept_header, params)
# Return output
start_response(status, [header])
start_response(str(status), [header])

@csmarchbanks csmarchbanks Jul 6, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if lines 118 and 119 should just be cast as str similar to what the end of _bake_output does? Do you only see this issue for requests going to /favicon.ico or other locations as well?

return [output]

return prometheus_app
Expand Down