Skip to content

Allow to return str instead bytes from generate_latest() #1060

Description

@stalkerg

Because converting to bytes anyway happened at the end of function, have sense to return str instead bytes or have options to avoid extra transformation. (many API expected str)

Activity

  1. csmarchbanks commented on Oct 14, 2024

    @csmarchbanks
    Member

    I think the ship has sailed on this, any uses of generate_latest today will be using bytes and changing the return type would be a significant breaking change.

  2. stalkerg commented on Oct 15, 2024

    @stalkerg
    Author

    I think we can create a new function generate_latest_b() and return bytes, and original function will just call new function and convert to string.
    Seems like the current behavior comes from Python2 era.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions