Modular FES#8887
Open
limzykenneth wants to merge 29 commits into
Open
Conversation
This doesn't need to be registered/deregistered on load because it can only trigger on reference error and thus won't hit a false positive.
limzykenneth
marked this pull request as draft
June 9, 2026 17:06
limzykenneth
marked this pull request as ready for review
July 24, 2026 13:03
Member
Author
|
@ksen0 @davepagurek Let's get this merge in first if we are now going with the minor release on main branch and patch release on release branch flow. Do have a test with the preview build and see if there are any major issues. I still have two things next on the list which is to migrate all calls to I also want to update and migrate the build system + dependencies after this is merge as well. |
ksen0
approved these changes
Jul 24, 2026
ksen0
left a comment
Member
There was a problem hiding this comment.
Looks great, thank you for preparing this! To be honest I don't quite get the internationalization but it will be great to merge it in and use it leading up to 2.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8882
Changes:
Rework the internals of FES as specified in #8882. For API design please comment in #8882, for implementation details discussions, feel free to leave comments in this PR for review.