This repository was archived by the owner on Oct 2, 2018. It is now read-only.
[COOK-4250] Python package recipe should allow package names to be configured#90
Closed
estebistec wants to merge 1 commit into
Closed
[COOK-4250] Python package recipe should allow package names to be configured#90estebistec wants to merge 1 commit into
estebistec wants to merge 1 commit into
Conversation
…e overrided by an attribute
|
This is a welcome change. Should always allow wrapper cookbooks to change behaviour. |
This was referenced Feb 24, 2014
|
Any updates here? Why can't this be merged in? |
|
@coderanger How does this PR look to you? Ready to be merged? |
Member
|
@gene1wood I don't generally add new features unless someone is sponsoring them. |
Member
|
This is now handled in https://github.com/poise/poise-python via the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow OS package names (generally determined by platform family) to be overrided by an attribute
[COOK-4250] Python package recipe should allow package names to be configured