This repository was archived by the owner on Oct 2, 2018. It is now read-only.
Fix cookbook in 0.10.10#9
Closed
salgo wants to merge 1 commit into
Closed
Conversation
…he error that Mixlib::ShellOut::ShellCommandFailed doesn't exist in 0.10.8
Member
|
Any chance you can remove all the other formatting changes? |
Member
There was a problem hiding this comment.
Why this backwards-incompatible semantics change?
Author
|
Hi, sorry unaware of other local changes and was clearly a bit fast to submit. Making just the changing required and will resubmit. |
Member
|
This has been resubmitted as #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixlib::ShellOut::ShellCommandFailed doesn't exist in 0.10.8 so we have to handle that name error and include Chef::Exceptions::ShellCommandFailed which is how 0.10.8 does it.
Tested on both 0.10.8 and 0.10.10.