Repository navigation
tici: support count pushdown to tici searchlib - #10428
Conversation
|
|
||
| bool isOnlyOneCount() const | ||
| { | ||
| return aggregate_descriptions.size() == 1 && aggregate_descriptions[0].function->getName() == "count"; |
There was a problem hiding this comment.
why count's argument is not checked?
There was a problem hiding this comment.
addressed. I check aggregate_descriptions[0].argument_names.empty()
| if (plan->tp() == PlanType::Aggregation) | ||
| { | ||
| auto agg = std::static_pointer_cast<PhysicalAggregation>(plan); | ||
| if (agg->isOnlyOneCount()) |
There was a problem hiding this comment.
And this agg should not have group by key?
There was a problem hiding this comment.
And count(distinct) is not supported?
There was a problem hiding this comment.
And this agg should not have group by key?
Addressed. I check aggregation_keys.empty().
And count(distinct) is not supported?
distinct is not supported in tici, so tici will return all data, and tiflash will process it.
|
|
||
| protected: | ||
| Block readFromS3(size_t processing) | ||
| Block readFromS3(size_t processing, bool is_count) |
There was a problem hiding this comment.
is remote read well handled for this agg push down?
There was a problem hiding this comment.
No, remote read sends a cop request without any agg info, so the remote tiflash will read the actual data and return.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guo-shaoge, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note