Skip to content

model: correct the usage of json.Unmarshal in DecodeArgs (#890) - #896

Merged
jackysp merged 1 commit into
pingcap:release-3.0from
bobotu:3.0-fix-1.15
Jun 16, 2020
Merged

jackysp merged 1 commit into
pingcap:release-3.0from
bobotu:3.0-fix-1.15

Conversation

@bobotu

@bobotu bobotu commented Jun 11, 2020

Copy link
Copy Markdown
Contributor

Cherry-pick #890

@kennytm kennytm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Jun 11, 2020
@codecov

codecov Bot commented Jun 11, 2020

Copy link
Copy Markdown

Codecov Report

Merging #896 into release-3.0 will increase coverage by 0.14%.
The diff coverage is 64.16%.

@@               Coverage Diff               @@
##           release-3.0     #896      +/-   ##
===============================================
+ Coverage        64.36%   64.50%   +0.14%     
===============================================
  Files               31       31              
  Lines            11019    11104      +85     
===============================================
+ Hits              7092     7163      +71     
- Misses            3518     3524       +6     
- Partials           409      417       +8     

@jackysp jackysp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp

jackysp commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

/merge

@ti-srebot

Copy link
Copy Markdown
Contributor

/run-all-tests

@jackysp
jackysp merged commit 4e23afb into pingcap:release-3.0 Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants