Skip to content

lexer: replace version comments with feature-ids mechanism (#777) - #819

Merged
bb7133 merged 2 commits into
pingcap:release-3.1from
tangenta:release-3.1-feature-id
Apr 24, 2020
Merged

bb7133 merged 2 commits into
pingcap:release-3.1from
tangenta:release-3.1-feature-id

Conversation

@tangenta

Copy link
Copy Markdown
Contributor

Cherry-pick #777 to release-3.1

* lexer: replace version comments with feature-ids mechanism

* tests: retain the original version digit test

* fix scanVersionDigits

* add SpecialCommentsController to decide what comments can be parsed

* only ignore comments with unsupported feature-id

* remove debug log
@codecov

codecov Bot commented Apr 21, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #819 into release-3.1 will increase coverage by 0.05%.
The diff coverage is 82.51%.

@@               Coverage Diff               @@
##           release-3.1     #819      +/-   ##
===============================================
+ Coverage        64.65%   64.70%   +0.05%     
===============================================
  Files               31       33       +2     
  Lines            11211    11477     +266     
===============================================
+ Hits              7248     7426     +178     
- Misses            3552     3627      +75     
- Partials           411      424      +13     

@tangenta tangenta closed this Apr 24, 2020
@AilinKid AilinKid reopened this Apr 24, 2020

@AilinKid AilinKid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
bb7133 merged commit 867e000 into pingcap:release-3.1 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants