Skip to content

parser: add order by clause in group_concat - #813

Merged
SunRunAway merged 4 commits into
pingcap:masterfrom
SunRunAway:issue6838GROUP_CONCAT_ORDER_BY-2
Apr 20, 2020
Merged

SunRunAway merged 4 commits into
pingcap:masterfrom
SunRunAway:issue6838GROUP_CONCAT_ORDER_BY-2

Conversation

@SunRunAway

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

part of pingcap/tidb#6838

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

@SunRunAway
SunRunAway requested a review from a team April 20, 2020 03:09

@zz-jason zz-jason left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Apr 20, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #813 into master will decrease coverage by 0.22%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   78.27%   78.04%   -0.23%     
==========================================
  Files          40       40              
  Lines       14707    14681      -26     
==========================================
- Hits        11512    11458      -54     
- Misses       2515     2539      +24     
- Partials      680      684       +4     

@XuHuaiyu XuHuaiyu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot

sre-bot commented Apr 20, 2020

Copy link
Copy Markdown

@SunRunAway merge failed.

@SunRunAway

Copy link
Copy Markdown
Contributor Author

/run-cherry-picker

@sre-bot

sre-bot commented May 6, 2020

Copy link
Copy Markdown

cherry pick to release-3.0 failed

@sre-bot

sre-bot commented May 6, 2020

Copy link
Copy Markdown

cherry pick to release-3.1 failed

@sre-bot

sre-bot commented May 6, 2020

Copy link
Copy Markdown

cherry pick to release-4.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants