PSR-2 compliance#25
Closed
tuupola wants to merge 4 commits intophp-http:masterfrom
tuupola:psr2-fixes
Closed
Conversation
4 tasks
Member
|
Thanks for the contribution, although I have a few problems with it:
|
Contributor
Author
|
Ok. I though the camel case rule was the only one which should be relaxed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Makes code PSR-2 compliant with the exception of relaxing the
PSR1.Methods.CamelCapsMethodNamefor spec files. Additionally uses short array syntax in tests as discussed in #24. Lastly adds PHPCS to vendor and enables running it via$ composer phpcs.I know this is three things in one PR but I feel these are closely related and the last one is easy remove if it is unwanted.