Update to latest PSR-7 version#43
Merged
pmjones merged 1 commit intophp-fig:masterfrom May 4, 2015
weierophinney:hotfix/sync-with-spec
Merged
Update to latest PSR-7 version#43pmjones merged 1 commit intophp-fig:masterfrom weierophinney:hotfix/sync-with-spec
pmjones merged 1 commit intophp-fig:masterfrom
weierophinney:hotfix/sync-with-spec
Conversation
- Syncs all interface definitions with the latest revisions on php-fig/fig-standards.
Contributor
Author
|
Once merged, please tag 0.11.0, with the following: Updates from Review-2
This tag contains all updates since entering the second review of PSR-7. These include:
- Clarifications to `RequestInterface::withUri()` specifying that changes MUST also update the `Host` header *unless* the `$preserverHost` flag is `true`.
- Removal of the various `getHeader*()` method overrides in `RequestInterface`, as they are irrelevant with the above change.
- Added verbiage to the `RequestInterface` class-level docblock indicating that constructors SHOULD attempt to set the `Host` header in order to ensure the message is valid on initialization.
- `RequestInterface::getHeaderLine()` MUST return a string (`null` was allowed previously, which leads to ambiguity of return value).
- `ResponseInterface::getReasonPhrase()` MUST return a string(`null` was allowed previously, which leads to ambiguity of return value).
- `ResponseInterface::withStatus()` now sets the default value of the `$reasonPhrase` parameter to an empty string (to correspond to the above change).
- `UploadedFileInterface::move()` was renamed to `moveTo()`, and the argument renamed to `$targetPath`; this clarifies intent for the method.
- `UriInterface::withPath()` has clarifications in the docblock to indicate the four possible path types (empty, root path, relative path, domain-relative — or absolute — path). |
Contributor
Author
pmjones
pushed a commit
that referenced
this pull request
May 4, 2015
Update to latest PSR-7 version
Contributor
|
Tagged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs all interface definitions with the latest revisions on php-fig/fig-standards.
This PR contains changes from the following as-yet unmerged pull-requests, and should therefore be merged after them: