Body parameters are the parsed body.#23
Merged
pmjones merged 2 commits intophp-fig:masterfrom Feb 13, 2015
weierophinney:feature/parsed-body
Merged
Body parameters are the parsed body.#23pmjones merged 2 commits intophp-fig:masterfrom weierophinney:feature/parsed-body
pmjones merged 2 commits intophp-fig:masterfrom
weierophinney:feature/parsed-body
Conversation
Per conversations with @Crell, @ircmaxell, @pmjones, and several others, the body parameters are always the parsed body content; calling them out as such, and without the "parameters" verbiage, implies that parsing may create non-array values, which is exceptionally likely when working with API and/or non-form-encoded payloads. Moreover, the content will always be specific to the incoming request, so supporting one method representing POST and another representing parsed content is redundant and potentially confusing. Finally, considering the fact that the parsed body is an ambiguous domain, forcing an ubiquitous signature is an unnecessary and limiting constraint. However, IF the request method is POST, AND the Content-Type is application/x-www-form-urlencoded, THEN the parsed body MUST be equivalent to $_POST.
Contributor
Author
|
@pmjones Please merge after php-fig/fig-standards#429, and tag as 0.9.0 with the message "Use the verbiage 'parsed body' instead of 'body params'". |
pmjones
pushed a commit
that referenced
this pull request
Feb 13, 2015
Body parameters are the parsed body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs the repo with the changes specified in php-fig/fig-standards#429
Per conversations with @Crell, @ircmaxell, @pmjones, and several others, the
body parameters are always the parsed body content; calling them out as such,
and without the "parameters" verbiage, implies that parsing may create non-array
values, which is exceptionally likely when working with API and/or
non-form-encoded payloads.
Moreover, the content will always be specific to the incoming request, so
supporting one method representing POST and another representing parsed content
is redundant and potentially confusing.
Finally, considering the fact that the parsed body is an ambiguous domain,
forcing an ubiquitous signature is an unnecessary and limiting constraint.
However, IF the request method is POST, AND the Content-Type is
application/x-www-form-urlencoded, THEN the parsed body MUST be
equivalent to $_POST.