Repository navigation
Only add Ampq transport factories when packages are found - #241
Conversation
|
AmqpTransportFactory is in |
|
But the Should I always require |
|
You shouldn't, the bundle heavily rely on it and hence require it itself |
|
Are there any errors you face? |
|
The DelayStrategyTransportFactoryTrait is from the ampq-tools package. Which isn't a requirement for enqueue/enqueue nor for the enqueue-bundle. Or am I missing something? I get an error that the Trait can't be found. Since the bundle tries to load the |
|
Okay, let's merge this then. Could you please CS issues please? |
|
This is the correct check to avoid adding the TransportFactories? https://github.com/php-enqueue/enqueue-dev/pull/241/files#diff-21599724c6f8c888b53103436890a85fR60 |
yeap |
|
Commit contains better fix for this issue 031380e. I kept both changes for now, though ones you added are not needed any more |
Only add Ampq transport factories when packages are found
No description provided.