Skip to content

Doc example doesn't work #783

Closed
Closed

Description

@TomPradat

In the documentation it's written that you can instanciate a factory (for localhost) with :

$factory = new \Enqueue\AmqpLib\AmqpConnectionFactory();

Though i get an error stating that the Enqueue\Dsn\Dsn class cannot be found. Everythink works fine if i give the factory an empty array.

https://github.com/php-enqueue/enqueue-dev/blob/master/docs/transport/amqp_bunny.md

Activity

  1. makasim commented on Feb 25, 2019

    @makasim
    Member

    Do you use composer to install the package?

  2. TomPradat commented on Feb 25, 2019

    @TomPradat
    ContributorAuthor

    Yes i do, i tried to dump the autoloader but still had the problem. I have "enqueue/amqp-lib" as a dependency in my project

  3. makasim commented on Feb 25, 2019

    @makasim
    Member

    You are right. amqp-tools should require dsn pacakge. In fact it is required but in dev. https://github.com/php-enqueue/enqueue-dev/blob/master/pkg/amqp-tools/composer.json#L17

    should be moved to require section.

  4. TomPradat commented on Feb 25, 2019

    @TomPradat
    ContributorAuthor

    Yes indeed, do you want me to create a PR or are you handling it ?

  5. makasim commented on Feb 25, 2019

    @makasim
    Member

    That would be great if you could send it to us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions