You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Don't use slashes in and prefix queue name with type in STOMP #1067
I've been working with publishing to a STOMP queue and I've noticed that all my messages are prefixed with /queue/, which is going against my desired scheme for messages.
Looking at StompDestination, I see that both the prefix and the slashes are hard-coded.
It comes to mind that it probably shouldn't be coded as such because everyone can and should be allowed to have their own conventions around how they namespace jobs (using.periods, maybe:colons, maybe/slashes, maybe\backslashes, etc...). Indeed, sometimes those conventions might be completely outside of their control! 😅
Maybe for now you can just detect the scheme stomp+rabbitmq and preserve the old behaviour, but a pure stomp scheme just bypasses prefixing altogether?
(Doing this ensures the backwards compat, but that frees up the bare stomp scheme from rabbitmq specifics. Would be easy enough to include a note in the release notes for rabbitmq users to update their connection strings?)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Totally understand, is it okay if I ping here if I have any bizarro questions? I haven't started yet and I can't imagine I'm going to get really stumped. But just in case 😉
Activity
makasim commentedon Jun 14, 2020
We hardcoded them because of RabbitMQ. It needs it this way to properly route messages and that was the only broker we tested STOMP with.
I guess you use another broker. Which one?
The current values should stay there because of backward compatibility promise. Though, We should definitely add a way to configure them.
Another idea is to use scheme like this
stomp+rabbitmq://,stom+activemq://to switch to a property settings.atrauzzi commentedon Jun 14, 2020
Sounds good, I'm on ActiveMQ Artemis.
Maybe for now you can just detect the scheme
stomp+rabbitmqand preserve the old behaviour, but a purestompscheme just bypasses prefixing altogether?(Doing this ensures the backwards compat, but that frees up the bare
stompscheme from rabbitmq specifics. Would be easy enough to include a note in the release notes for rabbitmq users to update their connection strings?)stale commentedon Jul 15, 2020
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
atrauzzi commentedon Jul 15, 2020
Not stale.
stale commentedon Aug 14, 2020
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
atrauzzi commentedon Aug 16, 2020
Not stale.
makasim commentedon Aug 21, 2020
I wish we could do it but we cannot as it would break existing projects that use
stompand assume there are prefixes.What we could do is to introduce new stomp+bare, or stomp-activemq schema that would work differently from current behavior
makasim commentedon Aug 21, 2020
In next version (say 0.11.0) we could do it the way it should be.
atrauzzi commentedon Aug 21, 2020
That sounds good!
atrauzzi commentedon Sep 17, 2020
Hey @makasim, I just wanted to check to see if there's been any progress on this?
If not, is there any way I can fork the current stomp driver and modify it as I need?
makasim commentedon Sep 17, 2020
It's a low priority project for me. So, dont expect much. I can review&merge PRs, do a release. That's pretty much it.
makasim commentedon Sep 17, 2020
Feel free to fork this repository https://github.com/php-enqueue/stomp
atrauzzi commentedon Sep 17, 2020
Totally understand, is it okay if I ping here if I have any bizarro questions? I haven't started yet and I can't imagine I'm going to get really stumped. But just in case 😉
Either way, thank you for the guidance so far. ❤️
makasim commentedon Sep 17, 2020
Sure thing!
atrauzzi commentedon Sep 17, 2020
Great. If what I make is deemed worthwhile, it'll obviously be available to incorporate back into enqueue.
atrauzzi commentedon Sep 22, 2020
PR opened!