Skip to content

[FSSDK-12316] [Security] Fix curl|bash vulnerability in SourceClear scan#294

Merged
Tamara-Barum merged 2 commits intomasterfrom
security/fix-sourceclear-vulnerability
Mar 11, 2026
Merged

[FSSDK-12316] [Security] Fix curl|bash vulnerability in SourceClear scan#294
Tamara-Barum merged 2 commits intomasterfrom
security/fix-sourceclear-vulnerability

Conversation

@Tamara-Barum
Copy link
Contributor

@Tamara-Barum Tamara-Barum commented Mar 11, 2026

FSSDK-12316

Summary

Removes SourceClear scan workflow following Python SDK approach.

  • Addresses security vulnerability from dangerous curl|bash pattern
  • Follows Python SDK remediation (commit d651911)
  • Related to previous security fix in commit 363cb85

Changes

  • Removed entire source_clear job from workflow
  • Updated unit_tests dependency to remove source_clear requirement

References

Tamara-Barum and others added 2 commits March 5, 2026 08:42
- Replace dangerous curl|bash pattern with official Veracode SCA action
- Use veracode/veracode-sca@v2 for secure, maintained scanning
- Addresses script injection vulnerability in CI/CD pipeline
- Related to commit 363cb85 (previous GitHub Actions security fix)

Security improvements:
- Official action from Veracode organization (signed and verified)
- No untrusted remote code execution
- Protected against MITM attacks
- Same SRCCLR_API_TOKEN authentication preserved
- Action is actively maintained and receives security updates

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Following Python SDK's approach (commit d651911), removing the
SourceClear GitHub Actions workflow to address security risks.

The curl|bash pattern in this workflow presented a security
vulnerability. Rather than replace with official action, we're
removing it entirely to align with the Python SDK security
remediation strategy.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@Tamara-Barum Tamara-Barum self-assigned this Mar 11, 2026
@coveralls
Copy link

Coverage Status

coverage: 97.336%. remained the same
when pulling f7cf07f on security/fix-sourceclear-vulnerability
into 9b30186 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 97.336%. remained the same
when pulling f7cf07f on security/fix-sourceclear-vulnerability
into 9b30186 on master.

Copy link

@alexjoeyyong alexjoeyyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes source clear from the php-sdk repo. LGTM

@Tamara-Barum Tamara-Barum merged commit 8539381 into master Mar 11, 2026
9 checks passed
@Tamara-Barum Tamara-Barum deleted the security/fix-sourceclear-vulnerability branch March 11, 2026 18:42
Tamara-Barum added a commit to optimizely/javascript-sdk that referenced this pull request Mar 11, 2026
Removes the SourceClear workflow that contains a dangerous curl|bash pattern,
which presents risks of script injection and untrusted remote code execution
in the CI/CD pipeline. This follows the same remediation approach used in the
PHP SDK (optimizely/php-sdk#294).

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Tamara-Barum added a commit to optimizely/javascript-sdk that referenced this pull request Mar 11, 2026
Removes the SourceClear workflow that contains a dangerous curl|bash pattern,
which presents risks of script injection and untrusted remote code execution
in the CI/CD pipeline. This follows the same remediation approach used in the
PHP SDK (optimizely/php-sdk#294).

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants