Skip to content

Remove deprecated target variant dispatch from oneMKL sample - #2474

Merged
jimmytwei merged 1 commit into
oneapi-src:masterfrom
andrewtbarker:deprecated-dispatch
Sep 17, 2024
Merged

jimmytwei merged 1 commit into
oneapi-src:masterfrom
andrewtbarker:deprecated-dispatch

Conversation

@andrewtbarker

Copy link
Copy Markdown
Contributor

Existing Sample Changes

Description

Removes deprecated omp target dispatch construct from oneAPI samples.

External Dependencies

No new dependencies.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally on linux PVC.

  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode
  • When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

@kazushigegoto kazushigegoto left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@andreyfe1
andreyfe1 requested a review from jimmytwei September 9, 2024 14:50
@jimmytwei

Copy link
Copy Markdown
Contributor

@andrewtbarker Can you submit a PR to the development branch instead?

@andrewtbarker

Copy link
Copy Markdown
Contributor Author

@andrewtbarker Can you submit a PR to the development branch instead?

@jimmytwei Not really. The development branch already has the most important change here. The ticket was reported to us based on the master branch, so fix should be done there?

@andrewtbarker

Copy link
Copy Markdown
Contributor Author

Made #2482 into development branch, but it does not really fix the issue that was reported. To fix that we need to either merge this PR or update the master branch.

@jimmytwei
jimmytwei merged commit 6be606b into oneapi-src:master Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants