Repository navigation
Update README.md to reflect changes in compiler output. - #2402
Conversation
This update contains a rewritten README.md file for the `guided_matrix_mult_InvalidContexts` sample. It also adds two screenshots (png files) that accompany the rewritten README.me file. The previous version of this README.md did not include screenshots
There was a problem hiding this comment.
@jimmytwei -- note that there are two PNG files added to this sample. They are located in the sample's root (same location as the sample.json file). Is that the correct location for the PNG screenshots? Or do you have a preferred way to deal with README.md files that reference image files?
---- the following comments are not related to this PR ----
In the process of creating this PR I was having some problems with some VTune *.bat files showing up as changed. Their line endings are being automatically changed to CRLF during my checkout, due to my ~/.gitattributes file. This points out a potential problem with these VTune batch files:
oneAPI-samples/Tools/VTuneProfiler/tachyon/windows/build.batoneAPI-samples/Tools/VTuneProfiler/tachyon/windows/scripts/build*.bat
Windows batch files (bat or cmd) always need to use CRLF line endings. Doing otherwise results in difficult to debug problems that come about when the line endings in Windows batch files end in only a LF character. It's a particular problem when the batch file contains labels. Thus the reason that I use a ~/.gitattributes which forces Windows batch files to always using end in the CRLF character pair.
|
@xmnboy I don't have a preference as to where you drop the .png files. The sample's root folder is fine. |
* Update README.md * Update README.md * Update README.md * Update lu_solve_omp_offload_optimized.F90 * Update openmp_sample.f90 (#2371) * fixed HF load_dataset * Update README.md to reflect changes in compiler output. (#2402) This update contains a rewritten README.md file for the `guided_matrix_mult_InvalidContexts` sample. It also adds two screenshots (png files) that accompany the rewritten README.me file. The previous version of this README.md did not include screenshots --------- Co-authored-by: Jimmy Wei <jimmy.t.wei@intel.com> Co-authored-by: Paul Fischer <paul.a.fischer@intel.com>
|
@xmnboy Can you also submit this to the |
Existing Sample Changes
Description
This update contains a rewritten README.md file for the
guided_matrix_mult_InvalidContextssample. It also adds two screenshots (png files) that accompany the rewritten README.me file. The previous version of this README.md did not include screenshots.Fixes Issue# ONSAM-1871
External Dependencies
None. All changes are documentation changes, which are due primarily to changes in the oneAPI SYCL compiler. Those changes are part of the 2024.x releases of the compiler.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
The changes in the README.md reflect a review of the debug process that was originally written against the messages and behavior of the 2023.x compiler. This version of the README reflects going through the same process, but using the 2024.x compiler.
NOTE: Charles Congdon authored the original version of this sample and the subsequent rewrite. I (@xmnboy) reviewed Charles' changes and have assembled and submitted this pull request, on Charles' behalf.