Skip to content

Fix #27 for hotfix/3.1.1#42

Merged
rwasef1830 merged 1 commit into
npgsql:hotfix/3.1.1from
rwasef1830:fix_27_for_3.1.1
Jul 9, 2016
Merged

Fix #27 for hotfix/3.1.1#42
rwasef1830 merged 1 commit into
npgsql:hotfix/3.1.1from
rwasef1830:fix_27_for_3.1.1

Conversation

@rwasef1830
Copy link
Copy Markdown
Contributor

@rwasef1830 rwasef1830 commented Jul 9, 2016

@roji Same as #36 but for hotfix/3.1.1

I changed the code style a bit (not using C# 6 expression bodies and not "var") to match the surrounding code.

@rwasef1830
Copy link
Copy Markdown
Contributor Author

whoops missed a few spots, will fix, force push and say when ready.

@roji
Copy link
Copy Markdown
Member

roji commented Jul 9, 2016

OK, let me know when it's ready.

FYI in 3.1 I use var and all C# 6 features wherever possible. EF6.Npgsql is a bit less clean than Npgsql itself but it's a good idea for new code to do that. Another thing is that it's better for code merged into dev and into hotfix/3.1.1 to be as close as possible (aside from actual conflicts of course), to make later comparison easier.

@rwasef1830
Copy link
Copy Markdown
Contributor Author

Ah ok then, I'll make it as close as possible then.

@rwasef1830
Copy link
Copy Markdown
Contributor Author

Looks good now. I think it is OK for merge.

@roji
Copy link
Copy Markdown
Member

roji commented Jul 9, 2016

LGTM, @rwasef1830 feel free to merge whenever you want.

Also, take a look at the list of open issues. If you want we can release 3.1.1 right away with this fix, or we can wait if you want to do some more work.

@rwasef1830 rwasef1830 merged commit dbf2835 into npgsql:hotfix/3.1.1 Jul 9, 2016
@rwasef1830 rwasef1830 deleted the fix_27_for_3.1.1 branch July 9, 2016 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants