Fix #27 for hotfix/3.1.1#42
Merged
Merged
Conversation
Contributor
Author
|
whoops missed a few spots, will fix, force push and say when ready. |
Member
|
OK, let me know when it's ready. FYI in 3.1 I use var and all C# 6 features wherever possible. EF6.Npgsql is a bit less clean than Npgsql itself but it's a good idea for new code to do that. Another thing is that it's better for code merged into dev and into hotfix/3.1.1 to be as close as possible (aside from actual conflicts of course), to make later comparison easier. |
Contributor
Author
|
Ah ok then, I'll make it as close as possible then. |
…it cast function + tests.
d568259 to
88885ef
Compare
Contributor
Author
|
Looks good now. I think it is OK for merge. |
Member
|
LGTM, @rwasef1830 feel free to merge whenever you want. Also, take a look at the list of open issues. If you want we can release 3.1.1 right away with this fix, or we can wait if you want to do some more work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roji Same as #36 but for hotfix/3.1.1
I changed the code style a bit (not using C# 6 expression bodies and not "var") to match the surrounding code.