Repository navigation
Conversation
trivikr
force-pushed
the
vfs-watchfile-listener-ignore
branch
from
September 23, 2026 04:04
6f9a2df to
50f2740
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66224 +/- ##
==========================================
- Coverage 92.99% 90.69% -2.31%
==========================================
Files 428 797 +369
Lines 195537 278787 +83250
Branches 30252 53608 +23356
==========================================
+ Hits 181845 252846 +71001
- Misses 13365 16299 +2934
- Partials 327 9642 +9315
🚀 New features to boost your workflow:
|
trivikr
force-pushed
the
vfs-watchfile-listener-ignore
branch
from
September 23, 2026 06:12
dc9c13b to
1cf3d97
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
force-pushed
the
vfs-watchfile-listener-ignore
branch
from
September 27, 2026 21:20
1cf3d97 to
9401849
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member
Author
|
cc @mcollina Can you take a look? |
fs.watchFile() on a path served by a real-directory mount dispatches to RealFSProvider.watchFile(), which ignored the supplied listener and registered an empty function instead. The user callback never fired after the file changed, and fs.unwatchFile(path, listener) could not match the anonymous stub, so the stat watcher's poll timer stayed registered and kept the process alive. Accept the listener and pass it through to fs.watchFile() so the callback fires on change and unwatchFile() removes it by identity. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: opencode
trivikr
force-pushed
the
vfs-watchfile-listener-ignore
branch
from
November 1, 2026 17:57
9401849 to
0b64419
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66223
fs.watchFile()on a path served by a real-directory mount dispatches toRealFSProvider.watchFile(), which ignored the supplied listener and registered an empty function instead. The user callback never fired after the file changed, andfs.unwatchFile(path, listener)could not match the anonymous stub, so the stat watcher's poll timer stayed registered and kept the process alive.Accept the listener and pass it through to
fs.watchFile()so the callback fires on change andunwatchFile()removes it by identity.Assisted-by: opencode