benchmark: Fix crash in net benchmarks#6407
Closed
matthewloring wants to merge 1 commit intonodejs:masterfrom
matthewloring:ee-prepend
Closed
benchmark: Fix crash in net benchmarks#6407matthewloring wants to merge 1 commit intonodejs:masterfrom matthewloring:ee-prepend
matthewloring wants to merge 1 commit intonodejs:masterfrom
matthewloring:ee-prepend
Conversation
Net benchmarks create partial event emitters that do not have all of the required event emitter functions. They currently mock out `on`, `once`, and `emit` functions. This change mocks out `prependListener` as well to avoid crashing in `_stream_readable`. Fixes #6405
Member
|
LGTM
it is. |
Contributor
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Author
|
Could we address #6405 (comment) in a follow PR or should we set up a way to optionally run benchmarks for correctness in the CI here? |
Author
|
Landed in 89164a0 |
Contributor
|
@matthewloring should this be backported? |
Author
|
Probably not a big deal since these benchmarks will be run from source and not from a distribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
are failing but these should be unrelated.
Affected core subsystem(s)
benchmark
Description of change
Net benchmarks create partial event emitters that do not have all of the
required event emitter functions. They currently mock out
on,once,and
emitfunctions. This change mocks outprependListeneras well toavoid crashing in
_stream_readable.Fixes #6405