Repository navigation
src: handle indexed properties in process.env - #60826
Conversation
5a0fbfe to
9cda07b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60826 +/- ##
==========================================
+ Coverage 88.55% 88.56% +0.01%
==========================================
Files 703 703
Lines 208237 208264 +27
Branches 40157 40162 +5
==========================================
+ Hits 184395 184448 +53
+ Misses 15858 15827 -31
- Partials 7984 7989 +5
🚀 New features to boost your workflow:
|
|
Are there consequences from having the named property enumerator emit numeric values? (I know that's what happens currently...) |
9cda07b to
57da1d7
Compare
57da1d7 to
ef1b42c
Compare
process.envprocess.env
|
Rebased to include #60846 and fixed a typo in the commit message. |
@Renegade334 I think it only affects users of the C++ API, which allows to skip indices. |
|
Landed in 08d966c |
|
This doesn't build on v24.x-staging ( |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `25.3.0` → `25.4.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v25.4.0`](https://github.com/nodejs/node/releases/tag/v25.4.0): 2026-01-19, Version 25.4.0 (Current), @​RafaelGSS [Compare Source](https://github.com/nodejs/node/compare/v25.3.0...v25.4.0) ##### Notable Changes - \[[`8f6fada8f1`](https://github.com/nodejs/node/commit/8f6fada8f1)] - **cli**: add --require-module/--no-require-module (Joyee Cheung) [#​60959](https://github.com/nodejs/node/pull/60959) - \[[`bf8e738df4`](https://github.com/nodejs/node/commit/bf8e738df4)] - **cli**: mark --heapsnapshot-near-heap-limit as stable (Joyee Cheung) [#​60956](https://github.com/nodejs/node/pull/60956) - \[[`7930d7a19b`](https://github.com/nodejs/node/commit/7930d7a19b)] - **crypto**: update root certificates to NSS 3.117 (Node.js GitHub Bot) [#​60741](https://github.com/nodejs/node/pull/60741) - \[[`44f61dfb92`](https://github.com/nodejs/node/commit/44f61dfb92)] - **doc**: add [@​avivkeller](https://github.com/avivkeller) to collaborators (Aviv Keller) [#​61115](https://github.com/nodejs/node/pull/61115) - \[[`45903ee884`](https://github.com/nodejs/node/commit/45903ee884)] - **doc**: add gurgunday to collaborators (Gürgün Dayıoğlu) [#​61094](https://github.com/nodejs/node/pull/61094) - \[[`77faa14d99`](https://github.com/nodejs/node/commit/77faa14d99)] - **doc**: mark --build-snapshot and --build-snapshot-config as stable (Joyee Cheung) [#​60954](https://github.com/nodejs/node/pull/60954) - \[[`aefbe4ba47`](https://github.com/nodejs/node/commit/aefbe4ba47)] - **(SEMVER-MINOR)** **events**: repurpose `events.listenerCount()` to accept EventTargets (René) [#​60214](https://github.com/nodejs/node/pull/60214) - \[[`8470e2993b`](https://github.com/nodejs/node/commit/8470e2993b)] - **(SEMVER-MINOR)** **http**: add http.setGlobalProxyFromEnv() (Joyee Cheung) [#​60953](https://github.com/nodejs/node/pull/60953) - \[[`24384d7438`](https://github.com/nodejs/node/commit/24384d7438)] - **meta**: add Renegade334 to collaborators (Renegade334) [#​60714](https://github.com/nodejs/node/pull/60714) - \[[`c1acef6d0f`](https://github.com/nodejs/node/commit/c1acef6d0f)] - **module**: mark require(esm) as stable (Joyee Cheung) [#​60959](https://github.com/nodejs/node/pull/60959) - \[[`2e39f3ed6b`](https://github.com/nodejs/node/commit/2e39f3ed6b)] - **module**: mark module compile cache as stable (Joyee Cheung) [#​60971](https://github.com/nodejs/node/pull/60971) - \[[`e6a05cfb4f`](https://github.com/nodejs/node/commit/e6a05cfb4f)] - **(SEMVER-MINOR)** **module**: allow subpath imports that start with `#/` (Jan Martin) [#​60864](https://github.com/nodejs/node/pull/60864) - \[[`fa927c31da`](https://github.com/nodejs/node/commit/fa927c31da)] - **(SEMVER-MINOR)** **process**: preserve AsyncLocalStorage in queueMicrotask only when needed (Gürgün Dayıoğlu) [#​60913](https://github.com/nodejs/node/pull/60913) - \[[`bd0942f4f5`](https://github.com/nodejs/node/commit/bd0942f4f5)] - **(SEMVER-MINOR)** **stream**: do not pass `readable.compose()` output via `Readable.from()` (René) [#​60907](https://github.com/nodejs/node/pull/60907) - \[[`5051d90100`](https://github.com/nodejs/node/commit/5051d90100)] - **(SEMVER-MINOR)** **util**: add convertProcessSignalToExitCode utility (Erick Wendel) [#​60963](https://github.com/nodejs/node/pull/60963) - \[[`408f024906`](https://github.com/nodejs/node/commit/408f024906)] - **v8**: mark v8.queryObjects() as stable (Joyee Cheung) [#​60957](https://github.com/nodejs/node/pull/60957) ##### Commits - \[[`e61cfdbf50`](https://github.com/nodejs/node/commit/e61cfdbf50)] - **assert**: use a set instead of an array for faster lookup (Ruben Bridgewater) [#​61076](https://github.com/nodejs/node/pull/61076) - \[[`11861084fd`](https://github.com/nodejs/node/commit/11861084fd)] - **assert,util**: improve comparison performance (Ruben Bridgewater) [#​61176](https://github.com/nodejs/node/pull/61176) - \[[`4ef4f759cb`](https://github.com/nodejs/node/commit/4ef4f759cb)] - **assert,util**: fix deep comparing invalid dates skipping properties (Ruben Bridgewater) [#​61076](https://github.com/nodejs/node/pull/61076) - \[[`c8fccd585f`](https://github.com/nodejs/node/commit/c8fccd585f)] - **assert,util**: improve deep comparison performance (Ruben Bridgewater) [#​61076](https://github.com/nodejs/node/pull/61076) - \[[`13661a0123`](https://github.com/nodejs/node/commit/13661a0123)] - **benchmark**: use boolean options in benchmark tests (SeokhunEom) [#​60129](https://github.com/nodejs/node/pull/60129) - \[[`36dead3433`](https://github.com/nodejs/node/commit/36dead3433)] - **benchmark**: allow boolean option values (SeokhunEom) [#​60129](https://github.com/nodejs/node/pull/60129) - \[[`376056eaef`](https://github.com/nodejs/node/commit/376056eaef)] - **benchmark**: add microbench on isInsideNodeModules (Chengzhong Wu) [#​60991](https://github.com/nodejs/node/pull/60991) - \[[`22d3e85b7a`](https://github.com/nodejs/node/commit/22d3e85b7a)] - **benchmark**: fix incorrect base64 input in byteLength benchmark (semimikoh) [#​60841](https://github.com/nodejs/node/pull/60841) - \[[`5016f75522`](https://github.com/nodejs/node/commit/5016f75522)] - **benchmark**: use typescript for import cjs benchmark (Joyee Cheung) [#​60663](https://github.com/nodejs/node/pull/60663) - \[[`012a08f6eb`](https://github.com/nodejs/node/commit/012a08f6eb)] - **buffer**: let Buffer.of use heap (Сковорода Никита Андреевич) [#​60503](https://github.com/nodejs/node/pull/60503) - \[[`65696e42ba`](https://github.com/nodejs/node/commit/65696e42ba)] - **build**: add `--shared-hdr-histogram` configure flag (Antoine du Hamel) [#​61280](https://github.com/nodejs/node/pull/61280) - \[[`6155b8836e`](https://github.com/nodejs/node/commit/6155b8836e)] - **build**: add `--shared-gtest` configure flag (Antoine du Hamel) [#​61279](https://github.com/nodejs/node/pull/61279) - \[[`e80127f49c`](https://github.com/nodejs/node/commit/e80127f49c)] - **build**: expose libplatform symbols in shared libnode (Joyee Cheung) [#​61144](https://github.com/nodejs/node/pull/61144) - \[[`d99805049e`](https://github.com/nodejs/node/commit/d99805049e)] - **build**: fix inconsistent quoting in `Makefile` (Antoine du Hamel) [#​60511](https://github.com/nodejs/node/pull/60511) - \[[`3213de08e8`](https://github.com/nodejs/node/commit/3213de08e8)] - **build**: support building crates (temporal) on windows (沈鸿飞) [#​61163](https://github.com/nodejs/node/pull/61163) - \[[`1ad8788391`](https://github.com/nodejs/node/commit/1ad8788391)] - **build**: remove temporal updater (Chengzhong Wu) [#​61151](https://github.com/nodejs/node/pull/61151) - \[[`e6e25d65be`](https://github.com/nodejs/node/commit/e6e25d65be)] - **build**: add --debug-symbols to build with -g without enabling DCHECKs (Joyee Cheung) [#​61100](https://github.com/nodejs/node/pull/61100) - \[[`7040ec94c8`](https://github.com/nodejs/node/commit/7040ec94c8)] - **build**: update test-wpt-report to use NODE instead of OUT\_NODE (Filip Skokan) [#​61024](https://github.com/nodejs/node/pull/61024) - \[[`990da3518d`](https://github.com/nodejs/node/commit/990da3518d)] - **build**: skip build-ci on actions with a separate test step (Chengzhong Wu) [#​61073](https://github.com/nodejs/node/pull/61073) - \[[`3259e395c9`](https://github.com/nodejs/node/commit/3259e395c9)] - **build**: run embedtest with node\_g when BUILDTYPE=Debug (Chengzhong Wu) [#​60850](https://github.com/nodejs/node/pull/60850) - \[[`af42ca569f`](https://github.com/nodejs/node/commit/af42ca569f)] - **build**: ignore built-in temporal when building with shared lib (Chengzhong Wu) [#​60703](https://github.com/nodejs/node/pull/60703) - \[[`bec7fce07a`](https://github.com/nodejs/node/commit/bec7fce07a)] - **build**: add temporal\_capi gyp (Chengzhong Wu) [#​60703](https://github.com/nodejs/node/pull/60703) - \[[`d2f50047f7`](https://github.com/nodejs/node/commit/d2f50047f7)] - **build**: fix OpenSSL version parsing for OpenSSL < 3 (Richard Lau) [#​60775](https://github.com/nodejs/node/pull/60775) - \[[`91b20c52df`](https://github.com/nodejs/node/commit/91b20c52df)] - **build**: add flag to compile V8 with Temporal support (Antoine du Hamel) [#​60701](https://github.com/nodejs/node/pull/60701) - \[[`0aaed248f0`](https://github.com/nodejs/node/commit/0aaed248f0)] - **build**: add support for Visual Studio 2026 (Michaël Zasso) [#​60727](https://github.com/nodejs/node/pull/60727) - \[[`8f6fada8f1`](https://github.com/nodejs/node/commit/8f6fada8f1)] - **cli**: add --require-module/--no-require-module (Joyee Cheung) [#​60959](https://github.com/nodejs/node/pull/60959) - \[[`bf8e738df4`](https://github.com/nodejs/node/commit/bf8e738df4)] - **cli**: mark --heapsnapshot-near-heap-limit as stable (Joyee Cheung) [#​60956](https://github.com/nodejs/node/pull/60956) - \[[`7930d7a19b`](https://github.com/nodejs/node/commit/7930d7a19b)] - **crypto**: update root certificates to NSS 3.117 (Node.js GitHub Bot) [#​60741](https://github.com/nodejs/node/pull/60741) - \[[`1b15453602`](https://github.com/nodejs/node/commit/1b15453602)] - **deps**: update cjs-module-lexer to 2.2.0 (Node.js GitHub Bot) [#​61271](https://github.com/nodejs/node/pull/61271) - \[[`118fa97c95`](https://github.com/nodejs/node/commit/118fa97c95)] - **deps**: update nbytes to 0.1.2 (Node.js GitHub Bot) [#​61270](https://github.com/nodejs/node/pull/61270) - \[[`9b136db814`](https://github.com/nodejs/node/commit/9b136db814)] - **deps**: update ngtcp2 to 1.19.0 (Node.js GitHub Bot) [#​61156](https://github.com/nodejs/node/pull/61156) - \[[`5635f23a50`](https://github.com/nodejs/node/commit/5635f23a50)] - **deps**: update nghttp3 to 1.14.0 (Node.js GitHub Bot) [#​61187](https://github.com/nodejs/node/pull/61187) - \[[`9ec35c0977`](https://github.com/nodejs/node/commit/9ec35c0977)] - **deps**: update nghttp3 to 1.13.1 (Node.js GitHub Bot) [#​60046](https://github.com/nodejs/node/pull/60046) - \[[`4d7d37f701`](https://github.com/nodejs/node/commit/4d7d37f701)] - **deps**: update timezone to 2025c (Node.js GitHub Bot) [#​61138](https://github.com/nodejs/node/pull/61138) - \[[`2c1e3ab19d`](https://github.com/nodejs/node/commit/2c1e3ab19d)] - **deps**: nghttp2: revert [`7784fa9`](https://github.com/nodejs/node/commit/7784fa979d0b) (Antoine du Hamel) [#​61136](https://github.com/nodejs/node/pull/61136) - \[[`56a6513648`](https://github.com/nodejs/node/commit/56a6513648)] - **deps**: update nghttp2 to 1.68.0 (nodejs-github-bot) [#​61136](https://github.com/nodejs/node/pull/61136) - \[[`f2692c5534`](https://github.com/nodejs/node/commit/f2692c5534)] - **deps**: remove independent temporal (Chengzhong Wu) [#​61072](https://github.com/nodejs/node/pull/61072) - \[[`3acbf3f129`](https://github.com/nodejs/node/commit/3acbf3f129)] - **deps**: apply cargo vendor (Chengzhong Wu) [#​61072](https://github.com/nodejs/node/pull/61072) - \[[`d2759f4805`](https://github.com/nodejs/node/commit/d2759f4805)] - **deps**: add vendor depenency crate (Chengzhong Wu) [#​61072](https://github.com/nodejs/node/pull/61072) - \[[`6330385174`](https://github.com/nodejs/node/commit/6330385174)] - **deps**: update simdjson to 4.2.4 (Node.js GitHub Bot) [#​61056](https://github.com/nodejs/node/pull/61056) - \[[`9835860115`](https://github.com/nodejs/node/commit/9835860115)] - **deps**: update googletest to [`065127f`](https://github.com/nodejs/node/commit/065127f1e4b46c5f14fc73cf8d323c221f9dc68e) (Node.js GitHub Bot) [#​61055](https://github.com/nodejs/node/pull/61055) - \[[`d2e6dff2f9`](https://github.com/nodejs/node/commit/d2e6dff2f9)] - **deps**: brotli: cherry-pick [`e230f47`](https://github.com/nodejs/node/commit/e230f474b87) (liujiahui) [#​61003](https://github.com/nodejs/node/pull/61003) - \[[`27da9ca1c7`](https://github.com/nodejs/node/commit/27da9ca1c7)] - **deps**: upgrade npm to 11.7.0 (npm team) [#​61011](https://github.com/nodejs/node/pull/61011) - \[[`398ba68793`](https://github.com/nodejs/node/commit/398ba68793)] - **deps**: V8: cherry-pick [`72b0e27`](https://github.com/nodejs/node/commit/72b0e27bd936) (pthier) [#​60706](https://github.com/nodejs/node/pull/60706) - \[[`a8ae3b9557`](https://github.com/nodejs/node/commit/a8ae3b9557)] - **deps**: update sqlite to 3.51.1 (Node.js GitHub Bot) [#​60899](https://github.com/nodejs/node/pull/60899) - \[[`4e1edae655`](https://github.com/nodejs/node/commit/4e1edae655)] - **deps**: update zlib to 1.3.1-63d7e16 (Node.js GitHub Bot) [#​60898](https://github.com/nodejs/node/pull/60898) - \[[`49b5954e74`](https://github.com/nodejs/node/commit/49b5954e74)] - **deps**: update corepack to 0.34.5 (Node.js GitHub Bot) [#​60842](https://github.com/nodejs/node/pull/60842) - \[[`6ae415361f`](https://github.com/nodejs/node/commit/6ae415361f)] - **deps**: upgrade npm to 11.6.4 (npm team) [#​60853](https://github.com/nodejs/node/pull/60853) - \[[`3cc857001a`](https://github.com/nodejs/node/commit/3cc857001a)] - **deps**: add temporal\_rs 0.1.0 (Chengzhong Wu) [#​60703](https://github.com/nodejs/node/pull/60703) - \[[`660788cd4b`](https://github.com/nodejs/node/commit/660788cd4b)] - **deps**: update sqlite to 3.51.0 (Node.js GitHub Bot) [#​60614](https://github.com/nodejs/node/pull/60614) - \[[`c6d7a7b7cd`](https://github.com/nodejs/node/commit/c6d7a7b7cd)] - **deps**: upgrade npm to 11.6.3 (npm team) [#​60785](https://github.com/nodejs/node/pull/60785) - \[[`062e15bddf`](https://github.com/nodejs/node/commit/062e15bddf)] - **deps**: update brotli to 1.2.0 (Node.js GitHub Bot) [#​60540](https://github.com/nodejs/node/pull/60540) - \[[`db053988db`](https://github.com/nodejs/node/commit/db053988db)] - **deps**: update simdjson to 4.2.2 (Node.js GitHub Bot) [#​60740](https://github.com/nodejs/node/pull/60740) - \[[`ea5deab531`](https://github.com/nodejs/node/commit/ea5deab531)] - **deps**: update googletest to [`1b96fa1`](https://github.com/nodejs/node/commit/1b96fa13f549387b7549cc89e1a785cf143a1a50) (Node.js GitHub Bot) [#​60739](https://github.com/nodejs/node/pull/60739) - \[[`c23f40cca4`](https://github.com/nodejs/node/commit/c23f40cca4)] - **deps**: update minimatch to 10.1.1 (Node.js GitHub Bot) [#​60543](https://github.com/nodejs/node/pull/60543) - \[[`479c9290b9`](https://github.com/nodejs/node/commit/479c9290b9)] - **deps**: update corepack to 0.34.4 (Node.js GitHub Bot) [#​60643](https://github.com/nodejs/node/pull/60643) - \[[`e42911eddd`](https://github.com/nodejs/node/commit/e42911eddd)] - **deps**: update inspector\_protocol to [`1b1bcbb`](https://github.com/nodejs/node/commit/1b1bcbbe060e8c8cd8704f00f78978c50991) (Node.js GitHub Bot) [#​60705](https://github.com/nodejs/node/pull/60705) - \[[`d908c83330`](https://github.com/nodejs/node/commit/d908c83330)] - **deps**: update cjs-module-lexer to 2.1.1 (Node.js GitHub Bot) [#​60646](https://github.com/nodejs/node/pull/60646) - \[[`96530a4ca6`](https://github.com/nodejs/node/commit/96530a4ca6)] - **deps**: update simdjson to 4.2.1 (Node.js GitHub Bot) [#​60644](https://github.com/nodejs/node/pull/60644) - \[[`6b0926ef20`](https://github.com/nodejs/node/commit/6b0926ef20)] - **deps,src**: prepare for cpplint update (Michaël Zasso) [#​60901](https://github.com/nodejs/node/pull/60901) - \[[`5ed71efa3e`](https://github.com/nodejs/node/commit/5ed71efa3e)] - **doc**: fix v25 changelog after security release (Marco Ippolito) [#​61371](https://github.com/nodejs/node/pull/61371) - \[[`c2791069a2`](https://github.com/nodejs/node/commit/c2791069a2)] - **doc**: correct description of `error.stack` accessor behavior (René) [#​61090](https://github.com/nodejs/node/pull/61090) - \[[`134780c035`](https://github.com/nodejs/node/commit/134780c035)] - **doc**: add documentation for process.traceProcessWarnings (Alireza Ebrahimkhani) [#​53641](https://github.com/nodejs/node/pull/53641) - \[[`3b08efcebb`](https://github.com/nodejs/node/commit/3b08efcebb)] - **doc**: add sqlite session disposal method (René) [#​61273](https://github.com/nodejs/node/pull/61273) - \[[`ec1847a097`](https://github.com/nodejs/node/commit/ec1847a097)] - **doc**: fix filename typo (Hardanish Singh) [#​61297](https://github.com/nodejs/node/pull/61297) - \[[`2c651ce460`](https://github.com/nodejs/node/commit/2c651ce460)] - **doc**: fix typos and grammar in `BUILDING.md` & `onboarding.md` (Hardanish Singh) [#​61267](https://github.com/nodejs/node/pull/61267) - \[[`28fe6ea4a8`](https://github.com/nodejs/node/commit/28fe6ea4a8)] - **doc**: mention --newVersion release script (Rafael Gonzaga) [#​61255](https://github.com/nodejs/node/pull/61255) - \[[`2fb35d897d`](https://github.com/nodejs/node/commit/2fb35d897d)] - **doc**: correct typo in BUILDING doc (Mike McCready) [#​61261](https://github.com/nodejs/node/pull/61261) - \[[`8dc2501a25`](https://github.com/nodejs/node/commit/8dc2501a25)] - **doc**: correct typo in api contributing doc (Mike McCready) [#​61260](https://github.com/nodejs/node/pull/61260) - \[[`69e357a9d4`](https://github.com/nodejs/node/commit/69e357a9d4)] - **doc**: add MR-URL requirement for security backports (Rafael Gonzaga) [#​61256](https://github.com/nodejs/node/pull/61256) - \[[`73326ae103`](https://github.com/nodejs/node/commit/73326ae103)] - **doc**: add reusePort error behavior to net module (mag123c) [#​61250](https://github.com/nodejs/node/pull/61250) - \[[`67fbf4d371`](https://github.com/nodejs/node/commit/67fbf4d371)] - **doc**: note corepack package removal in distribution doc (Mike McCready) [#​61207](https://github.com/nodejs/node/pull/61207) - \[[`0792859e49`](https://github.com/nodejs/node/commit/0792859e49)] - **doc**: fix tls.connect() timeout documentation (Azad Gupta) [#​61079](https://github.com/nodejs/node/pull/61079) - \[[`72f42b9985`](https://github.com/nodejs/node/commit/72f42b9985)] - **doc**: missing `passed`, `error` and `passed` properties on `TestContext` (Xavier Stouder) [#​61185](https://github.com/nodejs/node/pull/61185) - \[[`f418fcc635`](https://github.com/nodejs/node/commit/f418fcc635)] - **doc**: clarify threat model for application-level API exposure (Rafael Gonzaga) [#​61184](https://github.com/nodejs/node/pull/61184) - \[[`bd4710769a`](https://github.com/nodejs/node/commit/bd4710769a)] - **doc**: correct options for net.Socket class and socket.connect (Xavier Stouder) [#​61179](https://github.com/nodejs/node/pull/61179) - \[[`387b65ca08`](https://github.com/nodejs/node/commit/387b65ca08)] - **doc**: document error event on readline InterfaceConstructor (Xavier Stouder) [#​61170](https://github.com/nodejs/node/pull/61170) - \[[`6d886e10e4`](https://github.com/nodejs/node/commit/6d886e10e4)] - **doc**: add a smooth scrolling effect to the sidebar (btea) [#​59007](https://github.com/nodejs/node/pull/59007) - \[[`23fb3a64ec`](https://github.com/nodejs/node/commit/23fb3a64ec)] - **doc**: fix test settime docs (Efe) [#​61117](https://github.com/nodejs/node/pull/61117) - \[[`808eb437ee`](https://github.com/nodejs/node/commit/808eb437ee)] - **doc**: correct invalid collaborator profile (JJ) [#​61091](https://github.com/nodejs/node/pull/61091) - \[[`5e8eb5fe6c`](https://github.com/nodejs/node/commit/5e8eb5fe6c)] - **doc**: add a tip about developer mode on Windows (Joyee Cheung) [#​61112](https://github.com/nodejs/node/pull/61112) - \[[`a4248776da`](https://github.com/nodejs/node/commit/a4248776da)] - **doc**: exclude compile-time flag features from security policy (Matteo Collina) [#​61109](https://github.com/nodejs/node/pull/61109) - \[[`44f61dfb92`](https://github.com/nodejs/node/commit/44f61dfb92)] - **doc**: add [@​avivkeller](https://github.com/avivkeller) to collaborators (Aviv Keller) [#​61115](https://github.com/nodejs/node/pull/61115) - \[[`08b5347b41`](https://github.com/nodejs/node/commit/08b5347b41)] - **doc**: warn about short GCM tags visibly (Tobias Nießen) [#​61082](https://github.com/nodejs/node/pull/61082) - \[[`45903ee884`](https://github.com/nodejs/node/commit/45903ee884)] - **doc**: add gurgunday to collaborators (Gürgün Dayıoğlu) [#​61094](https://github.com/nodejs/node/pull/61094) - \[[`ce5d6e22ef`](https://github.com/nodejs/node/commit/ce5d6e22ef)] - **doc**: update MDN links (Livia Medeiros) [#​61062](https://github.com/nodejs/node/pull/61062) - \[[`657cbd4af3`](https://github.com/nodejs/node/commit/657cbd4af3)] - **doc**: mark sync module hooks as release candidate (Joyee Cheung) [#​60960](https://github.com/nodejs/node/pull/60960) - \[[`a46368a82b`](https://github.com/nodejs/node/commit/a46368a82b)] - **doc**: reorganize docs of module customization hooks (Joyee Cheung) [#​60960](https://github.com/nodejs/node/pull/60960) - \[[`9851278e99`](https://github.com/nodejs/node/commit/9851278e99)] - **doc**: mark crypto.hash as stable (Joyee Cheung) [#​60994](https://github.com/nodejs/node/pull/60994) - \[[`77faa14d99`](https://github.com/nodejs/node/commit/77faa14d99)] - **doc**: mark --build-snapshot and --build-snapshot-config as stable (Joyee Cheung) [#​60954](https://github.com/nodejs/node/pull/60954) - \[[`6d5f9ffc6d`](https://github.com/nodejs/node/commit/6d5f9ffc6d)] - **doc**: add File modes cross-references in fs methods (Mohit Raj Saxena) [#​60286](https://github.com/nodejs/node/pull/60286) - \[[`521b25a27d`](https://github.com/nodejs/node/commit/521b25a27d)] - **doc**: add missing `zstd` to mjs example of zlib (Deokjin Kim) [#​60915](https://github.com/nodejs/node/pull/60915) - \[[`9a9bed9b3a`](https://github.com/nodejs/node/commit/9a9bed9b3a)] - **doc**: clarify fileURLToPath security considerations (Rafael Gonzaga) [#​60887](https://github.com/nodejs/node/pull/60887) - \[[`bebb4731b1`](https://github.com/nodejs/node/commit/bebb4731b1)] - **doc**: show the use of string expressions in the SQLTagStore example (schliepa) [#​60873](https://github.com/nodejs/node/pull/60873) - \[[`f247c24cb0`](https://github.com/nodejs/node/commit/f247c24cb0)] - **doc**: replace column with columnNumber in example of `util.getCallSites` (Deokjin Kim) [#​60881](https://github.com/nodejs/node/pull/60881) - \[[`487c1080aa`](https://github.com/nodejs/node/commit/487c1080aa)] - **doc**: correct spelling in BUILDING.md (Rich Trott) [#​60875](https://github.com/nodejs/node/pull/60875) - \[[`5751e3f736`](https://github.com/nodejs/node/commit/5751e3f736)] - **doc**: update debuglog examples to use 'foo-bar' instead of 'foo' (xiaoyao) [#​60867](https://github.com/nodejs/node/pull/60867) - \[[`ec8336b7a0`](https://github.com/nodejs/node/commit/ec8336b7a0)] - **doc**: correct 'event handle' to 'event handler' in Utf8Stream drop event (Riddhi) [#​60692](https://github.com/nodejs/node/pull/60692) - \[[`95ef052751`](https://github.com/nodejs/node/commit/95ef052751)] - **doc**: fix typos in changelogs (Rich Trott) [#​60855](https://github.com/nodejs/node/pull/60855) - \[[`a10b3130c6`](https://github.com/nodejs/node/commit/a10b3130c6)] - **doc**: mark module.register as active development (Chengzhong Wu) [#​60849](https://github.com/nodejs/node/pull/60849) - \[[`bfe8c62a2d`](https://github.com/nodejs/node/commit/bfe8c62a2d)] - **doc**: add fullName property to SuiteContext (PaulyBearCoding) [#​60762](https://github.com/nodejs/node/pull/60762) - \[[`2799f594e3`](https://github.com/nodejs/node/commit/2799f594e3)] - **doc**: add additional codemods for deprecation (Augustin Mauroy) [#​60811](https://github.com/nodejs/node/pull/60811) - \[[`2b51d5d113`](https://github.com/nodejs/node/commit/2b51d5d113)] - **doc**: keep sidebar module visible when navigating docs (Botato) [#​60410](https://github.com/nodejs/node/pull/60410) - \[[`2fa9917b07`](https://github.com/nodejs/node/commit/2fa9917b07)] - **doc**: fix webstorage config file property (Marco Ippolito) [#​60798](https://github.com/nodejs/node/pull/60798) - \[[`a0691d6eb6`](https://github.com/nodejs/node/commit/a0691d6eb6)] - **doc**: correct concurrency wording in test() documentation (Azad Gupta) [#​60773](https://github.com/nodejs/node/pull/60773) - \[[`d26842c523`](https://github.com/nodejs/node/commit/d26842c523)] - **doc**: clarify that CQ only picks up MRs targeting `main` (René) [#​60731](https://github.com/nodejs/node/pull/60731) - \[[`3e84428ffe`](https://github.com/nodejs/node/commit/3e84428ffe)] - **doc**: clarify license section and add contributor note (KaleruMadhu) [#​60590](https://github.com/nodejs/node/pull/60590) - \[[`745ea1d61f`](https://github.com/nodejs/node/commit/745ea1d61f)] - **doc**: correct and expand documentation for SQLTagStore (René) [#​60200](https://github.com/nodejs/node/pull/60200) - \[[`a442c27c0a`](https://github.com/nodejs/node/commit/a442c27c0a)] - **doc**: correct tls ALPNProtocols types (René) [#​60143](https://github.com/nodejs/node/pull/60143) - \[[`d90001a579`](https://github.com/nodejs/node/commit/d90001a579)] - **doc**: remove mention of SMS 2FA (Antoine du Hamel) [#​60707](https://github.com/nodejs/node/pull/60707) - \[[`7525a3fa4b`](https://github.com/nodejs/node/commit/7525a3fa4b)] - **doc**: add info about renamed flag in `cli.md` (Antoine du Hamel) [#​60690](https://github.com/nodejs/node/pull/60690) - \[[`db0a86897b`](https://github.com/nodejs/node/commit/db0a86897b)] - **doc**: fix incorrect slh-dsa oids in crypto.md (Artsiom Malakhau) [#​60681](https://github.com/nodejs/node/pull/60681) - \[[`e5ede89a94`](https://github.com/nodejs/node/commit/e5ede89a94)] - **doc**: `domain.add()` does not accept timer objects (René) [#​60675](https://github.com/nodejs/node/pull/60675) - \[[`36ba9d99ba`](https://github.com/nodejs/node/commit/36ba9d99ba)] - ***Revert*** "**doc, assert**: correct order of changes entries" (Michaël Zasso) [#​60774](https://github.com/nodejs/node/pull/60774) - \[[`e6e5ed7665`](https://github.com/nodejs/node/commit/e6e5ed7665)] - **doc,test**: add documentation and test on how to use addons in SEA (Joyee Cheung) [#​59582](https://github.com/nodejs/node/pull/59582) - \[[`f12eb28489`](https://github.com/nodejs/node/commit/f12eb28489)] - **esm**: avoid throw when module specifier is not url (Craig Macomber (Microsoft)) [#​61000](https://github.com/nodejs/node/pull/61000) - \[[`a7b92e0677`](https://github.com/nodejs/node/commit/a7b92e0677)] - **esm**: improve error messages for ambiguous module syntax (mag123c) [#​60376](https://github.com/nodejs/node/pull/60376) - \[[`6da85b576b`](https://github.com/nodejs/node/commit/6da85b576b)] - **events**: remove eventtarget custom inspect branding (Efe) [#​61128](https://github.com/nodejs/node/pull/61128) - \[[`aefbe4ba47`](https://github.com/nodejs/node/commit/aefbe4ba47)] - **(SEMVER-MINOR)** **events**: repurpose `events.listenerCount()` to accept EventTargets (René) [#​60214](https://github.com/nodejs/node/pull/60214) - \[[`dc19409f36`](https://github.com/nodejs/node/commit/dc19409f36)] - **fs**: validate statfs path (Efe) [#​61230](https://github.com/nodejs/node/pull/61230) - \[[`206e353a4a`](https://github.com/nodejs/node/commit/206e353a4a)] - **fs**: fix rmSync to handle non-ASCII characters (Yeaseen) [#​61108](https://github.com/nodejs/node/pull/61108) - \[[`feee377b83`](https://github.com/nodejs/node/commit/feee377b83)] - **fs**: remove broken symlinks in rmSync (sangwook) [#​61040](https://github.com/nodejs/node/pull/61040) - \[[`6b577c80bb`](https://github.com/nodejs/node/commit/6b577c80bb)] - **fs**: detect dot files when using globstar (Robin van Wijngaarden) [#​61012](https://github.com/nodejs/node/pull/61012) - \[[`8470e2993b`](https://github.com/nodejs/node/commit/8470e2993b)] - **(SEMVER-MINOR)** **http**: add http.setGlobalProxyFromEnv() (Joyee Cheung) [#​60953](https://github.com/nodejs/node/pull/60953) - \[[`a731463a60`](https://github.com/nodejs/node/commit/a731463a60)] - **http,https**: fix double ERR\_PROXY\_TUNNEL emission (Shima Ryuhei) [#​60699](https://github.com/nodejs/node/pull/60699) - \[[`b2736646b6`](https://github.com/nodejs/node/commit/b2736646b6)] - **http2,zlib**: prefer `call()` over `apply()` if argument list is not array (Livia Medeiros) [#​60834](https://github.com/nodejs/node/pull/60834) - \[[`86bce15e96`](https://github.com/nodejs/node/commit/86bce15e96)] - **lib**: implement all 1-byte encodings in js (Сковорода Никита Андреевич) [#​61093](https://github.com/nodejs/node/pull/61093) - \[[`8156738b97`](https://github.com/nodejs/node/commit/8156738b97)] - **lib**: gbk decoder is gb18030 decoder per spec (Сковорода Никита Андреевич) [#​61099](https://github.com/nodejs/node/pull/61099) - \[[`d8f1dea0d3`](https://github.com/nodejs/node/commit/d8f1dea0d3)] - **lib**: enforce use of `URLParse` (Antoine du Hamel) [#​61016](https://github.com/nodejs/node/pull/61016) - \[[`9023b3f9ce`](https://github.com/nodejs/node/commit/9023b3f9ce)] - **lib**: add lint rules for reflective function calls (Antoine du Hamel) [#​60825](https://github.com/nodejs/node/pull/60825) - \[[`2979113136`](https://github.com/nodejs/node/commit/2979113136)] - **lib**: prefer `call()` over `apply()` if argument list is not array (Livia Medeiros) [#​60796](https://github.com/nodejs/node/pull/60796) - \[[`2b36433f4a`](https://github.com/nodejs/node/commit/2b36433f4a)] - **lib**: add support for readable byte streams to .toWeb() (Hans Klunder) [#​58664](https://github.com/nodejs/node/pull/58664) - \[[`1a0c3dddb9`](https://github.com/nodejs/node/commit/1a0c3dddb9)] - **lib**: use `FastBuffer` for empty buffer allocation (Gürgün Dayıoğlu) [#​60558](https://github.com/nodejs/node/pull/60558) - \[[`9209cf67a4`](https://github.com/nodejs/node/commit/9209cf67a4)] - **lib**: refactor JWK import PQC support check (Filip Skokan) [#​60586](https://github.com/nodejs/node/pull/60586) - \[[`42666c241a`](https://github.com/nodejs/node/commit/42666c241a)] - **lib,src**: isInsideNodeModules should test on the first non-internal frame (Chengzhong Wu) [#​60991](https://github.com/nodejs/node/pull/60991) - \[[`4a22647609`](https://github.com/nodejs/node/commit/4a22647609)] - **lib,src,test**: fix tests without SQLite (Antoine du Hamel) [#​60906](https://github.com/nodejs/node/pull/60906) - \[[`24795530bb`](https://github.com/nodejs/node/commit/24795530bb)] - **lib,test**: enforce use of `assert.fail` via a lint rule (Antoine du Hamel) [#​61004](https://github.com/nodejs/node/pull/61004) - \[[`1977348ae0`](https://github.com/nodejs/node/commit/1977348ae0)] - **lib,test**: fix jsdoc comments (Michaël Zasso) [#​60870](https://github.com/nodejs/node/pull/60870) - \[[`3549cf14ce`](https://github.com/nodejs/node/commit/3549cf14ce)] - **meta**: remove t.js (RafaelGSS) [#​61369](https://github.com/nodejs/node/pull/61369) - \[[`5cf54abad7`](https://github.com/nodejs/node/commit/5cf54abad7)] - **meta**: bump step-security/harden-runner from 2.13.2 to 2.14.0 (dependabot\[bot]) [#​61245](https://github.com/nodejs/node/pull/61245) - \[[`b57bab72e1`](https://github.com/nodejs/node/commit/b57bab72e1)] - **meta**: bump actions/setup-node from 6.0.0 to 6.1.0 (dependabot\[bot]) [#​61244](https://github.com/nodejs/node/pull/61244) - \[[`42117b5069`](https://github.com/nodejs/node/commit/42117b5069)] - **meta**: bump actions/cache from 4.3.0 to 5.0.1 (dependabot\[bot]) [#​61243](https://github.com/nodejs/node/pull/61243) - \[[`fee3edd38e`](https://github.com/nodejs/node/commit/fee3edd38e)] - **meta**: bump actions/download-artifact from 6.0.0 to 7.0.0 (dependabot\[bot]) [#​61242](https://github.com/nodejs/node/pull/61242) - \[[`a96c3160ff`](https://github.com/nodejs/node/commit/a96c3160ff)] - **meta**: bump github/codeql-action from 4.31.6 to 4.31.9 (dependabot\[bot]) [#​61241](https://github.com/nodejs/node/pull/61241) - \[[`b4233e18a9`](https://github.com/nodejs/node/commit/b4233e18a9)] - **meta**: bump codecov/codecov-action from 5.5.1 to 5.5.2 (dependabot\[bot]) [#​61240](https://github.com/nodejs/node/pull/61240) - \[[`c5d7dd3731`](https://github.com/nodejs/node/commit/c5d7dd3731)] - **meta**: bump actions/checkout from 6.0.0 to 6.0.1 (dependabot\[bot]) [#​61239](https://github.com/nodejs/node/pull/61239) - \[[`d83cec1534`](https://github.com/nodejs/node/commit/d83cec1534)] - **meta**: bump actions/upload-artifact from 5.0.0 to 6.0.0 (dependabot\[bot]) [#​61238](https://github.com/nodejs/node/pull/61238) - \[[`d4bfd26f06`](https://github.com/nodejs/node/commit/d4bfd26f06)] - **meta**: bump peter-evans/create-pull-request from 7.0.9 to 8.0.0 (dependabot\[bot]) [#​61237](https://github.com/nodejs/node/pull/61237) - \[[`9246c6ab12`](https://github.com/nodejs/node/commit/9246c6ab12)] - **meta**: bump cachix/install-nix-action from 31.8.4 to 31.9.0 (dependabot\[bot]) [#​61236](https://github.com/nodejs/node/pull/61236) - \[[`1b378cfd5e`](https://github.com/nodejs/node/commit/1b378cfd5e)] - **meta**: move lukekarrys to emeritus (Node.js GitHub Bot) [#​60985](https://github.com/nodejs/node/pull/60985) - \[[`f3bfa68d78`](https://github.com/nodejs/node/commit/f3bfa68d78)] - **meta**: bump actions/setup-python from 6.0.0 to 6.1.0 (dependabot\[bot]) [#​60927](https://github.com/nodejs/node/pull/60927) - \[[`f1935d19e9`](https://github.com/nodejs/node/commit/f1935d19e9)] - **meta**: bump github/codeql-action from 4.31.3 to 4.31.6 (dependabot\[bot]) [#​60926](https://github.com/nodejs/node/pull/60926) - \[[`0a4a4c090d`](https://github.com/nodejs/node/commit/0a4a4c090d)] - **meta**: bump actions/checkout from 5.0.1 to 6.0.0 (dependabot\[bot]) [#​60925](https://github.com/nodejs/node/pull/60925) - \[[`d76f95117b`](https://github.com/nodejs/node/commit/d76f95117b)] - **meta**: bump peter-evans/create-pull-request from 7.0.8 to 7.0.9 (dependabot\[bot]) [#​60924](https://github.com/nodejs/node/pull/60924) - \[[`4dd153f8c3`](https://github.com/nodejs/node/commit/4dd153f8c3)] - **meta**: bump github/codeql-action from 4.31.2 to 4.31.3 (dependabot\[bot]) [#​60770](https://github.com/nodejs/node/pull/60770) - \[[`a90bf3ece1`](https://github.com/nodejs/node/commit/a90bf3ece1)] - **meta**: bump step-security/harden-runner from 2.13.1 to 2.13.2 (dependabot\[bot]) [#​60769](https://github.com/nodejs/node/pull/60769) - \[[`ecc945d7ec`](https://github.com/nodejs/node/commit/ecc945d7ec)] - **meta**: bump cachix/install-nix-action from 31.8.2 to 31.8.4 (dependabot\[bot]) [#​60768](https://github.com/nodejs/node/pull/60768) - \[[`5578327a4f`](https://github.com/nodejs/node/commit/5578327a4f)] - **meta**: bump actions/checkout from 5.0.0 to 5.0.1 (dependabot\[bot]) [#​60767](https://github.com/nodejs/node/pull/60767) - \[[`24384d7438`](https://github.com/nodejs/node/commit/24384d7438)] - **meta**: add Renegade334 to collaborators (Renegade334) [#​60714](https://github.com/nodejs/node/pull/60714) - \[[`2d560e42fa`](https://github.com/nodejs/node/commit/2d560e42fa)] - **module**: fix sync resolve hooks for require with node: prefixes (Joyee Cheung) [#​61088](https://github.com/nodejs/node/pull/61088) - \[[`15c3655b9a`](https://github.com/nodejs/node/commit/15c3655b9a)] - **module**: preserve URL in the parent created by createRequire() (Joyee Cheung) [#​60974](https://github.com/nodejs/node/pull/60974) - \[[`c1acef6d0f`](https://github.com/nodejs/node/commit/c1acef6d0f)] - **module**: mark require(esm) as stable (Joyee Cheung) [#​60959](https://github.com/nodejs/node/pull/60959) - \[[`2e39f3ed6b`](https://github.com/nodejs/node/commit/2e39f3ed6b)] - **module**: mark module compile cache as stable (Joyee Cheung) [#​60971](https://github.com/nodejs/node/pull/60971) - \[[`e6a05cfb4f`](https://github.com/nodejs/node/commit/e6a05cfb4f)] - **(SEMVER-MINOR)** **module**: allow subpath imports that start with `#/` (Jan Martin) [#​60864](https://github.com/nodejs/node/pull/60864) - \[[`1983cd6692`](https://github.com/nodejs/node/commit/1983cd6692)] - **node-api**: add napi\_set\_prototype (siaeyy) [#​60711](https://github.com/nodejs/node/pull/60711) - \[[`350b0ea895`](https://github.com/nodejs/node/commit/350b0ea895)] - **node-api**: fix data race and use-after-free in napi\_threadsafe\_function (Mika Fischer) [#​55877](https://github.com/nodejs/node/pull/55877) - \[[`cb3f79273a`](https://github.com/nodejs/node/commit/cb3f79273a)] - **node-api**: add support for Float16Array (Ilyas Shabi) [#​58879](https://github.com/nodejs/node/pull/58879) - \[[`bdf359b3d1`](https://github.com/nodejs/node/commit/bdf359b3d1)] - **node-api**: support SharedArrayBuffer in napi\_create\_dataview (Kevin Eady) [#​60473](https://github.com/nodejs/node/pull/60473) - \[[`3c5dc03f06`](https://github.com/nodejs/node/commit/3c5dc03f06)] - **os**: freeze signals constant (Xavier Stouder) [#​61038](https://github.com/nodejs/node/pull/61038) - \[[`ca5c4c9752`](https://github.com/nodejs/node/commit/ca5c4c9752)] - **process**: improve process.cwd() error message (TseIan) [#​61164](https://github.com/nodejs/node/pull/61164) - \[[`fa927c31da`](https://github.com/nodejs/node/commit/fa927c31da)] - **(SEMVER-MINOR)** **process**: preserve AsyncLocalStorage in queueMicrotask only when needed (Gürgün Dayıoğlu) [#​60913](https://github.com/nodejs/node/pull/60913) - \[[`571cec49e0`](https://github.com/nodejs/node/commit/571cec49e0)] - **repl**: fix getters triggering side effects during completion (Dario Piotrowicz) [#​61043](https://github.com/nodejs/node/pull/61043) - \[[`377aed336c`](https://github.com/nodejs/node/commit/377aed336c)] - **repl**: tab completion targets `<class>` instead of `new <class>` (Đỗ Trọng Hải) [#​60319](https://github.com/nodejs/node/pull/60319) - \[[`cb8bc3466d`](https://github.com/nodejs/node/commit/cb8bc3466d)] - **sqlite**: improve error messages for tag store (Pramit Sharma) [#​61096](https://github.com/nodejs/node/pull/61096) - \[[`324ea4fa2d`](https://github.com/nodejs/node/commit/324ea4fa2d)] - **sqlite**: make `SQLTagStore.prototype.size` a getter (René) [#​60246](https://github.com/nodejs/node/pull/60246) - \[[`874c50296d`](https://github.com/nodejs/node/commit/874c50296d)] - **src**: dump snapshot source with node:generate\_default\_snapshot\_source (Joyee Cheung) [#​61101](https://github.com/nodejs/node/pull/61101) - \[[`0692b4f014`](https://github.com/nodejs/node/commit/0692b4f014)] - **src**: improve StringBytes::Encode perf on ASCII (Сковорода Никита Андреевич) [#​61119](https://github.com/nodejs/node/pull/61119) - \[[`754271a1f0`](https://github.com/nodejs/node/commit/754271a1f0)] - **src**: add HandleScope to edge loop in heap\_utils (Mert Can Altin) [#​60885](https://github.com/nodejs/node/pull/60885) - \[[`8f46bd9352`](https://github.com/nodejs/node/commit/8f46bd9352)] - **src**: remove redundant CHECK (Tobias Nießen) [#​61130](https://github.com/nodejs/node/pull/61130) - \[[`5e6ffd9aa0`](https://github.com/nodejs/node/commit/5e6ffd9aa0)] - **src**: remove unused private field in `SQLTagStore` (Michaël Zasso) [#​61027](https://github.com/nodejs/node/pull/61027) - \[[`550e8a7a69`](https://github.com/nodejs/node/commit/550e8a7a69)] - **src**: implement Windows-1252 encoding support and update related tests (Mert Can Altin) [#​60893](https://github.com/nodejs/node/pull/60893) - \[[`3f9c0e07b4`](https://github.com/nodejs/node/commit/3f9c0e07b4)] - **src**: fix off-thread cert loading in bundled cert mode (Joyee Cheung) [#​60764](https://github.com/nodejs/node/pull/60764) - \[[`7eaf815341`](https://github.com/nodejs/node/commit/7eaf815341)] - **src**: handle DER decoding errors from system certificates (Joyee Cheung) [#​60787](https://github.com/nodejs/node/pull/60787) - \[[`6e76cec44a`](https://github.com/nodejs/node/commit/6e76cec44a)] - **src**: use static\_cast instead of C-style cast (Michaël Zasso) [#​60868](https://github.com/nodejs/node/pull/60868) - \[[`103e55487e`](https://github.com/nodejs/node/commit/103e55487e)] - **src**: handle indexed properties in `process.env` (Michaël Zasso) [#​60826](https://github.com/nodejs/node/pull/60826) - \[[`83d1f41752`](https://github.com/nodejs/node/commit/83d1f41752)] - **src**: simply uint32 to string as it must not fail (Chengzhong Wu) [#​60846](https://github.com/nodejs/node/pull/60846) - \[[`2dfdc6f01e`](https://github.com/nodejs/node/commit/2dfdc6f01e)] - **src**: mark unused private field as such (Michaël Zasso) [#​60802](https://github.com/nodejs/node/pull/60802) - \[[`920f02539e`](https://github.com/nodejs/node/commit/920f02539e)] - **src**: implicitly enable namespace in config (Marco Ippolito) [#​60798](https://github.com/nodejs/node/pull/60798) - \[[`47c5bd9b7c`](https://github.com/nodejs/node/commit/47c5bd9b7c)] - **src**: add permission flag to config file (Marco Ippolito) [#​60798](https://github.com/nodejs/node/pull/60798) - \[[`d9df3f710d`](https://github.com/nodejs/node/commit/d9df3f710d)] - **src**: add test flag to config file (Marco Ippolito) [#​60798](https://github.com/nodejs/node/pull/60798) - \[[`831256cb92`](https://github.com/nodejs/node/commit/831256cb92)] - **src**: rename config file testRunner to test (Marco Ippolito) [#​60798](https://github.com/nodejs/node/pull/60798) - \[[`6c2b75ba87`](https://github.com/nodejs/node/commit/6c2b75ba87)] - **src**: split inspector protocol domains files (Chengzhong Wu) [#​60754](https://github.com/nodejs/node/pull/60754) - \[[`51cf032a5e`](https://github.com/nodejs/node/commit/51cf032a5e)] - **src**: add permission support to config file (Marco Ippolito) [#​60746](https://github.com/nodejs/node/pull/60746) - \[[`413db7c635`](https://github.com/nodejs/node/commit/413db7c635)] - **src**: build v8 tick processor as built-in source text modules (Joyee Cheung) [#​60518](https://github.com/nodejs/node/pull/60518) - \[[`428d24acf5`](https://github.com/nodejs/node/commit/428d24acf5)] - **src,permission**: fix permission.has on empty param (Rafael Gonzaga) [#​60674](https://github.com/nodejs/node/pull/60674) - \[[`a60aa72a87`](https://github.com/nodejs/node/commit/a60aa72a87)] - **src,permission**: add debug log on is\_tree\_granted (Rafael Gonzaga) [#​60668](https://github.com/nodejs/node/pull/60668) - \[[`bd0942f4f5`](https://github.com/nodejs/node/commit/bd0942f4f5)] - **(SEMVER-MINOR)** **stream**: do not pass `readable.compose()` output via `Readable.from()` (René) [#​60907](https://github.com/nodejs/node/pull/60907) - \[[`90c12a252a`](https://github.com/nodejs/node/commit/90c12a252a)] - **stream**: fix isErrored/isWritable for WritableStreams (René) [#​60905](https://github.com/nodejs/node/pull/60905) - \[[`9ac774c15b`](https://github.com/nodejs/node/commit/9ac774c15b)] - **test**: asserts that import.meta.resolve invokes sync loader hooks (Chengzhong Wu) [#​61158](https://github.com/nodejs/node/pull/61158) - \[[`c08afc5712`](https://github.com/nodejs/node/commit/c08afc5712)] - **test**: check util.parseArgs argv parsing with actual process execution (René) [#​61089](https://github.com/nodejs/node/pull/61089) - \[[`182f2e4b5a`](https://github.com/nodejs/node/commit/182f2e4b5a)] - **test**: update WPT for urlpattern to [`a2e15ad`](https://github.com/nodejs/node/commit/a2e15ad405) (Node.js GitHub Bot) [#​61134](https://github.com/nodejs/node/pull/61134) - \[[`9f7cc779f5`](https://github.com/nodejs/node/commit/9f7cc779f5)] - **test**: make buffer sizes 32bit-aware in test-internal-util-construct-sab (René) [#​61026](https://github.com/nodejs/node/pull/61026) - \[[`c6a8234963`](https://github.com/nodejs/node/commit/c6a8234963)] - **test**: remove unneccessary repl magic\_mode tests (Dario Piotrowicz) [#​61053](https://github.com/nodejs/node/pull/61053) - \[[`fa2fe0930f`](https://github.com/nodejs/node/commit/fa2fe0930f)] - **test**: skip sea tests on riscv64 (Stewart X Addison) [#​61111](https://github.com/nodejs/node/pull/61111) - \[[`b209f6ba19`](https://github.com/nodejs/node/commit/b209f6ba19)] - **test**: simplify `test-cli-node-options-docs` (Antoine du Hamel) [#​61006](https://github.com/nodejs/node/pull/61006) - \[[`c9153c7d4f`](https://github.com/nodejs/node/commit/c9153c7d4f)] - **test**: mark stringbytes-external-max flaky on AIX (Stewart X Addison) [#​60995](https://github.com/nodejs/node/pull/60995) - \[[`2cbddfefb7`](https://github.com/nodejs/node/commit/2cbddfefb7)] - **test**: update test426 fixtures (Rich Trott) [#​60982](https://github.com/nodejs/node/pull/60982) - \[[`c7190e6876`](https://github.com/nodejs/node/commit/c7190e6876)] - **test**: update WPT for urlpattern to [`aed1f3d`](https://github.com/nodejs/node/commit/aed1f3d244) (Node.js GitHub Bot) [#​60642](https://github.com/nodejs/node/pull/60642) - \[[`92649e2873`](https://github.com/nodejs/node/commit/92649e2873)] - **test**: deflake `test-repl-paste-big-data` (Livia Medeiros) [#​60975](https://github.com/nodejs/node/pull/60975) - \[[`e4bc345442`](https://github.com/nodejs/node/commit/e4bc345442)] - **test**: skip tests not passing without `NODE_OPTIONS` support (Antoine du Hamel) [#​60912](https://github.com/nodejs/node/pull/60912) - \[[`63299a47ec`](https://github.com/nodejs/node/commit/63299a47ec)] - **test**: improve config-file permission test coverage (Rafael Gonzaga) [#​60929](https://github.com/nodejs/node/pull/60929) - \[[`9a0c420a33`](https://github.com/nodejs/node/commit/9a0c420a33)] - **test**: skip SEA inspect test if inspector is not available (Livia Medeiros) [#​60872](https://github.com/nodejs/node/pull/60872) - \[[`e97daea17c`](https://github.com/nodejs/node/commit/e97daea17c)] - **test**: update WPT for WebCryptoAPI to [`1e49331`](https://github.com/nodejs/node/commit/1e4933113d) (Node.js GitHub Bot) [#​60896](https://github.com/nodejs/node/pull/60896) - \[[`ac367b3550`](https://github.com/nodejs/node/commit/ac367b3550)] - **test**: lint more `assert(regexp.test(...))` cases (René) [#​60878](https://github.com/nodejs/node/pull/60878) - \[[`ca5720e7b5`](https://github.com/nodejs/node/commit/ca5720e7b5)] - **test**: use `assert.match` for non-literal regexp tests (René) [#​60879](https://github.com/nodejs/node/pull/60879) - \[[`5d30d3fc2d`](https://github.com/nodejs/node/commit/5d30d3fc2d)] - **test**: fix embedtest in debug windows (Vladimir Morozov) [#​60806](https://github.com/nodejs/node/pull/60806) - \[[`8caeb03a52`](https://github.com/nodejs/node/commit/8caeb03a52)] - **test**: skip failing tests when compiled without amaro (Yuki Okita) [#​60815](https://github.com/nodejs/node/pull/60815) - \[[`242e20bf9a`](https://github.com/nodejs/node/commit/242e20bf9a)] - **test**: fix debug test crashes caused by sea tests (Vladimir Morozov) [#​60807](https://github.com/nodejs/node/pull/60807) - \[[`b890362e1a`](https://github.com/nodejs/node/commit/b890362e1a)] - **test**: add lint rule to forbid use of `assert.ok(/regex/.test(…))` (Antoine du Hamel) [#​60832](https://github.com/nodejs/node/pull/60832) - \[[`b08cb5657e`](https://github.com/nodejs/node/commit/b08cb5657e)] - **test**: replace deprecated regex test assertions in http trailers test (Aditya Chopra) [#​60831](https://github.com/nodejs/node/pull/60831) - \[[`47ed95965e`](https://github.com/nodejs/node/commit/47ed95965e)] - **test**: ensure assertions are reached on more tests (Antoine du Hamel) [#​60761](https://github.com/nodejs/node/pull/60761) - \[[`79d48f9441`](https://github.com/nodejs/node/commit/79d48f9441)] - **test**: ensure assertions are reached on more tests (Antoine du Hamel) [#​60759](https://github.com/nodejs/node/pull/60759) - \[[`585e200b40`](https://github.com/nodejs/node/commit/585e200b40)] - **test**: prefer major GC in cppgc-object teardown (sangwook) [#​60672](https://github.com/nodejs/node/pull/60672) - \[[`9426ff6b08`](https://github.com/nodejs/node/commit/9426ff6b08)] - **test**: add basic temporal presence check (Chengzhong Wu) [#​60703](https://github.com/nodejs/node/pull/60703) - \[[`ffebf8e55c`](https://github.com/nodejs/node/commit/ffebf8e55c)] - **test**: ensure assertions are reached on more tests (Antoine du Hamel) [#​60726](https://github.com/nodejs/node/pull/60726) - \[[`adc6776c6a`](https://github.com/nodejs/node/commit/adc6776c6a)] - **test**: ensure assertions are reached on HTTP2 tests (Antoine du Hamel) [#​60730](https://github.com/nodejs/node/pull/60730) - \[[`3dae49c6ce`](https://github.com/nodejs/node/commit/3dae49c6ce)] - **test**: ensure assertions are reached on HTTP tests (Antoine du Hamel) [#​60729](https://github.com/nodejs/node/pull/60729) - \[[`5203b09fea`](https://github.com/nodejs/node/commit/5203b09fea)] - **test**: skip test that cause timeout on IBM i (SRAVANI GUNDEPALLI) [#​60700](https://github.com/nodejs/node/pull/60700) - \[[`6d2fe36747`](https://github.com/nodejs/node/commit/6d2fe36747)] - **test**: add missing r.close() calls in REPL multiline tests (sangwook) [#​60226](https://github.com/nodejs/node/pull/60226) - \[[`bbee2ef5e0`](https://github.com/nodejs/node/commit/bbee2ef5e0)] - **test**: ensure assertions are reached on more tests (Antoine du Hamel) [#​60634](https://github.com/nodejs/node/pull/60634) - \[[`a2764d450d`](https://github.com/nodejs/node/commit/a2764d450d)] - **test**: update WPT for WebCryptoAPI to [`c58b6f4`](https://github.com/nodejs/node/commit/c58b6f4e0e) (Node.js GitHub Bot) [#​60702](https://github.com/nodejs/node/pull/60702) - \[[`1176fe43a7`](https://github.com/nodejs/node/commit/1176fe43a7)] - **test**: fix test-buffer-zero-fill-cli to be effective (Сковорода Никита Андреевич) [#​60623](https://github.com/nodejs/node/pull/60623) - \[[`1a66dc1292`](https://github.com/nodejs/node/commit/1a66dc1292)] - **test**: limit the concurrency of WPTRunner for RISC-V (Levi Zim) [#​60591](https://github.com/nodejs/node/pull/60591) - \[[`36076846d4`](https://github.com/nodejs/node/commit/36076846d4)] - **test**: fix test-strace-openat-openssl for RISC-V (Levi Zim) [#​60588](https://github.com/nodejs/node/pull/60588) - \[[`5a976cb507`](https://github.com/nodejs/node/commit/5a976cb507)] - **test**: split test-runner-run-watch.mjs (Joyee Cheung) [#​60653](https://github.com/nodejs/node/pull/60653) - \[[`8f611b9bce`](https://github.com/nodejs/node/commit/8f611b9bce)] - **test**: ensure assertions are reached on more tests (Antoine du Hamel) [#​60641](https://github.com/nodejs/node/pull/60641) - \[[`3e550d30d6`](https://github.com/nodejs/node/commit/3e550d30d6)] - **test\_runner**: fix lazy `test.assert` accessor (René) [#​61097](https://github.com/nodejs/node/pull/61097) - \[[`ec142be1ed`](https://github.com/nodejs/node/commit/ec142be1ed)] - **test\_runner**: propagate V8 options to child process (Pietro Marchini) [#​60999](https://github.com/nodejs/node/pull/60999) - \[[`3127a2b1e7`](https://github.com/nodejs/node/commit/3127a2b1e7)] - **test\_runner**: fix line feed escaping in JUnit (Aliaksandr) [#​60274](https://github.com/nodejs/node/pull/60274) - \[[`08fb6c9ba4`](https://github.com/nodejs/node/commit/08fb6c9ba4)] - **test\_runner**: simplify code and make it more consistent (Antoine du Hamel) [#​60777](https://github.com/nodejs/node/pull/60777) - \[[`102b217cf3`](https://github.com/nodejs/node/commit/102b217cf3)] - **tools**: bump the eslint group in /tools/eslint with 2 updates (dependabot\[bot]) [#​61246](https://github.com/nodejs/node/pull/61246) - \[[`97b6b61165`](https://github.com/nodejs/node/commit/97b6b61165)] - **tools**: unpin ngtcp2 version updates (Michaël Zasso) [#​61155](https://github.com/nodejs/node/pull/61155) - \[[`7e95edc3de`](https://github.com/nodejs/node/commit/7e95edc3de)] - **tools**: only report commit validation failure on Slack (Antoine du Hamel) [#​61124](https://github.com/nodejs/node/pull/61124) - \[[`3a7ed257a3`](https://github.com/nodejs/node/commit/3a7ed257a3)] - **tools**: use sparse-checkout in linter jobs (Antoine du Hamel) [#​61123](https://github.com/nodejs/node/pull/61123) - \[[`b655edf1bf`](https://github.com/nodejs/node/commit/b655edf1bf)] - **tools**: simplify `notify-on-push` (Antoine du Hamel) [#​61050](https://github.com/nodejs/node/pull/61050) - \[[`230155749d`](https://github.com/nodejs/node/commit/230155749d)] - **tools**: fix update-nghttp2 signature verification (Richard Lau) [#​61035](https://github.com/nodejs/node/pull/61035) - \[[`e8646a7d10`](https://github.com/nodejs/node/commit/e8646a7d10)] - **tools**: improve log output of `create-release-proposal` (Antoine du Hamel) [#​61028](https://github.com/nodejs/node/pull/61028) - \[[`a4b2614912`](https://github.com/nodejs/node/commit/a4b2614912)] - **tools**: fix `vcbuild test` when path contain spaces (stduhpf) [#​56481](https://github.com/nodejs/node/pull/56481) - \[[`9769c359f8`](https://github.com/nodejs/node/commit/9769c359f8)] - **tools**: do not run `test-linux` workflow for changes on `vcbuild.bat` (Antoine du Hamel) [#​60979](https://github.com/nodejs/node/pull/60979) - \[[`2ceaf6eb3c`](https://github.com/nodejs/node/commit/2ceaf6eb3c)] - **tools**: add some options and comments to `shell.nix` (Antoine du Hamel) [#​60911](https://github.com/nodejs/node/pull/60911) - \[[`611135abdc`](https://github.com/nodejs/node/commit/611135abdc)] - **tools**: bump mdast-util-to-hast from 13.2.0 to 13.2.1 in /tools/doc (dependabot\[bot]) [#​60930](https://github.com/nodejs/node/pull/60930) - \[[`b4bad20a6c`](https://github.com/nodejs/node/commit/b4bad20a6c)] - **tools**: ignore more paths in GHA CI (Antoine du Hamel) [#​60920](https://github.com/nodejs/node/pull/60920) - \[[`47b7cb4e9e`](https://github.com/nodejs/node/commit/47b7cb4e9e)] - **tools**: run tests `--without-amaro` on test-shared macOS (Antoine du Hamel) [#​60902](https://github.com/nodejs/node/pull/60902) - \[[`b0ec8c9c2a`](https://github.com/nodejs/node/commit/b0ec8c9c2a)] - **tools**: replace deprecated eslint-plugin-markdown (Michaël Zasso) [#​60908](https://github.com/nodejs/node/pull/60908) - \[[`46dacf686e`](https://github.com/nodejs/node/commit/46dacf686e)] - **tools**: remove deprecated ESLint plugins (Michaël Zasso) [#​60908](https://github.com/nodejs/node/pull/60908) - \[[`1a4ec6e830`](https://github.com/nodejs/node/commit/1a4ec6e830)] - **tools**: update ESLint dependencies (Michaël Zasso) [#​60908](https://github.com/nodejs/node/pull/60908) - \[[`4e442b286d`](https://github.com/nodejs/node/commit/4e442b286d)] - **tools**: refloat 10 Node.js patches to cpplint.py (Michaël Zasso) [#​60901](https://github.com/nodejs/node/pull/60901) - \[[`fa90d09de6`](https://github.com/nodejs/node/commit/fa90d09de6)] - **tools**: update cpplint to 2.0.2 (Michaël Zasso) [#​60901](https://github.com/nodejs/node/pull/60901) - \[[`4d944c5198`](https://github.com/nodejs/node/commit/4d944c5198)] - **tools**: disable some new cpplint rules before update (Michaël Zasso) [#​60901](https://github.com/nodejs/node/pull/60901) - \[[`eaebae1eed`](https://github.com/nodejs/node/commit/eaebae1eed)] - **tools**: don't fetch V8 deps in the source tree (Richard Lau) [#​60883](https://github.com/nodejs/node/pull/60883) - \[[`256770944a`](https://github.com/nodejs/node/commit/256770944a)] - **tools**: add temporal updater (Chengzhong Wu) [#​60828](https://github.com/nodejs/node/pull/60828) - \[[`1c38f808bd`](https://github.com/nodejs/node/commit/1c38f808bd)] - **tools**: dump config.gypi as json (Chengzhong Wu) [#​60794](https://github.com/nodejs/node/pull/60794) - \[[`ed89b35291`](https://github.com/nodejs/node/commit/ed89b35291)] - **tools**: bump js-yaml from 4.1.0 to 4.1.1 in /tools/lint-md (dependabot\[bot]) [#​60781](https://github.com/nodejs/node/pull/60781) - \[[`c98c0881c5`](https://github.com/nodejs/node/commit/c98c0881c5)] - **tools**: fix linter warning in `test-shared.yml` (Antoine du Hamel) [#​60772](https://github.com/nodejs/node/pull/60772) - \[[`aa44406ed7`](https://github.com/nodejs/node/commit/aa44406ed7)] - **tools**: bump js-yaml from 4.1.0 to 4.1.1 in /tools/doc in the doc group (dependabot\[bot]) [#​60766](https://github.com/nodejs/node/pull/60766) - \[[`b756154ed9`](https://github.com/nodejs/node/commit/b756154ed9)] - **tools**: fix `paths-ignore` in gha files (Antoine du Hamel) [#​60753](https://github.com/nodejs/node/pull/60753) - \[[`18ed53fb7a`](https://github.com/nodejs/node/commit/18ed53fb7a)] - **tools**: update install\_tools.bat old echo from 2019 to 2022 (David Hidalgo) [#​60736](https://github.com/nodejs/node/pull/60736) - \[[`cf79940d5c`](https://github.com/nodejs/node/commit/cf79940d5c)] - **tools**: remove unsupported `cooldown` from Dependabot config (Antoine du Hamel) [#​60747](https://github.com/nodejs/node/pull/60747) - \[[`8ea73ffd64`](https://github.com/nodejs/node/commit/8ea73ffd64)] - **tools**: update sccache to v0.12.0 (Michaël Zasso) [#​60723](https://github.com/nodejs/node/pull/60723) - \[[`578f8bdfa0`](https://github.com/nodejs/node/commit/578f8bdfa0)] - **tools**: update x64 macOS runner (Antoine du Hamel) [#​60676](https://github.com/nodejs/node/pull/60676) - \[[`3b6cf316c0`](https://github.com/nodejs/node/commit/3b6cf316c0)] - **tools**: update gyp-next to 0.21.0 (Node.js GitHub Bot) [#​60645](https://github.com/nodejs/node/pull/60645) - \[[`7d55b8c00f`](https://github.com/nodejs/node/commit/7d55b8c00f)] - **tools,doc**: fix format-md files list (Stefan Stojanovic) [#​61147](https://github.com/nodejs/node/pull/61147) - \[[`a617942a4a`](https://github.com/nodejs/node/commit/a617942a4a)] - **url**: add fast path to getPathFromURL decoder (Gürgün Dayıoğlu) [#​60749](https://github.com/nodejs/node/pull/60749) - \[[`a6ac8bd2a5`](https://github.com/nodejs/node/commit/a6ac8bd2a5)] - **url**: remove array.reduce usage (Gürgün Dayıoğlu) [#​60748](https://github.com/nodejs/node/pull/60748) - \[[`09b5396523`](https://github.com/nodejs/node/commit/09b5396523)] - **util**: optimize toASCIILower function using V8s native toLowerCase (Mert Can Altin) [#​61107](https://github.com/nodejs/node/pull/61107) - \[[`1dd15c9502`](https://github.com/nodejs/node/commit/1dd15c9502)] - **util**: limit `inspect` to only show own properties (Ruben Bridgewater) [#​61032](https://github.com/nodejs/node/pull/61032) - \[[`5051d90100`](https://github.com/nodejs/node/commit/5051d90100)] - **(SEMVER-MINOR)** **util**: add convertProcessSignalToExitCode utility (Erick Wendel) [#​60963](https://github.com/nodejs/node/pull/60963) - \[[`98b6dc1181`](https://github.com/nodejs/node/commit/98b6dc1181)] - **util**: fix parseArgs skipping positional arg with --eval and --print (azadgupta1) [#​60814](https://github.com/nodejs/node/pull/60814) - \[[`862eaf8a09`](https://github.com/nodejs/node/commit/862eaf8a09)] - **util**: assert getCallSites does not invoke Error.prepareStackTrace (Chengzhong Wu) [#​60922](https://github.com/nodejs/node/pull/60922) - \[[`c2e79aa5fb`](https://github.com/nodejs/node/commit/c2e79aa5fb)] - **util**: improve textencoder encodeInto performance (Yagiz Nizipli) [#​60843](https://github.com/nodejs/node/pull/60843) - \[[`b6903aaf8d`](https://github.com/nodejs/node/commit/b6903aaf8d)] - **util**: safely inspect getter errors whose message throws (Yves M.) [#​60684](https://github.com/nodejs/node/pull/60684) - \[[`408f024906`](https://github.com/nodejs/node/commit/408f024906)] - **v8**: mark v8.queryObjects() as stable (Joyee Cheung) [#​60957](https://github.com/nodejs/node/pull/60957) - \[[`b00ee5222c`](https://github.com/nodejs/node/commit/b00ee5222c)] - **worker**: update code examples for `node:worker_threads` module (fisker Cheung) [#​58264](https://github.com/nodejs/node/pull/58264) - \[[`2409839f19`](https://github.com/nodejs/node/commit/2409839f19)] - **worker**: remove not implemented declarations (Artur Gawlik) [#​60655](https://github.com/nodejs/node/pull/60655) - \[[`c09417a2b1`](https://github.com/nodejs/node/commit/c09417a2b1)] - **zlib**: add CHECK to validate fast path input (Matteo Collina) [#​61175](https://github.com/nodejs/node/pull/61175) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi44NC4yIiwidXBkYXRlZEluVmVyIjoiNDIuODQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6Om1pbm9yIl19-->
Upstream added indexed interceptors for process.env. Migrate the new EnvSetterIndexed and EnvDefinerIndexed callbacks to PropertyCallbackInfo<Boolean> like their named counterparts, since Chromium's V8 only accepts the Boolean-returning indexed setter and definer callbacks. Ref: nodejs/node#60826 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU
* chore: bump node in DEPS to v26.12.1 * chore: bump node in DEPS to v26.13.0 * fix(patch): build: add simdutf dir to include path in GN build Keep upstream's simdutf include dir in the node_js2c include_dirs and add "tools" next to it. The patch's FixedArray::Get(context, i) change in node_builtins.cc is no longer needed: upstream made the same change in nodejs/node#61898. Ref: nodejs/node#65382 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix(patch): vfs: integrate with CJS and ESM module loaders Upstream moved the native legacyMainResolve call from esm/resolve.js into the loaderMethods table in internal/modules/helpers.js, so pass the asar-aware fileExists callback from there instead. Ref: nodejs/node#63653 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix(patch): src: let embedders supply a builtin code cache without a snapshot BuiltinLoader::RefreshCodeCache() now merges with insert_or_assign upstream, so drop that hunk from the patch. Ref: nodejs/node#65352 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix(patch): src: move import.meta initializer to native land PathHelpersLazyGetter moved from node_modules.cc to module_wrap.cc and gained a sibling ImportMetaResolveLazyGetter; switch both to Holder(). Also follow the DatabaseSyncLimits -> DatabaseLimits rename in node_sqlite.cc (nodejs/node#65988) and the Null(isolate) cleanup in node_constants.cc (nodejs/node#59805). Ref: nodejs/node#60603 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix(patch): src: fix usage of deprecated V8 API Upstream switched to Get/SetContinuationPreservedEmbedderDataV2(), which Chromium's V8 marks deprecated in favor of the unsuffixed names. Use the unsuffixed getter and setter. Ref: nodejs/node#60174 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix(patch): src: rename legacy trace event headers The TRACING_CATEGORY_NODE* macros moved from node_internals.h to tracing/trace_event.h, so define NODE_TRACE_CATEGORY_ENABLED there. Agent::CreateDefault() picks the legacy agent again when V8_USE_PERFETTO is unset (nodejs/node#64053), so only the Perfetto branch is gated on NODE_USE_PERFETTO_SDK. node.gyp now lists the Perfetto sources in node_tracing_perfetto_sources. Add them, with V8's tracing target and config, to the GN libnode target. The removed perfetto backport patch used to carry that wiring. Ref: nodejs/node#64565 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix(patch): src: let embedders exempt linked bindings from the addon permission Upstream added EnvironmentFlags::kNoAddonPermissionForLinkedBindings around the same check. Keep the electron_* exemption alongside it and note in the patch description that the patch can be dropped once Electron sets the new flag. Ref: nodejs/node#66067 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * chore: remove upstreamed patches * support_v8_sandboxed_pointers.patch Ref: nodejs/node#62237 * refactor_attach_cppgc_heap_on_v8_isolate_creation.patch Ref: nodejs/node#58070 * test_accomodate_v8_thenable_stack_trace_change_in_snapshot.patch Ref: nodejs/node#59805 * api_remove_deprecated_getisolate.patch Ref: nodejs/node#59805 Ref: nodejs/node#60223 * api_delete_deprecated_fields_on_v8_isolate.patch Ref: nodejs/node#60488 * api_promote_deprecation_of_v8_context_and_v8_object_api_methods.patch Ref: nodejs/node#60602 * src_refactor_module_wrap_cc_to_update_fixedarray_get_params.patch Ref: nodejs/node#61898 * src_refactor_wasmstreaming_finish_to_accept_a_callback.patch Ref: nodejs/node#61898 * src_stop_using_v8_propertycallbackinfo_t_this.patch Ref: nodejs/node#61898 * fix_add_externalpointertypetag_to_v8_external_api_calls.patch Ref: nodejs/node#61898 * src_stop_using_removed_v8_promise_reject_events.patch Ref: nodejs/node#62336 * src_backport_the_perfetto_trace_agent.patch Ref: nodejs/node#64565 Ref: nodejs/node#64721 * test_account_for_libc_rm_error_on_electron_linux.patch Ref: nodejs/node#66065 * fix_do_not_pass_removed_jspi_v8_flag.patch Ref: nodejs/node#60014 * test_drop_removed_wasm_rab_integration_flag.patch The v26 version of nodejs/node#65845 never added the flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * chore: update patches (trivial only) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * chore: bump @types/node to v26 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * chore: update filenames.auto.gni Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * chore: remove deleted specs Upstream deleted parallel/test-promise-swallowed-event and parallel/test-warn-multipleResolves when the multipleResolves event reached end-of-life. Ref: nodejs/node#58707 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: clear crash dumps with fs.rmSync instead of recursive rmdir Node.js v25 moved the fs.rmdir recursive option to end-of-life, so fs.rmdirSync(dir, { recursive: true }) now throws and @types/node v26 no longer accepts the option. Ref: nodejs/node#58616 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: listen on IncomingMessage unions through EventEmitter With @types/node v26, http.IncomingMessage declares typed `on` overloads that do not unify with Electron.IncomingMessage's, so collectStreamBodyBuffer() no longer type-checks when calling `on` on the union. Ref: Unable to locate reference Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix: pass an ArrayBuffer-backed view to subtle.digest in asar wrapper @types/node v26 types webcrypto's BufferSource as views over an ArrayBuffer only, so a Uint8Array<ArrayBufferLike> no longer type-checks. Archive reads never use a SharedArrayBuffer, so narrow the type at the call site. Ref: Unable to locate reference Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * node#64565: src: rename legacy trace event headers Node.js renamed src/tracing/trace_event_common.h to trace_event_legacy.h and moved the legacy trace macros out of trace_event.h into trace_event_legacy_inl.h, so feed both to electron_generate_node_defines instead of the removed header. The generated push/undef set matches the previous one apart from header guards, NODE_TRACE_CATEGORY_ENABLED and INTERNAL_DECLARE_SET_TRACE_VALUE_INT, which Node.js no longer defines. Ref: nodejs/node#64565 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix(patch): src: add perfetto trace agent Upstream's trace_event_perfetto.h includes the amalgamated "perfetto.h" SDK header, which Chromium's Perfetto does not provide, so libnode fails to compile. Include the Perfetto public headers Chromium ships instead (as the removed backport patch did), add the tracing/trace_config includes agent_perfetto.h relied on, and skip Node's TrackEvent category definitions when Chromium's built-in categories are already in scope. Ref: nodejs/node#64565 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix(patch): src: handle indexed properties in `process.env` Upstream added indexed interceptors for process.env. Migrate the new EnvSetterIndexed and EnvDefinerIndexed callbacks to PropertyCallbackInfo<Boolean> like their named counterparts, since Chromium's V8 only accepts the Boolean-returning indexed setter and definer callbacks. Ref: nodejs/node#60826 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: read the whole heap snapshot stream Since Node.js 26, readable.read() returns one buffered chunk at a time instead of concatenating everything buffered, so takeHeapSnapshot() parsed only the first 64 KiB of the snapshot. Read readableLength bytes, as upstream test/common/heap.js now does. Ref: nodejs/node#60441 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: use --trace-warnings in the node-options-parsing crash case Node.js 26 throws ERR_MISSING_OPTION('--permission') when a boolean permission flag such as --allow-addons is set without --permission (previously only the fs flags were checked), so the utility process in this fixture exited before reaching options.js. Repeat --trace-warnings instead; the case still checks that disallowed NODE_OPTIONS are stripped from a list with repeated options. Ref: nodejs/node#62072 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix(patch): restore user timing trace events The usertiming.js hunk that emits node.perf.usertiming trace events for performance.mark() and performance.measure() lived in the perfetto backport patch, which was removed as upstreamed. Upstream Node.js never had it (Electron added it in #50591), so carry it in fix_use_embedder_perfetto_client_when_available.patch. Ref: #50591 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: trigger the V8 sandbox fatal error from V8 directly Since Node.js 26, node::Buffer::New() copies memory allocated outside the V8 sandbox into it instead of handing it to v8::ArrayBuffer::NewBackingStore(), so the external-ab addon no longer crashed the utility process and "emits 'error' when fatal error is triggered from V8" timed out. Call NewBackingStore() from the addon so the same v8_ArrayBuffer_NewBackingStore fatal error is still raised. Ref: nodejs/node#62237 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: delete directories with rm instead of recursive rmdir Node.js 26 removed the recursive option of fs.rmdir(), fs.rmdirSync() and fsPromises.rmdir() (DEP0147), so they now throw ERR_INVALID_ARG_VALUE. Use rmSync() and promises.rm(), and put an archive in the directory so the tests delete what their titles say. Ref: nodejs/node#58616 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * node#64894: worker: add support for Web Workers Node.js 26 adds a Web Worker API and its pre-execution deletes globalThis.Worker unless --experimental-web-worker is set, without checking noBrowserGlobals, so renderers and web workers with Node integration lost Blink's Worker. Pass the flag in those processes, as is already done for --experimental-eventsource; Node's own Worker is not installed under kNoBrowserGlobals. Ref: nodejs/node#64894 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * node#61803: module: remove --experimental-transform-types Node.js 26 removed the flag, so passing it now fails with "bad option" (exit code 9). Stop forwarding it to Node.js, drop it from the command-line switch docs, document the removal as a 46.0 breaking change, and remove the spec and fixture that exercised it. The spec that checks TypeScript-only syntax is not transformed stays. Ref: nodejs/node#61803 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * node#65589: src: disable V8 external memory reasonable size check Node.js now passes --external-memory-max-reasonable-size=0 to V8 in every process that initializes it, which changes FlagList::Hash() and so the code-cache key. Add the flag to the build-time js2c code cache flavors that initialize Node.js and to electron_xcache's default flags, so their caches keep being accepted (xcache.spec.ts failed on the flag hash). Ref: nodejs/node#65589 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix: route Node.js 26's one-shot fs jobs through the asar wrapper Node.js 26 writes files (fs.writeFile, fs.appendFile and their fsPromises versions) with a native WriteFileJob, and copies directory trees for fs.cp() / fsPromises.cp() with a native CpDirJob, instead of going through binding.open() and the fs.promises walk the asar wrapper already handles. Writes into archives therefore failed with ENOTDIR instead of EACCES (and missed unpacked entries), and fs.cp() of an archive directory failed with ENOTDIR. Give binding.WriteFileJob the same archive checks as open(), wrap fs.writeFile() for archive paths since lib/fs.js captured the native job at startup, and copy archive trees for CpDirJob with the walk cpSync() already uses, which now also stamps directories with preserveTimestamps like the native walk. Ref: nodejs/node#65489 Ref: nodejs/node#65488 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix(patch): do not leak NodePlatform's default TracingController The NodePlatform hunk that owns the v8::TracingController it creates when the embedder passes none lived in the perfetto backport patch, which was removed as upstreamed, but upstream still allocates it with a bare new. With the perfetto agent, ELECTRON_RUN_AS_NODE passes no controller, so LeakSanitizer failed every run-as-node spec on ASan builds. Carry the hunk in fix_use_embedder_perfetto_client_when_available.patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix: keep fsPromises.stat() and lstat() native outside archives The asar wrapper replaced fsPromises.stat() and fsPromises.lstat() with promisified callback versions for every path, so they ran as callback requests (FSREQCALLBACK) instead of fsPromises' own. Node.js 26's fsPromises.cp() checks its paths with them before handing the copy to a native job, and parallel/test-fs-cp-async-destination-appears-late tells the two apart. Use the wrapper only for paths inside archives. Ref: nodejs/node#65488 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix: match Node.js 26 recursive readdir in the asar wrapper Node.js 26 accepts Buffer paths for recursive readdir, keeps parentPath a Buffer for them and for the 'buffer' encoding, and walks the tree breadth-first, following links to directories without stat()ing every entry. The asar wrapper's own walks (which also descend into archives) broke on Buffer paths and differed in order and parentPath, failing the new parallel/test-fs-readdir-recursive-* tests. Replace the three walks with one breadth-first walk shaped like Node's, which still lists and descends into archives as directories, and lets errors from any directory reach the caller. Ref: nodejs/node#65487 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * node#66138: src: add --process-timeout=N Node.js starts the --process-timeout watchdog in NodeMainInstance::Run(), which ELECTRON_RUN_AS_NODE does not use, so the option was accepted but never applied: parallel/test-process-timeout-* failed, and the fixtures that block the main thread hung the Node.js test job until it was cancelled. Start and stop the watchdog around the event loop in NodeMain() the same way. Ref: nodejs/node#66138 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: close the FileHandle in the stale asar descriptor spec Node.js 26 made closing a FileHandle on garbage collection an error (DEP0137 end-of-life). The 'handle' variant of "does not capture a descriptor number that was closed behind its back" dropped its FileHandle, so the renderer running the asar specs later died with an uncaught ERR_INVALID_STATE and every remaining asar spec failed with "Render frame was disposed". Close the handle like the other variants close their descriptors. Ref: nodejs/node#58536 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix: allow ArrayBuffers above 2 GiB in Node.js-enabled isolates Node.js 26 allocates Buffer.allocUnsafe(), Buffer.allocUnsafeSlow() and the copies made by AdoptIntoBackingStore() through the isolate's ArrayBuffer::Allocator (nodejs/node#61480, nodejs/node#62237). Electron's sandboxed-pointers patch for Node.js 24 sent those through ArrayBuffer::Allocator::NewDefaultAllocator() instead, which reaches Electron's in-sandbox allocator, and that serves requests beyond PartitionAlloc's single-allocation cap (2 GiB - 2 MiB) from sandbox pages. The isolates of the browser process, the utility-process node service and ELECTRON_RUN_AS_NODE use gin's ArrayBufferAllocator, which has no such fallback, so with Node.js 26 a Buffer.allocUnsafe() of more than 2 GiB - 2 MiB in those processes failed with ERR_MEMORY_ALLOCATION_FAILED, where Electron 45 and 46 allowed up to 32 GiB - 1 (parallel/test-fs-write-buffer-large). Give those isolates an allocator that delegates to gin's partition up to the cap and serves larger requests from sandbox pages, sharing the page bookkeeping with the in-sandbox allocator. Buffer.alloc() and new ArrayBuffer() above the cap now work there as well. The page map is only locked while a page allocation is live. Renderers are unaffected: Blink's isolate allocator already allows giga allocations. Ref: nodejs/node#61480 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix: include node_watchdog.h only where --process-timeout is wired node_watchdog.h chooses between its POSIX and Windows members with Node's __POSIX__ define, which Node's own targets set but Electron's do not, so including it from node_includes.h broke every electron_lib source on Linux ("unknown type name 'BOOL'"). Include it in node_main.cc alone, with __POSIX__ set around it on POSIX so the class matches Node's own build. Ref: nodejs/node#66138 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix: let Node.js 26's virtual file system answer recursive readdir Node.js 26 adds an experimental virtual file system that fs functions consult (vfsState.handlers) before the real one. The asar wrapper walks recursive readdir itself and never asked it, so with a VFS mounted fs.readdir(..., { recursive: true }) and its sync and promise forms listed the real path behind the mount (parallel/test-vfs-reserved-root, parallel/test-vfs-zip-provider-readdir-recursive failed with ENOTDIR). Ask the VFS first, as Node does. Ref: nodejs/node#63537 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix: do not log terminated Electron init scripts as errors CompileAndCall() logged an error whenever running one of Electron's bundled init scripts threw, including when execution was terminated because the environment was being torn down. A Worker that is stopped, or whose process exits, while it is still bootstrapping is not an error. On Node.js 26 the unref()'d Worker spawned by module-hooks/test-async-loader-hooks-with-worker-permission-allowed reaches that point while node_init runs, and the log line broke the test's empty-stderr check. Only log real exceptions. Ref: Unable to locate reference Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix(patch): expect the Wasm Global setter WPT to pass with Chromium V8 Chromium's V8 passes "Calling setter without argument" in the Wasm jsapi WPT global/value-get-set.any.js, which Node's own V8 still fails and lists as an expected failure, so the run failed on an unexpected pass. Ref: Unable to locate reference Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix: honor --no-node-snapshot under ELECTRON_RUN_AS_NODE ELECTRON_RUN_AS_NODE accepted --no-node-snapshot but always created its isolate from the embedded Node startup snapshot, and Node worker threads inherit that snapshot from their parent. Since Node.js 26 a worker deserializes the whole bootstrapped context from it, so parallel/test-worker-nearheaplimit-deadlock, which passes --no-node-snapshot so that its 0 MB-heap worker does not run out of memory during that deserialization, crashed with SIGSEGV. Skip the snapshot when Node's options turn it off, as node::Start() does; the process then boots from the V8 context snapshot like a build without a Node snapshot. The browser process and the node service parse Node's options only after creating their isolate, so they are unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * build: fetch Perfetto trace_processor_shell for the Node.js tests nodejs/node#66068 (test: enable trace_events tests with perfetto) moved the trace_events tests from test/parallel into a new test/trace_events suite. When Node.js is built with Perfetto (process.config.variables .v8_use_perfetto, which Electron's build sets), those tests write binary .pftrace files and convert them back to JSON with Perfetto's trace_processor_shell, through test/common/trace_events.js. Without the tool, all 17 trace_events/* tests in nn-test fail with "trace_processor_shell is missing". The same PR added tools/perfetto/get_trace_processor, which upstream's Makefile and CI use to fetch it. Run that script in the Node.js test job. It downloads the Perfetto release matching the vendored deps/perfetto/VERSION (v58.2) from Perfetto's GitHub releases to tools/perfetto/trace_processor_shell, which is the default path the test helper resolves, so TRACE_PROCESSOR_SHELL_PATH is not needed. Cache the binary keyed on that VERSION file. Upstream pins only the version, not a checksum. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: disable Node.js source phase import and process-timeout report tests Electron always passes --no-js-source-phase-imports. In renderers Blink owns that V8 flag and freezes it before Node.js starts, and the other process types match it, so the flag is consistent across processes and the embedded code cache, which is keyed on V8's flag hash, stays valid. nodejs/node#60364 made Node.js honour that opt-out instead of always enabling the flag. The es-module/test-esm-wasm-*source-phase* tests are already disabled for the same reason. Node.js 26 brings more tests that need source phase imports: - es-module/test-esm-wasm-jitless (nodejs/node#66533) calls import.source() and fails with "SyntaxError: Unexpected identifier 'source'". - The wasm/jsapi WPT suite, test/wpt/test-wasm-jsapi.mjs (nodejs/node#59034), is new to Electron with this upgrade. Its esm-integration/source-phase*.tentative cases use import.source() and fail with the same SyntaxError. Its module/moduleSource.tentative cases expect the %AbstractModuleSource% intrinsic, which V8 only installs when the flag is on. Each case runs as an .any.html and an .any.worker.html variant, so that is 8 entries. nodejs/node#66138 added --process-timeout and report/test-report-process-timeout. nodejs/node#66428 split out report/test-report-process-timeout-worker. Both validate the generated report with test/common/report.js, which expects header.componentVersions to equal process.versions. In Electron, process.versions also has chrome and electron, so the comparison fails. The other report tests that use this helper are already disabled for the same reason. The process timeout itself works, and both tests get as far as the report check. The WPT cases are listed as wpt/<test file>/<case id>, which is how tools/test.py names them and matches --skip-tests. Teach --validateDisabled to check the test file for these entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: resolve V8's NewBackingStore by Electron's export name on Windows The external-ab addon now calls v8::ArrayBuffer::NewBackingStore() itself, but on Windows it is built with MSVC's standard library while Electron is built with Chromium's libc++, and MSVC mangles return types into symbol names. electron.exe exports the function as returning std::__Cr::unique_ptr, so the addon's import of the std::unique_ptr variant never resolved, the utility process died without a V8 fatal error and "emits 'error' when fatal error is triggered from V8" timed out on windows-x64. Look the function up by Electron's exported name there instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: only reference std-free V8 exports from the external-ab addon On macOS and Linux the addon is built against a different libc++ ABI namespace than Electron's std::__Cr, so v8::ArrayBuffer::New(isolate, std::shared_ptr<BackingStore>) is an import that cannot bind. It only went unnoticed because NewBackingStore() raises the fatal error first. Stop after NewBackingStore(), whose mangled name has no standard library types, and throw if it ever returns, as on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * Revert "build: fetch Perfetto trace_processor_shell for the Node.js tests" This reverts commit 8920a7c. Node.js uses trace_processor_shell only to read back the trace file that a process started with --trace-event-categories writes. Electron never writes that file: Chromium owns tracing, and Electron does not start Node.js's file-based tracing agent. Every trace_events/* test fails before it reaches trace_processor_shell, because no trace file exists or, in test-trace-events-api, because getEnabledCategories() is undefined in the child. Those tests are disabled again in the next commit, so no Node.js test needs trace_processor_shell, and downloading it would only add a network fetch to the job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: disable the Node.js trace_events tests in their new directory nodejs/node#66068 (test: enable trace_events tests with perfetto) moved 17 test-trace-events-* tests out of test/parallel into a new test/trace_events suite. That took them out from under Electron's "parallel/test-trace-events" entry, which --skip-tests matches as a substring. Electron has never run these tests. They were disabled one by one when Electron started running the Node.js tests (1d06f67) and folded into the parallel/ prefix in #49467. They start Node.js with --trace-event-categories and read back the trace file it writes. Electron does not start Node.js's file-based tracing agent, because Chromium owns tracing, so no trace file is ever written. In nn-test, all 17 fail on a missing trace file, and test-trace-events-api also finds getEnabledCategories() undefined in its child. Add the matching "trace_events/test-trace-events" prefix. It covers all 17 files in test/trace_events. Keep the parallel/ entry, which still matches the 13 test-trace-events-* tests that stayed in test/parallel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix: copy directory trees out of archives without blocking fs.cp() nodejs/node#65488 (fs: copy directory trees for fs.cp() on the thread pool) made fs.cp() and fsPromises.cp() copy a new destination directory with a native CpDirJob. The job walks the tree on the thread pool and calls ondone once. Electron's override for archive sources ran the synchronous fs.cpSync() walk in a single process.nextTick, so an asynchronous cp of a directory out of an archive blocked the event loop until the whole tree had been copied. Give the job an asynchronous version of the walk. It goes through the fs.promises overrides, so packed files use the existing asynchronous copyFile path, and it keeps the same ordering, force/errorOnExist, symlink and preserveTimestamps handling and errors as the sync walk. The job still reports through ondone exactly once. fs.cpSync() keeps the synchronous walk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: trigger the utility process V8 fatal error from the testing binding The utilityProcess 'error' event from #43774 reports any V8 fatal error. Its spec raised one with the external-ab native addon, which handed V8 memory from outside the sandbox. Node.js 26 makes every Buffer site sandbox compatible, so that no longer happens through Node.js APIs. The earlier commits on this branch made the addon call V8 directly, and that needed ABI workarounds on Windows and for libc++. As Deepak suggested in review, drop the addon and its workspace entries. Add triggerV8FatalError() to the electron_common_testing binding, which is only built when DCHECKs are on. It fails a V8 API check by setting an internal field on a plain object, so it does not depend on the V8 sandbox. The spec keeps #43774's checks on the event type, location and report trigger, also checks the report's event message, and now runs wherever the testing binding exists, including Windows on Arm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * test: wait for the utility process exit only after its 'error' event events.once(emitter, 'exit') also listens for 'error' and rejects with its first argument. The previous commit started waiting for 'exit' before the 'error' event arrived, so the utility process's 'FatalError' rejected that promise and the spec failed with "Unknown Error: FatalError". Wait for 'exit' after 'error' has been received, as the spec from #43774 did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * refactor: use one d8-style PartitionAlloc allocator inside the V8 sandbox Following Deepak's review, replace the sandbox-page fallback added for nodejs/node#61480 and the older InSandboxAllocator with a single PAInSandboxAllocator, modelled on d8's. nodejs/node#61480 moved Buffer.allocUnsafe() onto the isolate's ArrayBuffer allocator. gin's partition caps a single allocation at partition_alloc::MaxAllocationSize() (2 GiB - 2 MiB), so Buffers above that size failed. The previous fix served those requests from whole sandbox pages and tracked them in a separate map. PAInSandboxAllocator owns a PartitionAlloc partition in the configurable pool, which gin::V8Initializer::Initialize() places inside the V8 sandbox. The partition is created lazily, after the pool exists. It has allow_giga_allocations set and allocates with kAllowGigaAllocations, along with kNoOverrideHooks and kNoMemoryToolOverride, as gin does. A single ArrayBuffer can therefore reach MaxGigaAllocationSize() (16 GiB - 2 MiB on 64-bit) without the page fallback. It is both the ArrayBuffer allocator for JavascriptEnvironment isolates and V8's in-sandbox allocator, so Node.js worker_threads isolates use it through NewDefaultAllocator(). Builds without the V8 sandbox keep gin's allocator. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU * fix: reject instead of throwing in asar fs.promises.stat/lstat wrappers The new fs.promises.stat/lstat wrappers call splitPath() before deciding whether to use fsPromises' own implementation. For a URL, splitPath() runs getValidatedPath(), which throws for a non-file: URL, so the error escaped synchronously instead of rejecting the returned promise as it did with util.promisify(fs.stat) on main and as Node's fsPromises does. Make the wrappers async so every input error rejects, and add a spec for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
* chore: bump node in DEPS to v26.12.1 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * chore: bump node in DEPS to v26.13.0 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> * fix(patch): build: add simdutf dir to include path in GN build Keep upstream's simdutf include dir in the node_js2c include_dirs and add "tools" next to it. The patch's FixedArray::Get(context, i) change in node_builtins.cc is no longer needed: upstream made the same change in nodejs/node#61898. Ref: nodejs/node#65382 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix(patch): vfs: integrate with CJS and ESM module loaders Upstream moved the native legacyMainResolve call from esm/resolve.js into the loaderMethods table in internal/modules/helpers.js, so pass the asar-aware fileExists callback from there instead. Ref: nodejs/node#63653 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix(patch): src: let embedders supply a builtin code cache without a snapshot BuiltinLoader::RefreshCodeCache() now merges with insert_or_assign upstream, so drop that hunk from the patch. Ref: nodejs/node#65352 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix(patch): src: move import.meta initializer to native land PathHelpersLazyGetter moved from node_modules.cc to module_wrap.cc and gained a sibling ImportMetaResolveLazyGetter; switch both to Holder(). Also follow the DatabaseSyncLimits -> DatabaseLimits rename in node_sqlite.cc (nodejs/node#65988) and the Null(isolate) cleanup in node_constants.cc (nodejs/node#59805). Ref: nodejs/node#60603 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix(patch): src: fix usage of deprecated V8 API Upstream switched to Get/SetContinuationPreservedEmbedderDataV2(), which Chromium's V8 marks deprecated in favor of the unsuffixed names. Use the unsuffixed getter and setter. Ref: nodejs/node#60174 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix(patch): src: rename legacy trace event headers The TRACING_CATEGORY_NODE* macros moved from node_internals.h to tracing/trace_event.h, so define NODE_TRACE_CATEGORY_ENABLED there. Agent::CreateDefault() picks the legacy agent again when V8_USE_PERFETTO is unset (nodejs/node#64053), so only the Perfetto branch is gated on NODE_USE_PERFETTO_SDK. node.gyp now lists the Perfetto sources in node_tracing_perfetto_sources. Add them, with V8's tracing target and config, to the GN libnode target. The removed perfetto backport patch used to carry that wiring. Ref: nodejs/node#64565 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix(patch): src: let embedders exempt linked bindings from the addon permission Upstream added EnvironmentFlags::kNoAddonPermissionForLinkedBindings around the same check. Keep the electron_* exemption alongside it and note in the patch description that the patch can be dropped once Electron sets the new flag. Ref: nodejs/node#66067 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * chore: remove upstreamed patches * support_v8_sandboxed_pointers.patch Ref: nodejs/node#62237 * refactor_attach_cppgc_heap_on_v8_isolate_creation.patch Ref: nodejs/node#58070 * test_accomodate_v8_thenable_stack_trace_change_in_snapshot.patch Ref: nodejs/node#59805 * api_remove_deprecated_getisolate.patch Ref: nodejs/node#59805 Ref: nodejs/node#60223 * api_delete_deprecated_fields_on_v8_isolate.patch Ref: nodejs/node#60488 * api_promote_deprecation_of_v8_context_and_v8_object_api_methods.patch Ref: nodejs/node#60602 * src_refactor_module_wrap_cc_to_update_fixedarray_get_params.patch Ref: nodejs/node#61898 * src_refactor_wasmstreaming_finish_to_accept_a_callback.patch Ref: nodejs/node#61898 * src_stop_using_v8_propertycallbackinfo_t_this.patch Ref: nodejs/node#61898 * fix_add_externalpointertypetag_to_v8_external_api_calls.patch Ref: nodejs/node#61898 * src_stop_using_removed_v8_promise_reject_events.patch Ref: nodejs/node#62336 * src_backport_the_perfetto_trace_agent.patch Ref: nodejs/node#64565 Ref: nodejs/node#64721 * test_account_for_libc_rm_error_on_electron_linux.patch Ref: nodejs/node#66065 * fix_do_not_pass_removed_jspi_v8_flag.patch Ref: nodejs/node#60014 * test_drop_removed_wasm_rab_integration_flag.patch The v26 version of nodejs/node#65845 never added the flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * chore: update patches (trivial only) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * chore: bump @types/node to v26 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * chore: update filenames.auto.gni Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * chore: remove deleted specs Upstream deleted parallel/test-promise-swallowed-event and parallel/test-warn-multipleResolves when the multipleResolves event reached end-of-life. Ref: nodejs/node#58707 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: clear crash dumps with fs.rmSync instead of recursive rmdir Node.js v25 moved the fs.rmdir recursive option to end-of-life, so fs.rmdirSync(dir, { recursive: true }) now throws and @types/node v26 no longer accepts the option. Ref: nodejs/node#58616 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: listen on IncomingMessage unions through EventEmitter With @types/node v26, http.IncomingMessage declares typed `on` overloads that do not unify with Electron.IncomingMessage's, so collectStreamBodyBuffer() no longer type-checks when calling `on` on the union. Ref: Unable to locate reference Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix: pass an ArrayBuffer-backed view to subtle.digest in asar wrapper @types/node v26 types webcrypto's BufferSource as views over an ArrayBuffer only, so a Uint8Array<ArrayBufferLike> no longer type-checks. Archive reads never use a SharedArrayBuffer, so narrow the type at the call site. Ref: Unable to locate reference Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * node#64565: src: rename legacy trace event headers Node.js renamed src/tracing/trace_event_common.h to trace_event_legacy.h and moved the legacy trace macros out of trace_event.h into trace_event_legacy_inl.h, so feed both to electron_generate_node_defines instead of the removed header. The generated push/undef set matches the previous one apart from header guards, NODE_TRACE_CATEGORY_ENABLED and INTERNAL_DECLARE_SET_TRACE_VALUE_INT, which Node.js no longer defines. Ref: nodejs/node#64565 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix(patch): src: add perfetto trace agent Upstream's trace_event_perfetto.h includes the amalgamated "perfetto.h" SDK header, which Chromium's Perfetto does not provide, so libnode fails to compile. Include the Perfetto public headers Chromium ships instead (as the removed backport patch did), add the tracing/trace_config includes agent_perfetto.h relied on, and skip Node's TrackEvent category definitions when Chromium's built-in categories are already in scope. Ref: nodejs/node#64565 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix(patch): src: handle indexed properties in `process.env` Upstream added indexed interceptors for process.env. Migrate the new EnvSetterIndexed and EnvDefinerIndexed callbacks to PropertyCallbackInfo<Boolean> like their named counterparts, since Chromium's V8 only accepts the Boolean-returning indexed setter and definer callbacks. Ref: nodejs/node#60826 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: read the whole heap snapshot stream Since Node.js 26, readable.read() returns one buffered chunk at a time instead of concatenating everything buffered, so takeHeapSnapshot() parsed only the first 64 KiB of the snapshot. Read readableLength bytes, as upstream test/common/heap.js now does. Ref: nodejs/node#60441 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: use --trace-warnings in the node-options-parsing crash case Node.js 26 throws ERR_MISSING_OPTION('--permission') when a boolean permission flag such as --allow-addons is set without --permission (previously only the fs flags were checked), so the utility process in this fixture exited before reaching options.js. Repeat --trace-warnings instead; the case still checks that disallowed NODE_OPTIONS are stripped from a list with repeated options. Ref: nodejs/node#62072 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix(patch): restore user timing trace events The usertiming.js hunk that emits node.perf.usertiming trace events for performance.mark() and performance.measure() lived in the perfetto backport patch, which was removed as upstreamed. Upstream Node.js never had it (Electron added it in #50591), so carry it in fix_use_embedder_perfetto_client_when_available.patch. Ref: #50591 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: trigger the V8 sandbox fatal error from V8 directly Since Node.js 26, node::Buffer::New() copies memory allocated outside the V8 sandbox into it instead of handing it to v8::ArrayBuffer::NewBackingStore(), so the external-ab addon no longer crashed the utility process and "emits 'error' when fatal error is triggered from V8" timed out. Call NewBackingStore() from the addon so the same v8_ArrayBuffer_NewBackingStore fatal error is still raised. Ref: nodejs/node#62237 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: delete directories with rm instead of recursive rmdir Node.js 26 removed the recursive option of fs.rmdir(), fs.rmdirSync() and fsPromises.rmdir() (DEP0147), so they now throw ERR_INVALID_ARG_VALUE. Use rmSync() and promises.rm(), and put an archive in the directory so the tests delete what their titles say. Ref: nodejs/node#58616 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * node#64894: worker: add support for Web Workers Node.js 26 adds a Web Worker API and its pre-execution deletes globalThis.Worker unless --experimental-web-worker is set, without checking noBrowserGlobals, so renderers and web workers with Node integration lost Blink's Worker. Pass the flag in those processes, as is already done for --experimental-eventsource; Node's own Worker is not installed under kNoBrowserGlobals. Ref: nodejs/node#64894 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * node#61803: module: remove --experimental-transform-types Node.js 26 removed the flag, so passing it now fails with "bad option" (exit code 9). Stop forwarding it to Node.js, drop it from the command-line switch docs, document the removal as a 46.0 breaking change, and remove the spec and fixture that exercised it. The spec that checks TypeScript-only syntax is not transformed stays. Ref: nodejs/node#61803 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * node#65589: src: disable V8 external memory reasonable size check Node.js now passes --external-memory-max-reasonable-size=0 to V8 in every process that initializes it, which changes FlagList::Hash() and so the code-cache key. Add the flag to the build-time js2c code cache flavors that initialize Node.js and to electron_xcache's default flags, so their caches keep being accepted (xcache.spec.ts failed on the flag hash). Ref: nodejs/node#65589 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix: route Node.js 26's one-shot fs jobs through the asar wrapper Node.js 26 writes files (fs.writeFile, fs.appendFile and their fsPromises versions) with a native WriteFileJob, and copies directory trees for fs.cp() / fsPromises.cp() with a native CpDirJob, instead of going through binding.open() and the fs.promises walk the asar wrapper already handles. Writes into archives therefore failed with ENOTDIR instead of EACCES (and missed unpacked entries), and fs.cp() of an archive directory failed with ENOTDIR. Give binding.WriteFileJob the same archive checks as open(), wrap fs.writeFile() for archive paths since lib/fs.js captured the native job at startup, and copy archive trees for CpDirJob with the walk cpSync() already uses, which now also stamps directories with preserveTimestamps like the native walk. Ref: nodejs/node#65489 Ref: nodejs/node#65488 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix(patch): do not leak NodePlatform's default TracingController The NodePlatform hunk that owns the v8::TracingController it creates when the embedder passes none lived in the perfetto backport patch, which was removed as upstreamed, but upstream still allocates it with a bare new. With the perfetto agent, ELECTRON_RUN_AS_NODE passes no controller, so LeakSanitizer failed every run-as-node spec on ASan builds. Carry the hunk in fix_use_embedder_perfetto_client_when_available.patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix: keep fsPromises.stat() and lstat() native outside archives The asar wrapper replaced fsPromises.stat() and fsPromises.lstat() with promisified callback versions for every path, so they ran as callback requests (FSREQCALLBACK) instead of fsPromises' own. Node.js 26's fsPromises.cp() checks its paths with them before handing the copy to a native job, and parallel/test-fs-cp-async-destination-appears-late tells the two apart. Use the wrapper only for paths inside archives. Ref: nodejs/node#65488 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix: match Node.js 26 recursive readdir in the asar wrapper Node.js 26 accepts Buffer paths for recursive readdir, keeps parentPath a Buffer for them and for the 'buffer' encoding, and walks the tree breadth-first, following links to directories without stat()ing every entry. The asar wrapper's own walks (which also descend into archives) broke on Buffer paths and differed in order and parentPath, failing the new parallel/test-fs-readdir-recursive-* tests. Replace the three walks with one breadth-first walk shaped like Node's, which still lists and descends into archives as directories, and lets errors from any directory reach the caller. Ref: nodejs/node#65487 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * node#66138: src: add --process-timeout=N Node.js starts the --process-timeout watchdog in NodeMainInstance::Run(), which ELECTRON_RUN_AS_NODE does not use, so the option was accepted but never applied: parallel/test-process-timeout-* failed, and the fixtures that block the main thread hung the Node.js test job until it was cancelled. Start and stop the watchdog around the event loop in NodeMain() the same way. Ref: nodejs/node#66138 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: close the FileHandle in the stale asar descriptor spec Node.js 26 made closing a FileHandle on garbage collection an error (DEP0137 end-of-life). The 'handle' variant of "does not capture a descriptor number that was closed behind its back" dropped its FileHandle, so the renderer running the asar specs later died with an uncaught ERR_INVALID_STATE and every remaining asar spec failed with "Render frame was disposed". Close the handle like the other variants close their descriptors. Ref: nodejs/node#58536 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix: allow ArrayBuffers above 2 GiB in Node.js-enabled isolates Node.js 26 allocates Buffer.allocUnsafe(), Buffer.allocUnsafeSlow() and the copies made by AdoptIntoBackingStore() through the isolate's ArrayBuffer::Allocator (nodejs/node#61480, nodejs/node#62237). Electron's sandboxed-pointers patch for Node.js 24 sent those through ArrayBuffer::Allocator::NewDefaultAllocator() instead, which reaches Electron's in-sandbox allocator, and that serves requests beyond PartitionAlloc's single-allocation cap (2 GiB - 2 MiB) from sandbox pages. The isolates of the browser process, the utility-process node service and ELECTRON_RUN_AS_NODE use gin's ArrayBufferAllocator, which has no such fallback, so with Node.js 26 a Buffer.allocUnsafe() of more than 2 GiB - 2 MiB in those processes failed with ERR_MEMORY_ALLOCATION_FAILED, where Electron 45 and 46 allowed up to 32 GiB - 1 (parallel/test-fs-write-buffer-large). Give those isolates an allocator that delegates to gin's partition up to the cap and serves larger requests from sandbox pages, sharing the page bookkeeping with the in-sandbox allocator. Buffer.alloc() and new ArrayBuffer() above the cap now work there as well. The page map is only locked while a page allocation is live. Renderers are unaffected: Blink's isolate allocator already allows giga allocations. Ref: nodejs/node#61480 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix: include node_watchdog.h only where --process-timeout is wired node_watchdog.h chooses between its POSIX and Windows members with Node's __POSIX__ define, which Node's own targets set but Electron's do not, so including it from node_includes.h broke every electron_lib source on Linux ("unknown type name 'BOOL'"). Include it in node_main.cc alone, with __POSIX__ set around it on POSIX so the class matches Node's own build. Ref: nodejs/node#66138 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix: let Node.js 26's virtual file system answer recursive readdir Node.js 26 adds an experimental virtual file system that fs functions consult (vfsState.handlers) before the real one. The asar wrapper walks recursive readdir itself and never asked it, so with a VFS mounted fs.readdir(..., { recursive: true }) and its sync and promise forms listed the real path behind the mount (parallel/test-vfs-reserved-root, parallel/test-vfs-zip-provider-readdir-recursive failed with ENOTDIR). Ask the VFS first, as Node does. Ref: nodejs/node#63537 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix: do not log terminated Electron init scripts as errors CompileAndCall() logged an error whenever running one of Electron's bundled init scripts threw, including when execution was terminated because the environment was being torn down. A Worker that is stopped, or whose process exits, while it is still bootstrapping is not an error. On Node.js 26 the unref()'d Worker spawned by module-hooks/test-async-loader-hooks-with-worker-permission-allowed reaches that point while node_init runs, and the log line broke the test's empty-stderr check. Only log real exceptions. Ref: Unable to locate reference Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix(patch): expect the Wasm Global setter WPT to pass with Chromium V8 Chromium's V8 passes "Calling setter without argument" in the Wasm jsapi WPT global/value-get-set.any.js, which Node's own V8 still fails and lists as an expected failure, so the run failed on an unexpected pass. Ref: Unable to locate reference Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix: honor --no-node-snapshot under ELECTRON_RUN_AS_NODE ELECTRON_RUN_AS_NODE accepted --no-node-snapshot but always created its isolate from the embedded Node startup snapshot, and Node worker threads inherit that snapshot from their parent. Since Node.js 26 a worker deserializes the whole bootstrapped context from it, so parallel/test-worker-nearheaplimit-deadlock, which passes --no-node-snapshot so that its 0 MB-heap worker does not run out of memory during that deserialization, crashed with SIGSEGV. Skip the snapshot when Node's options turn it off, as node::Start() does; the process then boots from the V8 context snapshot like a build without a Node snapshot. The browser process and the node service parse Node's options only after creating their isolate, so they are unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * build: fetch Perfetto trace_processor_shell for the Node.js tests nodejs/node#66068 (test: enable trace_events tests with perfetto) moved the trace_events tests from test/parallel into a new test/trace_events suite. When Node.js is built with Perfetto (process.config.variables .v8_use_perfetto, which Electron's build sets), those tests write binary .pftrace files and convert them back to JSON with Perfetto's trace_processor_shell, through test/common/trace_events.js. Without the tool, all 17 trace_events/* tests in nn-test fail with "trace_processor_shell is missing". The same PR added tools/perfetto/get_trace_processor, which upstream's Makefile and CI use to fetch it. Run that script in the Node.js test job. It downloads the Perfetto release matching the vendored deps/perfetto/VERSION (v58.2) from Perfetto's GitHub releases to tools/perfetto/trace_processor_shell, which is the default path the test helper resolves, so TRACE_PROCESSOR_SHELL_PATH is not needed. Cache the binary keyed on that VERSION file. Upstream pins only the version, not a checksum. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: disable Node.js source phase import and process-timeout report tests Electron always passes --no-js-source-phase-imports. In renderers Blink owns that V8 flag and freezes it before Node.js starts, and the other process types match it, so the flag is consistent across processes and the embedded code cache, which is keyed on V8's flag hash, stays valid. nodejs/node#60364 made Node.js honour that opt-out instead of always enabling the flag. The es-module/test-esm-wasm-*source-phase* tests are already disabled for the same reason. Node.js 26 brings more tests that need source phase imports: - es-module/test-esm-wasm-jitless (nodejs/node#66533) calls import.source() and fails with "SyntaxError: Unexpected identifier 'source'". - The wasm/jsapi WPT suite, test/wpt/test-wasm-jsapi.mjs (nodejs/node#59034), is new to Electron with this upgrade. Its esm-integration/source-phase*.tentative cases use import.source() and fail with the same SyntaxError. Its module/moduleSource.tentative cases expect the %AbstractModuleSource% intrinsic, which V8 only installs when the flag is on. Each case runs as an .any.html and an .any.worker.html variant, so that is 8 entries. nodejs/node#66138 added --process-timeout and report/test-report-process-timeout. nodejs/node#66428 split out report/test-report-process-timeout-worker. Both validate the generated report with test/common/report.js, which expects header.componentVersions to equal process.versions. In Electron, process.versions also has chrome and electron, so the comparison fails. The other report tests that use this helper are already disabled for the same reason. The process timeout itself works, and both tests get as far as the report check. The WPT cases are listed as wpt/<test file>/<case id>, which is how tools/test.py names them and matches --skip-tests. Teach --validateDisabled to check the test file for these entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: resolve V8's NewBackingStore by Electron's export name on Windows The external-ab addon now calls v8::ArrayBuffer::NewBackingStore() itself, but on Windows it is built with MSVC's standard library while Electron is built with Chromium's libc++, and MSVC mangles return types into symbol names. electron.exe exports the function as returning std::__Cr::unique_ptr, so the addon's import of the std::unique_ptr variant never resolved, the utility process died without a V8 fatal error and "emits 'error' when fatal error is triggered from V8" timed out on windows-x64. Look the function up by Electron's exported name there instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: only reference std-free V8 exports from the external-ab addon On macOS and Linux the addon is built against a different libc++ ABI namespace than Electron's std::__Cr, so v8::ArrayBuffer::New(isolate, std::shared_ptr<BackingStore>) is an import that cannot bind. It only went unnoticed because NewBackingStore() raises the fatal error first. Stop after NewBackingStore(), whose mangled name has no standard library types, and throw if it ever returns, as on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * Revert "build: fetch Perfetto trace_processor_shell for the Node.js tests" This reverts commit 8920a7c. Node.js uses trace_processor_shell only to read back the trace file that a process started with --trace-event-categories writes. Electron never writes that file: Chromium owns tracing, and Electron does not start Node.js's file-based tracing agent. Every trace_events/* test fails before it reaches trace_processor_shell, because no trace file exists or, in test-trace-events-api, because getEnabledCategories() is undefined in the child. Those tests are disabled again in the next commit, so no Node.js test needs trace_processor_shell, and downloading it would only add a network fetch to the job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: disable the Node.js trace_events tests in their new directory nodejs/node#66068 (test: enable trace_events tests with perfetto) moved 17 test-trace-events-* tests out of test/parallel into a new test/trace_events suite. That took them out from under Electron's "parallel/test-trace-events" entry, which --skip-tests matches as a substring. Electron has never run these tests. They were disabled one by one when Electron started running the Node.js tests (1d06f67) and folded into the parallel/ prefix in #49467. They start Node.js with --trace-event-categories and read back the trace file it writes. Electron does not start Node.js's file-based tracing agent, because Chromium owns tracing, so no trace file is ever written. In nn-test, all 17 fail on a missing trace file, and test-trace-events-api also finds getEnabledCategories() undefined in its child. Add the matching "trace_events/test-trace-events" prefix. It covers all 17 files in test/trace_events. Keep the parallel/ entry, which still matches the 13 test-trace-events-* tests that stayed in test/parallel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix: copy directory trees out of archives without blocking fs.cp() nodejs/node#65488 (fs: copy directory trees for fs.cp() on the thread pool) made fs.cp() and fsPromises.cp() copy a new destination directory with a native CpDirJob. The job walks the tree on the thread pool and calls ondone once. Electron's override for archive sources ran the synchronous fs.cpSync() walk in a single process.nextTick, so an asynchronous cp of a directory out of an archive blocked the event loop until the whole tree had been copied. Give the job an asynchronous version of the walk. It goes through the fs.promises overrides, so packed files use the existing asynchronous copyFile path, and it keeps the same ordering, force/errorOnExist, symlink and preserveTimestamps handling and errors as the sync walk. The job still reports through ondone exactly once. fs.cpSync() keeps the synchronous walk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: trigger the utility process V8 fatal error from the testing binding The utilityProcess 'error' event from #43774 reports any V8 fatal error. Its spec raised one with the external-ab native addon, which handed V8 memory from outside the sandbox. Node.js 26 makes every Buffer site sandbox compatible, so that no longer happens through Node.js APIs. The earlier commits on this branch made the addon call V8 directly, and that needed ABI workarounds on Windows and for libc++. As Deepak suggested in review, drop the addon and its workspace entries. Add triggerV8FatalError() to the electron_common_testing binding, which is only built when DCHECKs are on. It fails a V8 API check by setting an internal field on a plain object, so it does not depend on the V8 sandbox. The spec keeps #43774's checks on the event type, location and report trigger, also checks the report's event message, and now runs wherever the testing binding exists, including Windows on Arm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * test: wait for the utility process exit only after its 'error' event events.once(emitter, 'exit') also listens for 'error' and rejects with its first argument. The previous commit started waiting for 'exit' before the 'error' event arrived, so the utility process's 'FatalError' rejected that promise and the spec failed with "Unknown Error: FatalError". Wait for 'exit' after 'error' has been received, as the spec from #43774 did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * refactor: use one d8-style PartitionAlloc allocator inside the V8 sandbox Following Deepak's review, replace the sandbox-page fallback added for nodejs/node#61480 and the older InSandboxAllocator with a single PAInSandboxAllocator, modelled on d8's. nodejs/node#61480 moved Buffer.allocUnsafe() onto the isolate's ArrayBuffer allocator. gin's partition caps a single allocation at partition_alloc::MaxAllocationSize() (2 GiB - 2 MiB), so Buffers above that size failed. The previous fix served those requests from whole sandbox pages and tracked them in a separate map. PAInSandboxAllocator owns a PartitionAlloc partition in the configurable pool, which gin::V8Initializer::Initialize() places inside the V8 sandbox. The partition is created lazily, after the pool exists. It has allow_giga_allocations set and allocates with kAllowGigaAllocations, along with kNoOverrideHooks and kNoMemoryToolOverride, as gin does. A single ArrayBuffer can therefore reach MaxGigaAllocationSize() (16 GiB - 2 MiB on 64-bit) without the page fallback. It is both the ArrayBuffer allocator for JavascriptEnvironment isolates and V8's in-sandbox allocator, so Node.js worker_threads isolates use it through NewDefaultAllocator(). Builds without the V8 sandbox keep gin's allocator. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> * fix: reject instead of throwing in asar fs.promises.stat/lstat wrappers The new fs.promises.stat/lstat wrappers call splitPath() before deciding whether to use fsPromises' own implementation. For a URL, splitPath() runs getValidatedPath(), which throws for a non-file: URL, so the error escaped synchronously instead of rejecting the returned promise as it did with util.promisify(fs.stat) on main and as Node's fsPromises does. Make the wrappers async so every input error rejects, and add a spec for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vf2yMuJ7XxvNktpKuiMPzU Co-authored-by: Claude <noreply@anthropic.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Closes: #60795
I'm not sure if we should treat this as a breaking change.
Before this change, indexed properties would not be intercepted, so setting them in JS would not coerce the value to a string.