Repository navigation
Loader docs return value for source from transform? #35
Description
I think the most current docs for the loader hooks are here:
https://github.com/nodejs/node/blob/master/doc/api/esm.md#loadurl-context-defaultload
In the section above in the table for formats, it has a column called
Acceptable types For source returned by resolve or load
This leads me to believe that resolve somehow would be capable of returning source but I think it is not? Is this an error in the docs or have I misunderstood something?
Reacted by Jacob Smith
Activity
GeoffreyBooth commentedon Sep 25, 2021
It should probably say acceptable values for
format; @JakobJingleheimer ?jonaskello commentedon Sep 25, 2021
The format is specified in the first column so I think it the resolve part should just be removed?
Acceptable types For source returned by
resolve orloadJakobJingleheimer commentedon Sep 27, 2021
@GeoffreyBooth the 3rd column is indeed types for
source. That table is saying whenformatis foo,sourcecan be bar. I'm not sure how much value the table provides (it existed before though) as in most circumstances, the choice is made for you.Yes!
resolvedoes not return asourceproperty. Thank you for the catch @jonaskello. PR incoming.JakobJingleheimer commentedon Sep 27, 2021
nodejs/node#40234