[WIP] Implement virtualmachine's shutdown operation#124
Open
kyontan wants to merge 2 commits into
Open
Conversation
h-otter
reviewed
Feb 20, 2019
Member
|
実際シャットダウンしたか確認するべきだと思うけど、libvirtみたいにタイムアウトを待つ必要がありそうだしどうしようか… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / 変更点
ShutdownVirtualMachineを実装したfunc (q Qemu) HardShutdown() errorの実装がおそらくおかしかったため修正したWhy / 変更した理由
未実装だったため
How (Optional) / 概要
How affect / 影響範囲
特になし
シャットダウンが終了することは保証しないため、これに依存するDAGで起動等をすると失敗することは考えられる (新規実装部分であるため、既存影響はない)