Repository navigation
fix(client): close EventSource when SSEClientTransport.start() fails - #3197
Open
tang-ontheway wants to merge 1 commit into
Open
tang-ontheway wants to merge 1 commit into
tang-ontheway wants to merge 1 commit into
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
SSEClientTransport.start()(and thusClient.connect()) failed before receiving theendpointevent (e.g. connection refused, non-200 status, or failed 401 auth),_startOrAuth()rejected the promise without closingthis._eventSource. As a result,EventSourceremained open and kept reconnecting in the background, preventing processes from exiting and floodingonerror.Changes
this._eventSourcein_startOrAuth()'sonerrorhandlers when!this._endpoint(initial connection has not yet succeeded), matching the existing invalid-endpoint failure path while preserving automaticEventSourcereconnection for errors that occur afterstart()has resolved.packages/client/test/client/sse.test.tsverifying thatEventSourcestops reconnecting afterstart()rejects.Verification
pnpm --filter @modelcontextprotocol/client test test/client/sse.test.ts(41 passed)pnpm --filter @modelcontextprotocol/client exec tsc --noEmit(0 errors)pnpm --filter @modelcontextprotocol/client lint&build(passed)Fixes #3193