You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Server metadata advertises the RFC 8414 issuer with a trailing slash (URL normalization in createOAuthMetadata) #3186
createOAuthMetadata (packages/server-legacy/src/auth/router.ts) writes the metadata issuer as issuerUrl.href. Because new URL('https://host').href normalizes to https://host/, an authorization server built from a slash-less origin string advertises its issuer with a trailing slash.
RFC 8414 §2 forbids a trailing slash on the issuer identifier, and §3.3 requires the metadata issuer to be byte-identical to the URL the well-known document was fetched from.
Reproduction
importexpressfrom'express';import{mcpAuthRouter}from'@modelcontextprotocol/sdk/server/auth/router.js';// minimal provider stub…constapp=express();app.use(mcpAuthRouter({provider: mockProvider,issuerUrl: newURL('https://auth.example.com'),// no trailing slash — the usual case}));app.listen(3000);
The SDK's own client fails the same round trip: discoverAuthorizationServerMetadata validates the metadata issuer echo against the discovery URL and throws IssuerMismatchError when they differ. So on SDK 1.32.x an SDK server and an SDK client cannot complete OAuth discovery against each other for any root issuer — and other strict RFC 8414 clients (Python SDK's validate_metadata_issuer, OpenCodealt's client, …) reject it identically. We hit this in production: strict clients could not connect any OAuth-protected MCP behind our authorization server until we patched the served document.
Proposed fix
packages/server-legacy/src/auth/router.ts — derive the identifier slash-less before writing the field (an issuerIdentifierOf() that strips the single normalization slash); both new URL('https://host') and new URL('https://host/') then serve the same compliant metadata. The RFC 9207 iss parameter emitted by authorizationHandler has the same normalization and needs the same treatment to stay byte-identical with the metadata issuer (its e2e scenario hosting:auth:as-iss-emission currently pins the slashed form).
Upstream PR with the fix + regression tests: #3184
Additional context
The client side needs no change — main's IssuerMismatchError echo check is correct and already tolerates a slashed discovery URL against a slash-less metadata issuer; it's the server document that's wrong.
Happy to rebase/adjust if maintainers would rather enforce this in checkIssuerUrl (rejecting slashed input) than normalize on output — normalizing was chosen for backward compatibility with existing deployments.
Activity
media-ctrl commentedon Nov 15, 2026