[issue-511] Fix serialization of additional data on Collections - #512
Merged
Conversation
|
|
Member
|
Carlos Bouzón García (@bougar) thanks for the PR, I'll review it shortly. In the meantime, can you make sure you sign the CLA please? (see previous message) |
- fixes a bug where additional data would be added to the wrong level for lists
Vincent Biret (baywet)
previously approved these changes
Oct 1, 2020
Member
|
thanks Carlos Bouzón García (@bougar) for the pull request. I made a few modifications:
|
Vincent Biret (baywet)
requested review from
Michael Mainer (MIchaelMainer),
Nikitha Chettiar (nikithauc) and
Mustafa Zengin (zengin)
October 1, 2020 19:32
Member
|
BTW Carlos Bouzón García (@bougar) if you sign up here and send a few other pull requests within the month, they'll send you a cool t-shirt! |
Michael Mainer (MIchaelMainer)
approved these changes
Oct 2, 2020
Michael Mainer (MIchaelMainer)
left a comment
Contributor
There was a problem hiding this comment.
Reviewed via Teams. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to solve #511 issue.
I just modified the
getChildAdditionalDatamethod in order to support the serialization of additional properties on List items.