Skip to content

devops(conda): publish a single version per OS instead of each supported Python version #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 1 commit into from
Apr 3, 2024
Merged

devops(conda): publish a single version per OS instead of each supported Python version #2391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ jobs:
run: |
conda config --set anaconda_upload yes
if [ "${{ matrix.target-platform }}" == "osx-arm64" ]; then
conda build --user microsoft . -m conda_build_config.yaml -m conda_build_config_osx_arm64.yaml
conda build --user microsoft . -m conda_build_config_osx_arm64.yaml
elif [ "${{ matrix.target-platform }}" == "linux-aarch64" ]; then
conda install cross-python_linux-aarch64
conda build --user microsoft . -m conda_build_config.yaml -m conda_build_config_linux_aarch64.yaml
conda build --user microsoft . -m conda_build_config_linux_aarch64.yaml
else
conda build --user microsoft . -m conda_build_config.yaml
conda build --user microsoft .
fi
6 changes: 0 additions & 6 deletions conda_build_config.yaml
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,24 @@ source:
build:
number: 0
script: "{{ PYTHON }} -m pip install . --no-deps -vv"
skip: true # [py<37]
binary_relocation: False
missing_dso_whitelist: "*"
entry_points:
- playwright = playwright.__main__:main

requirements:
build:
- python # [build_platform != target_platform]
- python >=3.8 # [build_platform != target_platform]

@yury-s yury-s Apr 3, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test bot with such minimal version to ensure that we are still compatible with it? What I see below is just a python with the same version as was used for the build.

@mxschmitt mxschmitt Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have such bots in place for conda, will do some manual testing, but this replicates what we do for pytest-playwright, so fairly confident that it works.

- pip # [build_platform != target_platform]
- cross-python_{{ target_platform }} # [build_platform != target_platform]
host:
- python
- python >=3.8
- wheel
- pip
- curl
- setuptools_scm
run:
- python
- python >=3.8
- greenlet ==3.0.3
- pyee ==11.0.1

Expand Down