Skip to content

chore: enable pyright on sync tests #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 1 commit into from
Nov 9, 2021
Merged

chore: enable pyright on sync tests #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playwright/_impl/_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ async def text(self) -> str:
content = await self.body()
return content.decode()

async def json(self) -> Union[Any]:
async def json(self) -> Any:
return json.loads(await self.text())

@property
Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ ignore_errors = true
profile = "black"

[tool.pyright]
include = ["playwright"]
ignore = ["tests/", "scripts/"]
include = ["playwright", "tests/sync"]
ignore = ["tests/async/", "scripts/"]
pythonVersion = "3.7"
reportMissingImports = false
reportTypedDictNotRequiredAccess = false
reportTypedDictNotRequiredAccess = false
2 changes: 1 addition & 1 deletion tests/sync/test_pdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

import pytest

from playwright._impl._page import Page
from playwright.sync_api import Page


@pytest.mark.only_browser("chromium")
Expand Down