[live-migration] wire cancel to the HcsCancelLiveMigration API - #2843
Open
rawahars wants to merge 1 commit into
Open
[live-migration] wire cancel to the HcsCancelLiveMigration API#2843rawahars wants to merge 1 commit into
rawahars wants to merge 1 commit into
Conversation
CancelLiveMigration was a stub: it only checked the compute system was open and returned success, so a cancel never reached HCS and an in-flight migration kept running. Bind the computecore.dll HcsCancelLiveMigration export and issue it from System.CancelLiveMigration, waiting on the async operation for the result (a pending status is expected, as with the sibling LM APIs). The call still takes no handle lock so it can interrupt an in-flight transfer that holds it, and it now surfaces a real error on failure instead of always succeeding. Thread a MigrationCancelOptions through the cancel call chain (vmmanager, vm and migration controllers, service interface) so the request carries the originating side; the migration session stamps its own Origin (source or destination), matching the documented cancel sequence. Regenerate the computecore syscall bindings and the vmController mocks. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CancelLiveMigration was a stub: it only checked the compute system was open and returned success, so a cancel never reached HCS and an in-flight migration kept running.
Bind the computecore.dll HcsCancelLiveMigration export and issue it from System.CancelLiveMigration, waiting on the async operation for the result (a pending status is expected, as with the sibling LM APIs). The call still takes no handle lock so it can interrupt an in-flight transfer that holds it, and it now surfaces a real error on failure instead of always succeeding.
Thread a MigrationCancelOptions through the cancel call chain (vmmanager, vm and migration controllers, service interface) so the request carries the originating side; the migration session stamps its own Origin (source or destination), matching the documented cancel sequence.
Regenerate the computecore syscall bindings and the vmController mocks.