Repository navigation
test(scripts): rename check-changed-skills fixture skill so a hex SHA cannot match it - #8392
Conversation
… cannot match it The not-checked assertion greps checklog for the fixture skill name "bad", but checklog also records base=<sha>, and b, a and d are hex digits. A base SHA containing "bad" failed the test (main run 39200031682, base 6f6b861614cbad78f08b). Rename the fixture skill to "broken", which cannot occur in a hex string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed No findings. The PR renames the fixture skill |
|
claude-security-review reviewed No security findings. PR #8392 at f132d2f changes one file, |
No related issue: flake seen on main run 39200031682
Summary
scripts/check-changed-skills.test.shasserts the fixture skill "bad" was not checked with! grep -q 'bad' "$r/checklog".checklogalso recordsbase=<sha>, and b, a and d are hex digits, so any base SHA containing "bad" fails the test. It failed on main run 39200031682 with base6f6b861614cbad78f08b….Fix
Rename the fixture skill from
badtobrokeneverywhere the test uses it (stub checker,add_skillcalls, comments, the commit message).brokencontains letters outside the hex alphabet, so it cannot appear in a SHA. The assertion stays a plaingrep, so the diff is ten one-word substitutions.Verification
bash scripts/check-changed-skills.test.shprintedPASS=23 FAIL=0.bash scripts/check-affected.sh --testsprinted6 passed, 3 skipped over 1 changed files.scripts/check-changelog-fragments.sh --check-required origin/mainreported no fragment required.Left out: nothing
Related
N/A
🤖 Generated with Claude Code