Skip to content

test(scripts): rename check-changed-skills fixture skill so a hex SHA cannot match it - #8392

Merged
kyle-sexton merged 1 commit into
mainfrom
fix/check-changed-skills-hex-flake
Oct 19, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
fix/check-changed-skills-hex-flake

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: flake seen on main run 39200031682

Summary

scripts/check-changed-skills.test.sh asserts the fixture skill "bad" was not checked with ! grep -q 'bad' "$r/checklog". checklog also records base=<sha>, and b, a and d are hex digits, so any base SHA containing "bad" fails the test. It failed on main run 39200031682 with base 6f6b861614cbad78f08b….

Fix

Rename the fixture skill from bad to broken everywhere the test uses it (stub checker, add_skill calls, comments, the commit message). broken contains letters outside the hex alphabet, so it cannot appear in a SHA. The assertion stays a plain grep, so the diff is ten one-word substitutions.

Verification

  • bash scripts/check-changed-skills.test.sh printed PASS=23 FAIL=0.
  • bash scripts/check-affected.sh --tests printed 6 passed, 3 skipped over 1 changed files.
  • scripts/check-changelog-fragments.sh --check-required origin/main reported no fragment required.

Left out: nothing

Related

N/A

🤖 Generated with Claude Code

… cannot match it

The not-checked assertion greps checklog for the fixture skill name "bad",
but checklog also records base=<sha>, and b, a and d are hex digits. A base
SHA containing "bad" failed the test (main run 39200031682, base
6f6b861614cbad78f08b). Rename the fixture skill to "broken", which cannot
occur in a hex string.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review October 19, 2026 05:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T05:09:33.817523Z f132d2f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed f132d2f14fae21b47f1b8183eadcbf82a2b8f529: 0 finding(s), 0 as inline comments.

No findings. The PR renames the fixture skill bad to broken in scripts/check-changed-skills.test.sh. I read the full diff and grepped the file: no bad remains, and all 10 occurrences of broken are consistent (stub checker, add_skill calls, comments, commit message, ! grep -q 'broken' assertion). broken contains r, o, k and n, which are not hex digits, so a base SHA cannot match it, and that fixes the flake the PR describes. I did not run the test suite; the PASS=23 FAIL=0 result is author-claimed and unverified by me. There is no closing issue (No related issue: line), and no security or paved-path concerns apply.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed f132d2f14fae21b47f1b8183eadcbf82a2b8f529: 0 finding(s), 0 as inline comments.

No security findings. PR #8392 at f132d2f changes one file, scripts/check-changed-skills.test.sh. It renames the fixture skill bad to broken in a test stub and its scenarios. It adds no new inputs, command execution, secrets handling or trust boundary. It deletes no guardrail or standing instruction, so the instruction-surface lens found nothing to check. Nothing here touches the Actions workflow files.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit c470fc7 Oct 19, 2026
56 checks passed
@kyle-sexton
kyle-sexton deleted the fix/check-changed-skills-hex-flake branch October 19, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant