Skip to content

feat(planning): group Accept all takes every open question, add multi-select - #8201

Merged
kyle-sexton merged 8 commits into
mainfrom
work-resolve-issue/issue-5816-39093469964-1
Oct 20, 2026
Merged

kyle-sexton merged 8 commits into
mainfrom
work-resolve-issue/issue-5816-39093469964-1

Conversation

@melodic-automation-lanes

@melodic-automation-lanes melodic-automation-lanes Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Closes #5816

Hold: a human merges this

Summary

Opened by the work-resolve-issue lane from work-resolve-issue/issue-5816-39093469964-1, which an earlier run left with commits and no report. A summary-only model pass read the branch's diff and the issue, changed nothing, and wrote:

On the planning interview page, a group's Accept all now covers every eligible open question in the group, opened or not. It shows one confirmation listing each id, its full recommendation and its commitments, which stay unconfirmed. Questions in a group get a checkbox on the rail card, and ctrl/cmd-click on a card toggles it. When any are selected, the header shows Accept selected (N) and Clear in place of Accept all, and Accept selected uses the same confirmation. Notes with a Challenge: line, locked groups, open prerequisites and withheld recommendations are still left out. The round-section Accept all and its audit variant keep the opened-only rule, which the issue's out-of-scope list allows. The diff updates the UI journey test for both paths, the interview surface contract and a changelog entry. It does not appear to change the server-side stale-revision handling. I did not run the tests. The diff contains no text that tries to steer a reviewer.

Fix

  • plugins/planning/surface/index.html: group Accept all counts and accepts all eligible open questions, opened or not; the round section keeps opened-only
  • plugins/planning/surface/index.html: add S.pick selection state, per-card checkboxes, ctrl/cmd-click toggle, Accept selected (N) and Clear buttons; selections are dropped when a question stops being eligible
  • plugins/planning/surface/index.html: acceptAllDialog takes an every mode ("all" or "sel") and lists each question's commitments as unconfirmed; the selection is cleared after Accept selected
  • plugins/planning/surface/index.html: CSS for the pickable list items and checkbox layout
  • plugins/planning/surface/tests/ui_journey.js: assert that group Accept all counts 3 and lists the unopened Q5, then cover the checkbox path (Accept selected (2) and its dialog)
  • plugins/planning/skills/interview/context/surface.md: surface contract describes the group Accept all, selection and Accept selected behavior, and the unchanged round-section rule
  • .changes/planning/feat-interview-group-accept-all-multiselect-5816-b4e1d7a2.md: minor-bump changelog entry

Files the branch changes, from the compare listing; a denied path, which the merge lane refuses, is marked and listed first:

  • .changes/planning/feat-interview-group-accept-all-multiselect-5816-b4e1d7a2.md
  • plugins/planning/skills/interview/context/surface.md
  • plugins/planning/surface/index.html
  • plugins/planning/surface/tests/ui_journey.js

Verification

The earlier run reported no checks here, and the summary pass ran none.

Left out: every check the earlier run would have reported; a person reviews the diff before merging.

Related

#5816

melodic-automation-lanes Bot and others added 2 commits October 18, 2026 03:34
…-select

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 32fd949c8f27ec528477d90bf623dd65f3f6b934: 0 finding(s), 0 as inline comments.

Security review (incremental, 4e16a84..32fd949): no security issues found.

The two changed files are plugins/planning/skills/interview/context/surface.md (doc wording: the Accept all confirmation lists the full recommendation instead of its first line) and plugins/planning/surface/tests/ui_page.js (one test assertion updated to match). Neither adds or removes a trust boundary, input handling, credential use or access control. The doc edit removes no guardrail: the eligibility exclusions (challenged commitment, locked group, open prerequisites, withheld recommendation) and the "commitments stay unconfirmed" rule are unchanged. The instruction-exception register was not consulted, because nothing was deleted or softened.

Comment thread plugins/planning/surface/index.html Resolved
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed 32fd949c8f27ec528477d90bf623dd65f3f6b934: 0 finding(s), 0 as inline comments.

No findings in the incremental change since 4e16a84, which touches two files.

  • plugins/planning/skills/interview/context/surface.md: the contract now says the group Accept all confirmation lists "its full recommendation". acceptAllDialog (plugins/planning/surface/index.html:1899) renders esc(String(q.recommendation)) in full, so this matches the code. The new sentence that the round-section and audit confirmations show the full recommendation also holds, because they use the same dialog.
  • plugins/planning/surface/tests/ui_page.js:68: the assertion changes from "first sentence only" to "every sentence". The regex matches the three-sentence Q1 recommendation in tests/fixtures/ui_page/round.json. text() collapses whitespace and page.textContent("#dlgBody li") returns the first list item, so the assertion is sound. It would fail if the dialog went back to truncating the recommendation.

I read the code and the fixture but did not run the test suite. The earlier-reviewed files are unchanged and were not re-reviewed.

…ert commitments

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

pr-unblock / address-feedback finished round 1 of 3 on ef736a4.

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

pr-unblock / address-feedback finished round 2 of 3 on ef736a4.

@melodic-automation-lanes melodic-automation-lanes Bot added the needs-human Human-in-the-loop required; autonomous sessions must not resolve items carrying this. label Oct 18, 2026
@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

The pr-unblock lane stopped on this pull request and needs a person: a review finding is uncertain or deferred, so a person decides it.

  • Reason: feedback-uncertain
  • Resume key: ef736a4f1482528b26f4406eb702499a137a3c26 (the head the lane stopped on)

To resume, deal with the reason above, remove the needs-human label (and do-not-merge, if set), then dispatch the pr-unblock workflow with pr-number=8201 and activity=address-feedback:

gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=8201 -f activity=address-feedback

Q4 is held by its Challenge note, so its recommendation never shows. Lengthen
Q3's recommendation past the old 110-character cut and assert its last sentence.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

pr-unblock / address-feedback finished round 3 of 3 on 0996441.

…sue-5816-39093469964-1

# Conflicts:
#	plugins/planning/surface/index.html
Comment thread plugins/planning/surface/index.html Resolved
kyle-sexton and others added 2 commits October 19, 2026 15:14
…mendation

ef736a4 made the accept dialog print each recommendation in full, as
issue #5816 asks, but ui_page still asserted the old first-sentence cut
from #7182. Assert every sentence of Q1's recommendation instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit cd5af98 Oct 20, 2026
31 checks passed
@kyle-sexton
kyle-sexton deleted the work-resolve-issue/issue-5816-39093469964-1 branch October 20, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human Human-in-the-loop required; autonomous sessions must not resolve items carrying this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(planning): interview page group Accept all should accept every question in the group, plus multi-select

1 participant