Repository navigation
fix(source-control): move the babysit wrappers out of the top-level bin/ - #5882
Conversation
claude.ai organization plugin sync rejects a plugin with a top-level bin/. Move source-control-babysit-merge and source-control-babysit-resolve-thread to scripts/ under the same names and repoint every reference (skills, references, tests, the guard contract). Fail the plugin-manifest-presence gate when any plugin has a populated top-level bin/. Bump source-control to 0.73.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The wrappers now live under scripts/, so the org-sync bin/ constraint has no exception. Refs #5850 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 3m 43s —— View job Code review complete
Scope: reviewed the full diff ( Findings: none that clear the high-signal bar. What I checked in particular, since this PR is mostly a mechanical path rename plus one new gate:
Note: I could not execute the shell/Python test suites in this environment (the |
|
Claude finished @kyle-sexton's task in 1m 48s —— View job Security review: no issues found
This PR relocates the two Specifics checked:
No CRITICAL, IMPORTANT, or SUGGESTION findings. |
Closes #5850
Summary
claude.ai organization plugin sync rejects a plugin with a top-level
bin/, andsource-controlhad one holding its two babysit wrappers. The wrappers now live underscripts/with the same names, and a CI gate keeps any plugin from adding a top-levelbin/again. Part of #5835.Fix
source-control-babysit-mergeandsource-control-babysit-resolve-threadfromplugins/source-control/bin/toplugins/source-control/scripts/. Both are still executable (mode 100755); they locate the engine through../skills/babysit-prs/scripts, which is unchanged for a file inscripts/.safety.md,orchestration.md,independent-resolution.md), the setup skill's canary, the guard-contract generator and its regeneratedguard-contract.md, and the shell and Python tests.safety.mdsection on bare names. The wrappers had no dependable bare name before (PATH delivery is unreliable), so no allow rule stops matching.scripts/check-plugin-manifest-presence.sh: anyplugins/*/binwith content fails. An emptybin/passes because git tracks no empty directory. The existing CI step already runs this script, so no new step was added; only its name changed. Test cases added tocheck-plugin-manifest-presence.test.sh.docs/plugin-philosophy.md(thebin/stance is now Decline) anddocs/migration-playbook.md.source-controlto 0.73.0 with a CHANGELOG entry.Verification
plugins/source-control/skills/babysit-prs/scriptsPython suite: 782 tests, OK (includestest_guards.py, which checks the regenerated contract is not stale, andtest_skill_contract.py).babysit-wrapper-help.test.sh,babysit-readiness-gate.test.sh, andengine.test.sh: all passed (3 optional skips, unrelated: Windows-only paths,zipmissing).scripts/check-plugin-manifest-presence.test.sh: 14 passed; the gate is green on this tree and reportsTOP-LEVEL BIN DIRECTORYon a populated fixturebin/.check-changelog-parity.sh --checkand--check-bump origin/main,check-shell-portability.sh origin/main,check-skill-portability.sh origin/main,check-spoke-plugin-root.sh,validate-plugins.sh, shellcheck, shfmt, markdownlint-cli2: clean.check-script-contract.test.sh: 46 passed, 2 failed (check-html-assets.sh, htmlhint not installed in this worktree); the same 2 fail without this change.affected-tests.sh --runselection (337 suites) was not run to completion locally; CI runs it on ready.Related
🤖 Generated with Claude Code