Repository navigation
docs(repo-hygiene): record CLAUDE_SKILL_DIR scope residual for clean context files - #2251
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @kyle-sexton's task in 2m 15s —— View job Code review
This is a docs-only PR recording a DEFER decision for #2237 — no code behavior changes. Reviewed all 4 changed files against Verified independently:
Not independently verified (author-claimed only): I was unable to execute One finding posted inline (Nit, invocation-forms.md#L30-L33): the new doc frames whether No other correctness, error-handling, or maintainability issues found in this diff. Security scope not applicable — this PR touches no security-relevant code paths. |
|
Claude finished @kyle-sexton's task in 38s —— View job Security Review
Scope: Findings: none.
This PR is documentation-only in effect; there is nothing in the changed files that alters a trust boundary, execution path, or access-control surface. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a829ef651
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
9a829ef to
6463f37
Compare
|
Warning Automated review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
Re-run the job to retry the review. A new push re-triggers this lane only if the caller's |
|
Warning Automated security review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
The check is green on purpose, and it is not evidence. It certifies that a security pass ran, and this one did not complete — but the cause is outside this PR's control, so merging is deliberately left unblocked rather than locking every merge for the length of the outage. Nothing was reviewed at this head. Where this check is required, it is satisfied without that evidence; a human should review security-sensitive changes here before merging. Re-run the job to retry the review; a new push also retries it only if the caller's Re-running does NOT help for every class:
|
…context files
Document the accepted two-form invocation split (SKILL.md paired on
${CLAUDE_SKILL_DIR}; context/*.md deferred on ${CLAUDE_PLUGIN_ROOT}) per
decide-lane #2237 DEFER verdict. Extend allowed-tools-pairing.test.sh to guard
context files against premature ${CLAUDE_SKILL_DIR}/scripts/ conversion.
Relates #2237
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…ission-rule doc tension
- Strengthen allowed-tools-pairing guard: every context/*.md script reference
must retain bash ${CLAUDE_PLUGIN_ROOT}/skills/<skill>/scripts/…, not only
exclude ${CLAUDE_SKILL_DIR}.
- Acknowledge tension with permission-rule-hygiene README's broader substitution
phrasing in invocation-forms.md.
Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
…nvocation-forms Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
af1fac4 to
dcc8909
Compare
No linked issue
Summary
Records the decide-lane DEFER verdict for #2237: keep
/repo-hygiene:clean's six bundledcontext/*.mdfiles on the interpreter-led${CLAUDE_PLUGIN_ROOT}form; do not convert them to${CLAUDE_SKILL_DIR}until substitution scope for on-demand context files is verified empirically.skills/clean/reference/invocation-forms.mddocumenting the accepted two-form split (SKILL.mdpaired on${CLAUDE_SKILL_DIR}+allowed-tools;context/*.mddeferred on${CLAUDE_PLUGIN_ROOT}).SKILL.mdto the new reference spoke.allowed-tools-pairing.test.shwith a comment and guard assertingcontext/*.mdnever adopt direct${CLAUDE_SKILL_DIR}/scripts/…invocations.[Unreleased].docs/conventions/permission-rule-hygieneis not standards-managed (no sync manifest entry); the residual is recorded skill-locally per convention.No changes to the six
context/*.mdinvocation forms.Test plan
bash plugins/repo-hygiene/scripts/allowed-tools-pairing.test.sh— all checks pass, including six new context-file guardsRelated
Refs #2237