Repository navigation
perf(ci): merge Refine's three plan jobs into one - #17552
kyle-sexton wants to merge 5 commits into
Conversation
pr-refine.yml ran check-dispatcher-current, select-passes and fix-docs-head as three serial jobs. All three run only default-tip code with read-only tokens and each resolved the tip and checked it out again; they were separate only to pass outputs between them. They are now one job, select-passes, with the compare, plan and head-read steps gated on the earlier steps' outputs. This removes 2 serial hops from runs that plan fix-docs (1 from runs that plan no pass) and up to 2 runner slots and checkouts. Measured queue waits on the removed hops were 22, 87, 48, 31 and 4 s across 5 full runs, plus about 15-20 s of repeated tip resolve and checkout. Behavior is kept: - Permissions are the union of the three jobs' read scopes (actions, contents, pull-requests: read); no write scope, id-token or secret. - A stale dispatcher starts no plan step and no later job. - New plan-result and head-result outputs give record-passes each part's own result, so a failed plan still logs pass=plan. A red head step is still logged as fix-docs-head, and a red compare still logs nothing, when GitHub passes a failed job's outputs to its dependents (not documented); otherwise a failed job logs pass=plan. - The lane-hold output is renamed hold-held, since select-passes already exports held for the changed-files hold. - Fix Docs Head Held keeps its name and now needs select-passes alone. Tests that pinned the old layout are updated to the merged job. Refs: #14292 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeBVgdbwavfuWZGmKnMhWX
The pr-pipeline docs now name select-passes where they named fix-docs-head; the convention itself is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeBVgdbwavfuWZGmKnMhWX
…y-read Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeBVgdbwavfuWZGmKnMhWX
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeBVgdbwavfuWZGmKnMhWX
|
claude-security-review reviewed Security review: PR #17552, incremental since f024f37No security issues found. Scope. This was an incremental review of one listed file, What changed. The commit deletes one code comment in a test helper: Why it is not a finding.
Prior finding. The one earlier entry is this lane's whole-review summary of f024f37, which found no issues. It carries no finding to restate. critical-findings: 0 |
|
claude-review reviewed Code review (incremental, blocking only): f024f37 → baa0fecThis lane already reviewed an earlier head, so this review reports only blocking findings. Scope. One file changed since the last review: What changed. The push deletes one comment line above No blocking findings.
Verifier dropped 0 of 0 candidates. |
|
The pr-verify verifier failed head What it wrote (31 lines)This pull request leaves the merge queue, and ci-status holds it out while it carries |
Refs: #14292
Summary
pr-refine.ymlrancheck-dispatcher-current,select-passesandfix-docs-headas three serial jobs. All three run only default-tip code with read-only tokens, and each one resolved the tip and checked it out again. They were separate jobs only to pass outputs between them. Each extra job is a serial hop (queue wait, runner start, checkout) on the path Review waits behind (.github/scripts/pr-review/wait-refine.mjs:121-122).Fix
select-passes, with the compare, plan and head-read steps gated on the earlier steps' outputs.contents: read,actions: read,pull-requests: read. The oldselect-passesheldcontentsandpull-requests, so its steps now also run withactions: read. No write scope, noid-token, no secret. The hub session checked this under the owner's security rule: read-only scope, base code only.plan-resultandhead-resultoutputs giverecord-passeseach part's own result, so a failed plan still logspass=plan. UNVERIFIED: a red head step is logged asfix-docs-headonly if GitHub passes a failed job's outputs to its dependents. The workflow syntax docs say outputs "are available to all downstream jobs that depend on this job" and do not address a failed job. If GitHub does not pass them, a failed job logspass=plan.hold-held, sinceselect-passesalready exportsheld.Fix Docs Head Heldkeeps its name and now needsselect-passesalone.Verification
Before (W5, 7 runs on 2026-11-19): the critical path with no change was 9 serial jobs, 11 when a patch is pushed. Measured queue waits on the two removed hops were 22, 87, 48, 31 and 4 s across 5 full runs, plus about 15-20 s of repeated tip resolve and checkout.
After: 2 fewer serial hops on runs that plan fix-docs, 1 fewer on runs that plan no pass, and up to 2 fewer runner slots and checkouts per run.
node --test --test-concurrency=4over the 32 affected test files: 2673 pass, 0 fail (rerun after mergingmain).scripts/check-read-caller-keys.test.sh,read-runner-dispatcher-gate.test.sh,check-app-key-references.test.sh: pass.actionlint: clean.After merge I'll measure the Refine span and Review's wait on the next runs against the W5 table.
Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01KeBVgdbwavfuWZGmKnMhWX