Skip to content

fix: ignore two live links that refuse the link checker - #17545

Open
kyle-sexton wants to merge 1 commit into
mainfrom
fix/15082-lycheeignore-bot-walled-links
Open

kyle-sexton wants to merge 1 commit into
mainfrom
fix/15082-lycheeignore-bot-walled-links

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Closes #17557

Summary

The online link check (run 44617609207) reports two URLs, both with status 403. Both pages are alive and refuse only the checker. Each gets an exact-URL .lycheeignore entry, with no comment; the commit message gives the dated reason. The linked issue names the two entries and carries the owner's approval of this loosening of the link check.

Fix

Two anchored entries in .lycheeignore, beside the other exact-URL entries:

  • https://doi.org/10.17226/25303: a DOI that resolves (302) to www.nationalacademies.org/publications/25303, which answers 403 to non-browser clients. Cited in docs/standards/deterministic-work-execution.md, which is synced from another repository and not edited here.
  • https://www.prnewswire.com/news-releases/warner-music-group-and-suno-forge-groundbreaking-partnership-302626017.html: answers 200 to a browser user agent (checked 2026-11-19). Cited in plugins/songwriting/skills/suno/SKILL.md, not edited.

Verification

  • Run 44617609207: status 403 for both URLs.
  • DOI: 302 to the publisher page, which answers 403 to the checker.
  • prnewswire: 200 to a browser user agent on 2026-11-19.
  • scripts/check-affected.sh: 13 passed, 7 skipped over 1 changed file; no changelog fragment required.

Related

The weekly dead-link rollup issue lists these two URLs; it closes itself on the next link-check run that reports none.

🤖 Generated with Claude Code

Refs: #15082

2026-11-19, run 44617609207 of the online link check:

- https://doi.org/10.17226/25303 answered status 403 to the checker. The
  DOI resolves to a publisher page behind a bot wall.
- https://www.prnewswire.com/news-releases/warner-music-group-and-suno-forge-groundbreaking-partnership-302626017.html
  answered status 403 to the checker and 200 to a browser.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 19, 2026 22:16
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T22:17:21.853135Z 0b95bab Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude-review: 1 inline finding(s) on 0b95babea0c29d640f65c0607646a775aea1d901; the summary is in this lane's pull request comment.

claude-lane: claude-review

Comment thread .lycheeignore Resolved
@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 0b95babea0c29d640f65c0607646a775aea1d901: read 1 of 1 changed file(s); 1 finding(s), 1 as inline comments.

Code review: PR #17545

The PR adds two anchored exact-URL entries to .lycheeignore (lines 84–85), next to the other exact-URL entries. Each entry uses the same anchoring and escaping as the existing ones. I checked that both match URLs the repository actually cites:

  • the DOI at docs/standards/deterministic-work-execution.md:62 and :108
  • the prnewswire URL at plugins/songwriting/skills/suno/SKILL.md:20

I found no correctness problems with the regexes themselves.

Blocking: one finding (inline on .lycheeignore lines 84–85). Adding ignore entries to the link checker is a loosening (kind 4: "a suppression, ignore or allowlist entry added"). The PR closes no issue: the body says only Refs: #15082, and the PR context has no closing-issue section. So no trusted spec text names these entries or says why. The 403 explanation in the PR body and the commit message is the author's own claim. I did not run or check it, and under this criterion author-written text cannot supply the reason.

Closing issue: none. The PR references #15082 but does not close it, so I checked no acceptance criteria.

Loosened-check verdict: fail (default; no loosened_check_verdict: line in prompt); patterns: 0. No loosened_check_patterns: line was given, so I used no consumer entries. No loosened_check_decision_record: line was given, so I did not check the requirement to cite the owner's decision.

No settled-threads file was named, and the prior-findings file lists no earlier heads, so this was a full review (not blocking only). I ran no subagent verifier; I checked the single candidate myself against the diff, the head file and the cited source files.

Verifier dropped 0 of 1 candidates.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 0b95babea0c29d640f65c0607646a775aea1d901: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review: no security issues found

This pull request changes one file, .lycheeignore. It adds two anchored, exact-URL ignore entries for the link checker:

  • ^https://doi\.org/10\.17226/25303$
  • ^https://www\.prnewswire\.com/news-releases/warner-music-group-and-suno-forge-groundbreaking-partnership-302626017\.html$

I read every hunk of the diff. The file only controls which URLs the lychee link checker skips. It sets no permissions, tokens, workflow triggers, trusted actors or merge holds, and no code runs from it. Both patterns are escaped and anchored with ^…$, so each one matches only its own URL. The file matches none of the trusted-path globs. No plugin manifest or instruction file is touched. The pull request description contains no embedded directives.

The only effect is that the link check stops flagging these two URLs. That is a link-health matter, not a security one.

critical-findings: 0

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

The pr-verify verifier failed head 0b95babea0c29d640f65c0607646a775aea1d901. What it wrote, as data:

Summary: Issue #17557 asks for two exact-URL entries in `.lycheeignore`, anchored, with no comment,
  and no other file changed. The diff delivers that exactly: both regexes match the issue's text,
  sit beside the other exact-URL entries, and nothing else changes. This passes no CI check, because
  `Select Tests` was skipped, so this was a re-run that ran no suite and the job list proves nothing
  either way. It still fails on the safety rule. The issue itself says the entries loosen the link
  check: it will no longer report these two URLs, even if they later go dead. A spec only authorises
  a weakened check when it has both the owner's words after `verbatim:` and a line link to the
  decision in the owner-decisions record (`docs/owner-decisions.md#L<line>`). Issue #17557 has the
  verbatim words ("go w/ recommended") but no such link, so the loosening is not authorised.
- Issue #17557 body (the spec, not a file in the diff): add a line link to the owner's Q94 decision
  in the owner-decisions record (https://github.com/melodic-software/architecture/blob/<commit or
  main>/docs/owner-decisions.md#L<line>) next to the existing `verbatim:` quote. Without that link,
  the spec does not authorise loosening the link check for these two URLs. The `.lycheeignore`
  entries themselves are correct and need no change.

This pull request leaves the merge queue, and ci-status holds it out while it carries pr-verify-failed. A pr-verify pass removes the label, at a new commit or at this same head: once a trusted person edits the body, and only trusted people have edited it since the fail, this head is judged again, so a fail on the body or the issues it links needs only the body fixed, no new commit.

@github-actions github-actions Bot added the pr-verify-failed pr-verify failed this head; a pass at a new commit, or after a trusted body edit, removes it. label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-verify-failed pr-verify failed this head; a pass at a new commit, or after a trusted body edit, removes it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore two live links that answer 403 to the link checker

1 participant