Repository navigation
fix(plugin-profiles): give the moved-repository question its own answers and fix reset wording - #17542
fix(plugin-profiles): give the moved-repository question its own answers and fix reset wording#17542kyle-sexton wants to merge 8 commits into
Conversation
…kind of question The moved-repository question reused the folder-without-a-record kind: the picker offered Remove for putting a file back, a caller passed --remove-unrecorded, and the one question said only that folders without a record are not covered. It is now its own kind in ASKS: Keep (first) and Put back, answered with --keep-moved and --put-back-moved, refused with any other kind's flag, named once in the one question's "not covered" sentence, and recommended with a reason that names where the profile was applied before the move. The old flags no longer answer it: reset has not shipped in a release yet. Refs #17540 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…asking In the owner's second live try the skill replaced the preview lines with a one-line summary saying reset "removes it directly" and then asked. The reset action now shows every line of `lines`, in order and exactly as printed, in a code block before any question, never a summary, paraphrase or subset. The reset-previews-then-asks case gains a preview-lines-shown grader (with-only) that needs the scaffold's preview lines before a question in the last message; its samples fail a summary, a paraphrase, no lines, and a question asked before the lines. The offline validator passes; the live eval was not run. Refs #17540 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…anged "N files that reset restored earlier are unchanged since; reset leaves them." named no file. The line now ends with the files: the first three and "and K more" past three, as the other reset lines list entries; `--json` still lists every one in unchangedSinceReset. Refs #17540 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…keeps older records Applying a profile to a repository that moved, while a record from before the move is kept, said nothing; the person first learned that reset takes one run per layer from the reset preview. Apply's folder preview now adds one line naming each such record's file and profile and saying that reset puts the file back one layer per run, newest first. The records come from reset's own detection: machineFiles' record readers are now settingsFilesIn, which both reset and the new movedRecordsOf call over machineSettingsFiles, so there is no second rule for what counts as moved. Refs #17540 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d", not "restored" A cut-off file finished with a yes while keeping a hand edit is noted as unchanged since reset, yet it is not back at its original, so "files that reset restored earlier" was false for it. The one line that counts them now says "files that reset already handled", true for both; the picker's "Nothing to reset" line, which echoes it, says the same. Refs #17540 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ill owes A cut-off row counts an entry an unfinished switch still owes among those "still at the values profile P wrote", though it holds an earlier profile's value. When the row's entries include such an entry, wroteValues, which builds the preview line, the question and the result, says "the values profile P wrote or its unfinished switch had yet to change"; with none, the wording is as before. Refs #17540 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n its own line
The unreleased reset fragment ran two bullets together ("...marks that answer
`(Recommended)`.- Reset notes the bytes..."), so the release would print them
as one. The second bullet now starts its own line.
Refs #17540
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Owned by the control-hub session for plugin profiles (control-hub#11). Held with do-not-merge until the owner has tried the changed questions live; no other session should push to, resolve threads on, or queue this pull request. |
|
claude-security-review needs no new review of Security review: no security issues foundThis PR changes the wording and labels of the plugin-profiles What I checked:
Spend: the new eval grader can only add to prepaid eval runs. It starts no billed resource. critical-findings: 0 |
|
claude-review needs no new review of Code review: no blocking findingsI read every hunk of all 14 changed files in the diff. I also read the unchanged code that the changed lines call: Closing issue #17540, checked against each "Done when" item:
Loosened checks. Several test expectations changed: the moved-repository flags went to Embedded text. Neither the PR context file nor the prior-findings file holds any instruction aimed at the lane. Spend. The PR changes no plugin manifests and adds no paid usage. The patch Verifier dropped 0 of 0 candidates. |
…eset-wording # Conflicts: # .changes/plugin-profiles/feat-plugin-profiles-reset-14c36134.md
Closes #17540
Summary
Follow-up to #17390 (plugin-profiles
reset): the wording and labelling items left from the owner's live try. Each item is one commit, test first.Fix
ASKS.movedsits beside the other kinds: answers Keep (first, changes nothing) and Put back, flags--keep-moved/--put-back-moved. Another kind's flag for that file is refused with "is answered with --put-back-moved or --keep-moved, not ", and--remove-unrecorded/--keep-unrecordedno longer answer it. Reset shipped in plugin-profiles 0.9.0 (chore(release): release 5 plugins #17543) while this pull request was open; the old flags are still not kept for this kind, as plugin-profiles reset: give the moved-repository question its own answers, and fix leftover wording #17540 asks, and the fragment says so. The first question says "A file in a repository that moved is not covered: each gets its own question.", and when several kinds are present it names them once ("a, b and c are not covered"). The recommendation's reason names where the profile was applied before the move. The picker needed no code change: it already takes labels and flags fromask.yes/ask.no.lines, in order and exactly as printed, in a code block before any question: never a summary, paraphrase or subset. Thereset-previews-then-askscase gains apreview-lines-showngrader (with-only), and its samples fail a summary, a paraphrase, no lines, and a question asked before the lines.machineFiles' record readers becamesettingsFilesIn, which reset and the newmovedRecordsOfboth call.Not delivered
mainaccepted its deletion, and ADR 0048 keeps pull requests from editing CHANGELOG entries. plugin-profiles reset: give the moved-repository question its own answers, and fix leftover wording #17540 records the item as dropped.What the owner will see differently
applyin a moved repository with an older record warns that reset will take one run per layer.Verification
node --test --test-concurrency=4 "plugins/plugin-profiles/**/*.test.mjs": 291 pass, 0 fail (re-run after mergingmainataf9d2e8a74e)claude plugin test plugins/plugin-profiles: 53 pass, 0 fail (before the merge ofmain)claude plugin validate plugins/plugin-profiles: passes. The 6 TS warnings inhooks/plugin-profile.test.tsare on lines this branch does not touch.plugins/evals/skills/validate/scripts/validate-cases.py plugins/plugin-profiles/evals: no FAIL, and the new grader sorts all 6 samples correctly. The live eval was not run.flagschanged (toASK_FLAGS.moved). No cell changed.claude plugin evalrun, per the brief; the owner tries the changed questions live before merge.Related
🤖 Generated with Claude Code