Repository navigation
fix(playwright): align demo-video numpy with animation to unbreak main - #17439
Conversation
#17341 bumped plugins/animation to numpy 2.5.5 while plugins/playwright/skills/demo-video still pinned 2.5.4. The Test Bash toolchain step installs both locks in one pip call, so it failed with ResolutionImpossible. Bump demo-video to 2.5.5 and regenerate its lock with the uv command in its header. Merge the two Dependabot pip entries into one with both directories and a numpy group-by dependency-name group, so one pull request bumps numpy in both. The CI step's dependency-relock check now also fails while the two directories pin different numpy versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeBVgbERyakZ33T4AetfRj
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeBVgbERyakZ33T4AetfRj
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #17439I found no security issues in this pull request. I read the whole diff for all 4 changed files. None of them matches a trusted-path glob. The change touches no trust controls: no trusted-actor list, token scope, kill switch or merge hold. It also changes no plugin manifest.
I found no embedded directives in the PR context. critical-findings: 0 |
|
claude-review reviewed Review: align demo-video numpy with animation (#17439)The pin change is correct. Two advisory findings, both on
Loosened-check verdict: fail (default; the prompt had no Spend: none. The grouped entry may change how many Dependabot pull requests open, but it uses no paid resource. Verifier dropped 0 of 2 candidates. I did not dispatch a verifier; I checked both candidates directly against the source cited above. |
Take main's numpy pin fix (#17439) so Test Bash installs one numpy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeBVgbERyakZ33T4AetfRj
No related issue: main red after #17341
Summary
#17341 bumped
plugins/animationto numpy 2.5.5 whileplugins/playwright/skills/demo-videostill pinned 2.5.4. The "Install locked plugin test toolchains" step inpr-require-checks.ymlinstalls both locks in onepip install --require-hashescall, so Test Bash (1) fails withResolutionImpossible.Fix
requirements.into numpy 2.5.5 and regeneraterequirements.txtwith the uv command its header names (hashes kept; only the numpy block changes)..github/dependabot.ymlinto one entry with bothdirectoriesand anumpygroup withgroup-by: dependency-name, so one Dependabot PR bumps numpy in both. Because that group isgroup-by: dependency-name, the step's existingdependency-relock.mjs checknow also fails while the two directories pin different numpy versions. The pr-unblock relock lane does not repair a lagging directory here: both locks carry--only-binary :all:in their header, whichrelockRequestrejects, so such a PR goes to model review.The other numpy pins (
plugins/speech2.5.5,plugins/explainer-video2.5.3) are not installed by this step.Verification
uv pip install --only-binary :all: --require-hashesof the animation, demo-video and lib/media-render locks together on Python 3.12: resolves and installs numpy 2.5.5.node .github/scripts/pr-unblock/dependency-relock.mjs check:numpy: plugins/animation and plugins/playwright/skills/demo-video pin 2.5.5;dependency-relock.test.mjs12/12 pass.pytest plugins/playwright/skills/demo-video/scripts/test_demo_video.pyon numpy 2.5.5: 32 passed.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01KeBVgbERyakZ33T4AetfRj