Skip to content

fix(playwright): align demo-video numpy with animation to unbreak main - #17439

Merged
kyle-sexton merged 2 commits into
mainfrom
fix/demo-video-numpy-2.5.5
Nov 19, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
fix/demo-video-numpy-2.5.5

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

No related issue: main red after #17341

Summary

#17341 bumped plugins/animation to numpy 2.5.5 while plugins/playwright/skills/demo-video still pinned 2.5.4. The "Install locked plugin test toolchains" step in pr-require-checks.yml installs both locks in one pip install --require-hashes call, so Test Bash (1) fails with ResolutionImpossible.

Fix

  • Bump demo-video's requirements.in to numpy 2.5.5 and regenerate requirements.txt with the uv command its header names (hashes kept; only the numpy block changes).
  • Merge the animation and demo-video pip entries in .github/dependabot.yml into one entry with both directories and a numpy group with group-by: dependency-name, so one Dependabot PR bumps numpy in both. Because that group is group-by: dependency-name, the step's existing dependency-relock.mjs check now also fails while the two directories pin different numpy versions. The pr-unblock relock lane does not repair a lagging directory here: both locks carry --only-binary :all: in their header, which relockRequest rejects, so such a PR goes to model review.
  • Playwright patch changelog fragment.

The other numpy pins (plugins/speech 2.5.5, plugins/explainer-video 2.5.3) are not installed by this step.

Verification

  • uv pip install --only-binary :all: --require-hashes of the animation, demo-video and lib/media-render locks together on Python 3.12: resolves and installs numpy 2.5.5.
  • node .github/scripts/pr-unblock/dependency-relock.mjs check: numpy: plugins/animation and plugins/playwright/skills/demo-video pin 2.5.5; dependency-relock.test.mjs 12/12 pass.
  • pytest plugins/playwright/skills/demo-video/scripts/test_demo_video.py on numpy 2.5.5: 32 passed.

Related

  • Supersedes Dependabot #17344, which makes the same demo-video bump.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KeBVgbERyakZ33T4AetfRj

kyle-sexton and others added 2 commits November 19, 2026 09:46
#17341 bumped plugins/animation to numpy 2.5.5 while
plugins/playwright/skills/demo-video still pinned 2.5.4. The Test Bash
toolchain step installs both locks in one pip call, so it failed with
ResolutionImpossible. Bump demo-video to 2.5.5 and regenerate its lock
with the uv command in its header.

Merge the two Dependabot pip entries into one with both directories and
a numpy group-by dependency-name group, so one pull request bumps numpy
in both. The CI step's dependency-relock check now also fails while the
two directories pin different numpy versions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KeBVgbERyakZ33T4AetfRj
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 19, 2026 14:48
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T14:50:19.972869Z ace73e8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed ace73e80675d597d7733371971cab8714b4e2f42: read 4 of 4 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #17439

I found no security issues in this pull request.

I read the whole diff for all 4 changed files. None of them matches a trusted-path glob. The change touches no trust controls: no trusted-actor list, token scope, kill switch or merge hold. It also changes no plugin manifest.

  • plugins/playwright/skills/demo-video/requirements.in and requirements.txt: numpy moves from 2.5.4 to 2.5.5, and the lock still has --hash=sha256: pins. Installs still use --require-hashes and --only-binary :all:, as the uv header in the lock shows, so pinning is not loosened. This matches the animation plugin's lock, according to the PR description. Only the numpy block changes; the Pillow pins are untouched.
  • .github/dependabot.yml: the two pip entries (animation and demo-video) become one entry with directories:. It keeps the same labels, weekly schedule, open-pull-requests-limit: 5, cooldown.default-days: 3 and minor/patch group (lines 289-310). It adds a numpy group with group-by: dependency-name. This changes only how Dependabot PRs are grouped. It does not widen what gets through or who is trusted.
  • .changes/playwright/...md: a changelog fragment, prose only.

I found no embedded directives in the PR context.

critical-findings: 0

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude-review: 2 inline finding(s) on ace73e80675d597d7733371971cab8714b4e2f42; the summary is in this lane's pull request comment.

claude-lane: claude-review

Comment thread .github/dependabot.yml Resolved
Comment thread .github/dependabot.yml Resolved
@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed ace73e80675d597d7733371971cab8714b4e2f42: read 4 of 4 changed file(s); 2 finding(s), 2 as inline comments.

Review: align demo-video numpy with animation (#17439)

The pin change is correct. requirements.in and the numpy block in requirements.txt both move to 2.5.5, and the lock header is unchanged. The fragment is a patch bump, which fits a dependency move. Merging the animation and demo-video pip entries into one entry with a numpy group-by: dependency-name group lets dependency-relock.mjs check see both directories. With both directories at 2.5.5, its parseGroups picks up the new group and the check passes. That is a new check, which makes things stricter, not looser. I did not run any command. The verification steps in the PR body (pip install, relock check, pytest) are the author's claims and I have not confirmed them.

Two advisory findings, both on .github/dependabot.yml:

  1. The relock fallback the PR describes does not apply to these directories. The PR body says "the pr-unblock relock lane covers a lagging directory." relockRequest refuses any lock whose second line differs from COMPILE_COMMAND, and that command has no --only-binary :all: (dependency-relock.mjs#L147, #L159). Both locks in this group carry that flag (animation, demo-video), so the lane refuses to relock either one.
  2. The fragment workflow's path-coverage test stops checking these two directories. That test reads only directory: /plugins/ lines (dependabot-fragments.test.sh#L127), and this change moves both directories into a directories: list.

Loosened-check verdict: fail (default; the prompt had no loosened_check_verdict: or loosened_check_patterns: line); patterns: 0. The prompt also had no loosened_check_decision_record: line, so I did not check the citation requirement. The PR loosens no check. I report finding 2 as a gap in what the test covers, not as a loosening (kind 9): dependabot.yml is what the test reads, not its code or settings. There is no closing issue (the PR body says "No related issue"), so there were no acceptance criteria to check. No .claude/rules file matches the changed paths. The PR text has no embedded instructions.

Spend: none. The grouped entry may change how many Dependabot pull requests open, but it uses no paid resource.

Verifier dropped 0 of 2 candidates. I did not dispatch a verifier; I checked both candidates directly against the source cited above.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 969fa7e Nov 19, 2026
91 of 104 checks passed
@kyle-sexton
kyle-sexton deleted the fix/demo-video-numpy-2.5.5 branch November 19, 2026 15:34
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 19, 2026
kyle-sexton added a commit that referenced this pull request Nov 19, 2026
Take main's numpy pin fix (#17439) so Test Bash installs one numpy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KeBVgbERyakZ33T4AetfRj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant