Repository navigation
refactor(session-flow): drop a history-narration comment from a save_point test - #16696
Conversation
|
Unattended merge: native auto-merge leaves this pull request unarmed at head |
|
claude-security-review reviewed Security review: PR #16696No security issues found. I read every hunk of both changed files:
Neither file matches a trusted-path glob. Neither is a standing instruction surface (CLAUDE.md, AGENTS.md, a rules file, a skill or agent body, a hook list), a plugin manifest, a workflow or a trust control. The change therefore has no security-relevant surface (skip gate item 2). The PR description matches the diff and contains no embedded directives. critical-findings: 0 |
|
claude-review reviewed No findings. I read both changed files in full.
Other checks:
Verifier dropped 0 of 0 candidates. |
|
The unattended merge path armed native auto-merge at head |
Verification evidence for a4d0872The verifier passed this head. The capture artifact holds the capture summary, which says whether the capture ran, and any screenshot or video that passed the mask check; this comment uploads no file. Capture artifact: pr-capture-16696-a4d08725869c5c643dd21912c0bac4b174b95e61, expires on 2026-12-17. One comment per pull request, updated in place for each new head. |
|
Merge-Risk: max=LOW demote=false head=a4d08725869c5c643dd21912c0bac4b174b95e61 rubric=10.0.1 rater=claude-opus-5-5 checker=claude-opus-5-5 |
|
The post-merge check verified merge commit |
Refs: #12894
Summary
Ad hoc tidy sweep of
plugins/session-flow/**(anchor commit: none (ad hoc), basee86b5d2123). One Beck #15 tidying: a test comment that narrated what an earlier validator did is removed. Only a comment changes; no assertions or code are touched.Fix
plugins/session-flow/scripts/tests/test_save_point.py: intest_validate_refuses_a_shape_below_one, removed the comment# -1 was the old unparsable sentinel, so it used to be mislabelled.It describes past behavior. The assertion below it ("not an integer" not in out(result)) already states the current invariant. 1 line removed..changes/session-flow/chore-tidy-adhoc-plugins-session-flow-2026-11-17-77608855.md: patch changelog fragment.Verification
python -m pytest tests/test_save_point.py -q -p no:cacheprovider(fromplugins/session-flow/scripts, pytest 9.2.0 in a temporary venv): 299 passed.scripts/affected-tests.shalso selected.github/scripts/graphql-operations/graphql-operations.test.sh(test-scopeplugins/*.py). It failed locally withCannot find module 'graphql'becausenode_modulesis not installed on the runner. The suite does not read this comment, so CI's run is the real check.A && B || continue), an AST unused-import and unreferenced-definition scan (the one hit,parse_claude_versioninharness/hop_chain.py, is a deliberate re-export a test uses), relative-link and anchor integrity (clean),markdownlint-cli2over 114 files (0 issues).Related
hooks/,lib/node-or-skip.*) were left alone.