Repository navigation
docs(plugin-diagnostics): tell existing installs to install plugin-diagnostics - #16597
Conversation
…agnostics A marketplace update does not install a default-on plugin where the marketplace was already installed (ADR 0109, probe row default-on-existing-users), so a harness-ops user upgrading past the hook split gets no plugin-diagnostics. The harness-ops and plugin-diagnostics READMEs, and a fragment for each, now say "on by default" applies to a new install and give the install command. Closes #16591 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmbLtFcfditeagftLrv
|
Owner: the control-hub session "Plugin Presets" watches and merges this pull request; it waits on CI Status and the review lanes on head 8dc654d. Review findings go to it, and the build session (plugin-profiles-build-5) fixes them. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lane run report
Failed GitHub API calls
|
Lane-Activity: pr-refine/fix-docs
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed Security review: PR #16597No security issues found. This pull request changes documentation only, in four files, and I read every hunk of each:
What I checked:
Prior findings: this lane has not reviewed an earlier head ( critical-findings: 0 |
|
claude-review reviewed Code review: no findingsThis PR only changes wording: two README paragraphs and two Checks I ran with Read and Grep:
Closing issue #16591, Done when:
These criteria are about wording, so no test could fail on them. I did not count that as a finding. The author says No manifest changes, no paved-path or path-scoped rule hits, and nothing in the PR context is aimed at the review lane. This change spends nothing billable. Verifier dropped 0 of 0 candidates. |
Closes #16591
Summary
#16519 moved harness-ops' session hooks into
session-telemetry(off by default) andplugin-diagnostics(on by default). A marketplace update does not install a default-on plugin where the marketplace is already installed, so an existing harness-ops user who updates gets noplugin-diagnostics, and nothing reports a hook that fails to launch. The docs said "on by default", which reads as nothing to do. This corrects the wording; no behavior changes (owner decision, control-hub#11: wording only, no plugin dependency).Fix
plugins/plugin-diagnostics/README.md, opening paragraph: "on by default for a new install", and an existing install runsclaude plugin install plugin-diagnostics@melodic-software.plugins/harness-ops/README.md, "Session telemetry": the same for a user who installed harness-ops before the hooks moved out..changes/harness-ops/and.changes/plugin-diagnostics/: apatchfragment each, under### Fixed, saying the same where an upgrading user reads it. ReleasedCHANGELOG.mdentries are not edited.default-on-existing-users, without restating its result.Done-when, item by item:
claude plugin install plugin-diagnostics@melodic-software, and that "on by default" applies to a new install. Delivered.#probe-record-claude-code-21325-2026-11-15, rowdefault-on-existing-users) and does not restate it. Delivered.Verification
scripts/check-changelog-fragments.sh --check: all 12 fragments valid.check-affectedpasses.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_015XWwmbLtFcfditeagftLrv