Skip to content

fix(session-flow): place the retro's corrections condition and state the policy-class rule - #16500

Merged
kyle-sexton merged 4 commits into
mainfrom
fix/16284-retro-corrections-condition-wording
Nov 16, 2026
Merged

kyle-sexton merged 4 commits into
mainfrom
fix/16284-retro-corrections-condition-wording

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Refs: #16284

Summary

The retro's check proposal has two branches: with the corrections plugin it routes a mechanical finding to /corrections:codify, and without it the retro writes a Hooks-format check row from its own ladder copy. The review of #16282 left two wording findings on the branch taken without the plugin. This fixes both. It replaces #16462, which also carried a new eval case; the owner decided on 2026-11-16 to split them ("Go with recommendations."), because that case failed its own graders and the wording does not depend on it.

Fix

  • plugins/session-flow/skills/retro/SKILL.md, Gotchas: "(when the corrections plugin is enabled)" sits on the routing clause again, not on "which proves its own check". Main changed "installed" to "enabled" across this file in feat(session-flow): gate optional plugin calls on enabled skills #16450 while this was in review; the branch took main by merge and keeps main's word.
  • plugins/session-flow/skills/retro/reference/ecosystem-improvement-catalog.md, "Check first": item 2 states both halves of the rule inline: the finding repeats with the same cause, or it happened once and is policy-class (irreversible, public, or security-relevant).

Behavior with the plugin installed does not change. No eval case is added or changed.

Verification

Left out: a run at this branch's head (the wording text is the same as measured; main has moved under it), and the paired cases on opus.

Related

Remaining

🤖 Generated with Claude Code

kyle-sexton and others added 2 commits November 15, 2026 22:53
…-class rule

The retro gotcha puts "when the corrections plugin is installed" on the
hand-off to /corrections:codify, where it applies. Without the plugin, the
catalog's "Check first" item 2 now states inline that one occurrence of a
policy-class mistake (irreversible, public, or security-relevant) is enough,
beside a repeat with the same cause, so a literal reader cannot drop the
exception. The branch taken with the plugin installed is unchanged.

Refs: #16284

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The eval case moves to its own branch, so this fragment names only the
two retro wording fixes and takes this branch's slug.

Refs: #16284

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T04:01:07.591420Z ca3909e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed a78766b301ac8253c183d493978c9e5f460581f2: read 3 of 3 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #16500

I found no security issues. I read all 3 changed files in full.

All three files are prose. None is on a trusted path, and none is a manifest, workflow, script or trust control.

  • .changes/session-flow/fix-16284-…-7e418815.md is a new changelog fragment. Nothing in it runs.
  • plugins/session-flow/skills/retro/SKILL.md (Gotchas): the condition "(when the corrections plugin is enabled)" moves onto the hand-off to /corrections:codify. What the rule forbids is the same. The next gotcha is unchanged by this diff, and it still makes Phase 4 an interactive checkpoint that needs explicit user approval.
  • plugins/session-flow/skills/retro/reference/ecosystem-improvement-catalog.md ("Check first"): item 2 now states the existing "When to propose a check" rule in full. A finding qualifies if it repeats with the same cause, or if it happened once and is policy-class (irreversible, public or security-relevant). Before, the item only pointed to that rule.

Instruction-surface check: neither edit removes, narrows or softens a guardrail. The catalog change can only add proposals. A retro proposes a check without writing it, and Phase 4 still needs explicit approval before anything is saved. Nothing that a removed rule used to prevent is now reachable without a check. I did not read docs/contracts/instruction-exception-register/README.md. I judged the change by what breaks when a rule is absent.

Since the last review: the head moved from ca3909e to a78766b. The only effect on these hunks is main's merged wording ("installed" became "enabled"), which changes nothing for security.

Embedded text: the PR context contains no instructions aimed at this review.

This review was blocking only (1 earlier head reviewed), so it reports only CRITICAL and IMPORTANT findings. There are none.

critical-findings: 0

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed a78766b301ac8253c183d493978c9e5f460581f2: read 3 of 3 changed file(s); 0 finding(s), 0 as inline comments.

No findings. This review covered blocking findings only, because this lane already reviewed an earlier head (ca3909ee). I read all three changed files in full.

This is a wording-only change to /session-flow:retro, plus a changelog fragment:

  • plugins/session-flow/skills/retro/SKILL.md (Gotchas): the condition "(when the corrections plugin is enabled)" now sits on the hand-off to /corrections:codify. It keeps the word "enabled" that main switched to in feat(session-flow): gate optional plugin calls on enabled skills #16450, which is what the PR says it does.
  • plugins/session-flow/skills/retro/reference/ecosystem-improvement-catalog.md ("Check first", item 2): I checked it again against the "When to propose a check" paragraph it cites (catalog L108-L114). The two agree: one occurrence is enough for a policy-class mistake, and without the plugin a repeat with the same cause is needed. The later references to "item 1, 2 or 7" still hold.
  • .changes/session-flow/...md: bump: patch fits a wording fix. Its entries now say "enabled", which matches the skill text.

Other notes:

  • No plugin manifest changes.
  • The PR context has no closing-issue section (Refs: #16284 does not close the issue), so there are no criteria to check.
  • The eval results in the PR description are the author's claims; I did not verify them.
  • The PR context contains no instructions aimed at the review.

Verifier dropped 0 of 0 candidates.

kyle-sexton and others added 2 commits November 15, 2026 23:05
…ctions-condition-wording

# Conflicts:
#	plugins/session-flow/skills/retro/SKILL.md
#	plugins/session-flow/skills/retro/reference/ecosystem-improvement-catalog.md
The merge of main resolved two conflicted files by taking this branch's
side whole, which put back "installed" in three lines main had changed to
"enabled". Those lines are main's again; only the corrections condition
and the policy-class rule differ from main.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-unblock/resolve-conflicts
Model rung 0
Leg base
Run job success
Activity step skipped
Commits pushed none (read lane)
Run 43801931869

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit f8982f4 Nov 16, 2026
59 checks passed
@kyle-sexton
kyle-sexton deleted the fix/16284-retro-corrections-condition-wording branch November 16, 2026 04:17
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant