Repository navigation
fix(session-flow): place the retro's corrections condition and state the policy-class rule - #16500
Conversation
…-class rule The retro gotcha puts "when the corrections plugin is installed" on the hand-off to /corrections:codify, where it applies. Without the plugin, the catalog's "Check first" item 2 now states inline that one occurrence of a policy-class mistake (irreversible, public, or security-relevant) is enough, beside a repeat with the same cause, so a literal reader cannot drop the exception. The branch taken with the plugin installed is unchanged. Refs: #16284 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The eval case moves to its own branch, so this fragment names only the two retro wording fixes and takes this branch's slug. Refs: #16284 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #16500I found no security issues. I read all 3 changed files in full. All three files are prose. None is on a trusted path, and none is a manifest, workflow, script or trust control.
Instruction-surface check: neither edit removes, narrows or softens a guardrail. The catalog change can only add proposals. A retro proposes a check without writing it, and Phase 4 still needs explicit approval before anything is saved. Nothing that a removed rule used to prevent is now reachable without a check. I did not read Since the last review: the head moved from Embedded text: the PR context contains no instructions aimed at this review. This review was blocking only (1 earlier head reviewed), so it reports only CRITICAL and IMPORTANT findings. There are none. critical-findings: 0 |
|
claude-review reviewed No findings. This review covered blocking findings only, because this lane already reviewed an earlier head ( This is a wording-only change to
Other notes:
Verifier dropped 0 of 0 candidates. |
…ctions-condition-wording # Conflicts: # plugins/session-flow/skills/retro/SKILL.md # plugins/session-flow/skills/retro/reference/ecosystem-improvement-catalog.md
The merge of main resolved two conflicted files by taking this branch's side whole, which put back "installed" in three lines main had changed to "enabled". Those lines are main's again; only the corrections condition and the policy-class rule differ from main. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Lane run report
Failed GitHub API calls
|
Refs: #16284
Summary
The retro's check proposal has two branches: with the
correctionsplugin it routes a mechanical finding to/corrections:codify, and without it the retro writes a Hooks-format check row from its own ladder copy. The review of #16282 left two wording findings on the branch taken without the plugin. This fixes both. It replaces #16462, which also carried a new eval case; the owner decided on 2026-11-16 to split them ("Go with recommendations."), because that case failed its own graders and the wording does not depend on it.Fix
plugins/session-flow/skills/retro/SKILL.md, Gotchas: "(when thecorrectionsplugin is enabled)" sits on the routing clause again, not on "which proves its own check". Main changed "installed" to "enabled" across this file in feat(session-flow): gate optional plugin calls on enabled skills #16450 while this was in review; the branch took main by merge and keeps main's word.plugins/session-flow/skills/retro/reference/ecosystem-improvement-catalog.md, "Check first": item 2 states both halves of the rule inline: the finding repeats with the same cause, or it happened once and is policy-class (irreversible, public, or security-relevant).Behavior with the plugin installed does not change. No eval case is added or changed.
Verification
/session-flow:retroran on sonnet at 6 runs a side: every launched run on both sides scored 1.00. By the registered rule three cases are decided with no loss and one,re-mechanical-finding-check-proposal, is not decided, because 4 of its 6 before-side runs were excluded for a permission denial in the trace; so the paired set reads not met by that rule, with no loss seen. The record is on fix(session-flow): retro check proposal without the corrections plugin: wording and an eval case #16284.Left out: a run at this branch's head (the wording text is the same as measured; main has moved under it), and the paired cases on opus.
Related
Remaining
🤖 Generated with Claude Code