Repository navigation
refactor(coupling): normalize reduce script imports, lint reasons and an unused default - #16299
Conversation
… an unused default
|
claude-review reviewed Code review: no findingsI read every hunk of all 4 changed files. The changes are structure-only tidying in the
There is no closing issue to check acceptance criteria against. The PR says The test results and the Verifier dropped 0 of 0 candidates. |
|
claude-security-review reviewed Security review: PR #16299I found no security issues. I read the full diff (4 files) and the PR description. Every change is structure-only and has no security surface:
None of the changes touch a trust control, a trusted path, a plugin manifest, a standing instruction, or a workflow. The PR description contains no embedded instructions aimed at this lane. critical-findings: 0 |
|
Unattended merge: native auto-merge leaves this pull request unarmed at head |
|
The unattended merge path armed native auto-merge at head |
Verification evidence for 6ec5790The verifier passed this head. The capture artifact holds the capture summary, which says whether the capture ran, and any screenshot or video that passed the mask check; this comment uploads no file. Capture artifact: pr-capture-16299-6ec579086031dc1539f022b056b9986fcbd87d03, expires on 2026-12-15. One comment per pull request, updated in place for each new head. |
|
Merge-Risk: max=LOW demote=false head=6ec579086031dc1539f022b056b9986fcbd87d03 rubric=9.2.2 rater=claude-opus-5-5 checker=claude-opus-5-5 |
|
The post-merge check verified merge commit |
Refs: #12894
Summary
Ad hoc tidy sweep of
plugins/coupling/**(no lane covers it; anchor: none, ad hoc). Three structure-only tidyings in thereduceskill's scripts, plus a patch changelog fragment. No behavior change.Fix
plugins/coupling/skills/reduce/scripts/derivable-list.pyimportlines beforefrom pathlib import Path, the ordervalue-sites.pyusesplugins/coupling/skills/reduce/scripts/value-sites.pytag="exact"default frombounded(); its only caller (matches()) always passestagplugins/coupling/skills/reduce/scripts/collision-hotspots.sh# shellcheck disable=SC2053gets the same reason as the firstFragment:
.changes/coupling/chore-tidy-adhoc-plugins-coupling-2026-11-15-e0c1492f.md(patch,### Changed).3 files, 3 insertions and 3 deletions in the tidy commit, well under the scope budget target.
Verification
bash plugins/coupling/skills/reduce/scripts/value-sites.test.sh: 285 passed, 0 failed, 1 skippedbash plugins/coupling/skills/reduce/scripts/derivable-list.test.sh: 29 passed, 0 failedbash plugins/coupling/skills/reduce/scripts/collision-hotspots.test.sh: 66 cases, 0 failedshellcheck -xon the changed script and the suites: cleanpython3 -m py_compileon both Python scripts: cleanbash scripts/check-changelog-fragments.sh --checkand--check-required <base>: passscripts/run-ruff.sh check(pinned ruff 0.17.4 was not available on the runner: no matching ruff on PATH, no uvx). Neither edit touches a name or an import set, only the order and a parameter default.Related
No related issue: an upkeep tidy sweep, not started from a filed item.
Deferred candidate, not filed (this run files no issues):
value-sites.test.shandderivable-list.test.sheach definehost_path,new_fixture,put,stage, and a row counter (row_count/count_rows) with the same bodies, except thatvalue-sites.test.sh'snew_fixturealso setscore.autocrlf false. Moving them intotest-helpers.shwould change thederivable-listfixtures and widen that file past the assertion primitives its header describes, so it needs a decision first. About 25 LOC across 3 files.Below the threshold and left alone:
value-sites.pyPROTECTED_NAMESholds patterns another entry already covers (appveyor.ymlunder*appveyor.y*ml, among others). Removing them changes thereasoncolumn and therulesoutput thatchange-mode.md's table is checked against, so it is behavioral.