Skip to content

refactor(coupling): normalize reduce script imports, lint reasons and an unused default - #16299

Merged
melodic-automation-lanes[bot] merged 1 commit into
mainfrom
chore/tidy-adhoc-plugins-coupling-2026-11-15
Nov 15, 2026
Merged

melodic-automation-lanes[bot] merged 1 commit into
mainfrom
chore/tidy-adhoc-plugins-coupling-2026-11-15

Conversation

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor

Refs: #12894

Summary

Ad hoc tidy sweep of plugins/coupling/** (no lane covers it; anchor: none, ad hoc). Three structure-only tidyings in the reduce skill's scripts, plus a patch changelog fragment. No behavior change.

Fix

Tidying File Change
Beck #3 Normalize Symmetries plugins/coupling/skills/reduce/scripts/derivable-list.py Plain import lines before from pathlib import Path, the order value-sites.py uses
Beck #2 Dead Code plugins/coupling/skills/reduce/scripts/value-sites.py Drop the unused tag="exact" default from bounded(); its only caller (matches()) always passes tag
Beck #3 Normalize Symmetries plugins/coupling/skills/reduce/scripts/collision-hotspots.sh The second # shellcheck disable=SC2053 gets the same reason as the first

Fragment: .changes/coupling/chore-tidy-adhoc-plugins-coupling-2026-11-15-e0c1492f.md (patch, ### Changed).

3 files, 3 insertions and 3 deletions in the tidy commit, well under the scope budget target.

Verification

  • bash plugins/coupling/skills/reduce/scripts/value-sites.test.sh: 285 passed, 0 failed, 1 skipped
  • bash plugins/coupling/skills/reduce/scripts/derivable-list.test.sh: 29 passed, 0 failed
  • bash plugins/coupling/skills/reduce/scripts/collision-hotspots.test.sh: 66 cases, 0 failed
  • shellcheck -x on the changed script and the suites: clean
  • python3 -m py_compile on both Python scripts: clean
  • bash scripts/check-changelog-fragments.sh --check and --check-required <base>: pass
  • Not run: scripts/run-ruff.sh check (pinned ruff 0.17.4 was not available on the runner: no matching ruff on PATH, no uvx). Neither edit touches a name or an import set, only the order and a parameter default.

Related

No related issue: an upkeep tidy sweep, not started from a filed item.

Deferred candidate, not filed (this run files no issues):

  • One Pile / Extract Helper: value-sites.test.sh and derivable-list.test.sh each define host_path, new_fixture, put, stage, and a row counter (row_count / count_rows) with the same bodies, except that value-sites.test.sh's new_fixture also sets core.autocrlf false. Moving them into test-helpers.sh would change the derivable-list fixtures and widen that file past the assertion primitives its header describes, so it needs a decision first. About 25 LOC across 3 files.

Below the threshold and left alone: value-sites.py PROTECTED_NAMES holds patterns another entry already covers (appveyor.yml under *appveyor.y*ml, among others). Removing them changes the reason column and the rules output that change-mode.md's table is checked against, so it is behavioral.

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 6ec579086031dc1539f022b056b9986fcbd87d03: read 4 of 4 changed file(s); 0 finding(s), 0 as inline comments.

Code review: no findings

I read every hunk of all 4 changed files. The changes are structure-only tidying in the coupling plugin's reduce scripts, plus a changelog fragment.

  • value-sites.py: the PR removes the tag="exact" default from bounded(). The only call in the plugin is at value-sites.py#L363, and it passes tag. The hyphenated module name means nothing can import the function, so removing the default changes no behaviour.
  • derivable-list.py: only the import order changes. Moving from pathlib import Path after the plain import lines leaves the same set of imports, with no side effects.
  • collision-hotspots.sh: only a comment changes. The SC2053 disable at line 146 now gives the same reason as the one at line 140, and the directive still applies.
  • Changelog fragment: bump: patch under ### Changed fits a no-behaviour-change tidy.

There is no closing issue to check acceptance criteria against. The PR says Refs: #12894 and states it has no related issue. No plugin manifest changed, the PR context contains no embedded instructions to the lane, and no prior findings or settled threads apply.

The test results and the shellcheck, py_compile and changelog-fragment checks in the PR description are the author's claims and unverified. This lane has no shell and ran none of them. By the author's account, scripts/run-ruff.sh was not run.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 6ec579086031dc1539f022b056b9986fcbd87d03: read 4 of 4 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #16299

I found no security issues.

I read the full diff (4 files) and the PR description. Every change is structure-only and has no security surface:

  • derivable-list.py: the from pathlib import Path line moves below the plain import lines. The set of imports is the same, so behavior does not change.
  • value-sites.py: the unused tag="exact" default is dropped from bounded(). Its only caller passes tag explicitly (value-sites.py line 363), so no call path changes.
  • collision-hotspots.sh: a reason is added to an existing # shellcheck disable=SC2053 comment. This is a comment-only change; the glob comparison under it is unchanged.
  • .changes/coupling/...md: a new changelog fragment (bump: patch).

None of the changes touch a trust control, a trusted path, a plugin manifest, a standing instruction, or a workflow. The PR description contains no embedded instructions aimed at this lane.

critical-findings: 0

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

Unattended merge: native auto-merge leaves this pull request unarmed at head 6ec579086031dc1539f022b056b9986fcbd87d03. No person needs to act: a lane clears this reason, and the next scheduled run judges it again.

pr-merge's gate refuses its verifier verdict (verify:missing)

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

The unattended merge path armed native auto-merge at head 6ec579086031dc1539f022b056b9986fcbd87d03, the head its arming checks judged.

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

Verification evidence for 6ec5790

The verifier passed this head. The capture artifact holds the capture summary, which says whether the capture ran, and any screenshot or video that passed the mask check; this comment uploads no file.

Capture artifact: pr-capture-16299-6ec579086031dc1539f022b056b9986fcbd87d03, expires on 2026-12-15.

One comment per pull request, updated in place for each new head.

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

Merge-Risk: max=LOW demote=false head=6ec579086031dc1539f022b056b9986fcbd87d03 rubric=9.2.2 rater=claude-opus-5-5 checker=claude-opus-5-5

@melodic-automation-lanes
melodic-automation-lanes Bot added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit ac7b658 Nov 15, 2026
45 checks passed
@melodic-automation-lanes
melodic-automation-lanes Bot deleted the chore/tidy-adhoc-plugins-coupling-2026-11-15 branch November 15, 2026 05:58
@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

The post-merge check verified merge commit ac7b658a26a3259a23d01871dbb7cb33420b1f8b; later checks count it verified from this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants