Repository navigation
fix(work-unblock): leave outage-lost queued runs out of the re-fire room - #15478
Conversation
The kill-switch re-fire pacer counted every unfinished work-resolve-issue run. Runs GitHub lost in an Actions outage stay `queued` and never start, so they held the room at 0 and the issue lane idle with agent-ready issues waiting (sweep run 43123797947: 12 unfinished, room 0 of 6). A run still `queued` limits.stale-queued-minutes (default 60) after it was created is no longer counted toward that room, and the sweep logs how many it left out. The reopened fix issue's in-flight check still counts every unfinished run. No new GitHub call: the filter reads created_at from the run listings the sweep already makes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q1HHi6JACp77x2ZbE7
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q1HHi6JACp77x2ZbE7
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
… check recurrenceRefusal counted every unfinished run that names no issue, so outage-lost queued runs refused every reopened fix issue's relabel with "cannot tell whether a lane run for it is in flight". A run still queued limits.stale-queued-minutes after it was created never starts, so it no longer counts there. A run whose title names the issue still holds it, stale or not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q1HHi6JACp77x2ZbE7
|
claude-review reviewed Code review (incremental, blocking only): PR #15478, cd628bb → abf09a4Blocking findings: none. I read every hunk of all 6 files in the incremental scope. I also read the unchanged code those hunks call: The earlier finding is fixed. At cd628bb the description and the code disagreed (the prior summary comment). Now they agree:
Tests. The new test covers the three cases the description lists:
The changelog fragment, the I dropped one advisory point because this review is blocking only. The comment on an unchanged line, label-unblocked.test.mjs:4890, still says only the re-fire room ignores stale queued runs. The reopened-fix check now ignores them too when they name no issue. The test case it describes still passes, because that run names #30. Verification. The author reports the tests pass. That is their claim and I have not checked it: this lane has no shell, so I ran nothing. There are no paved-path, plugin-manifest or settled-thread items. The PR context contains no embedded instructions. The change costs nothing: it adds no GitHub calls and no extra lane runs. |
|
claude-security-review reviewed Security review: PR #15478, incremental (cd628bb → abf09a4)No security issues found. This review was blocking only: this lane already reviewed an earlier head, so it reports only CRITICAL and IMPORTANT findings. I read every hunk of all 6 files in the incremental scope. What changed since the last review
Checks
Spend (not a hold, not counted as a finding)Reopened fix issues that outage-lost runs used to hold can now be relabeled, which can start more work-resolve-issue lane runs. That spends prepaid credits or subscription usage only. critical-findings: 0 |
No related issue: hub finding — outage-lost queued runs block the kill-switch re-fire pacer (sweep run 43123797947)
session: GitHub Support
Summary
The work-unblock sweep's kill-switch re-fire pacer counted every unfinished work-resolve-issue run. Twelve runs lost in GitHub's 2026-11-11 Actions outage have stayed
queuedsince 20:30-20:43Z and will never start. Sweep run 43123797947 logged12 work-resolve-issue run(s) unfinished, kill-switch re-fire room 0 of 6and deferred all 13 paced re-fires, so the issue lane sat idle with agent-ready issues waiting.Fix
limits.stale-queued-minutes(default 60): a run still at statusqueuedthis many minutes after itscreated_atis left out of the count behindrefire-queue-per-slot's room. The sweep logs one notice with how many it left out.queuedthis long means lost: theadmitjob runs on a GitHub-hosted runner (work-resolve-issue.ymlruns-on: ubuntu-24.04), and the slot wait is a job-levelconcurrencygroup onresolve-issuethat runs afteradmitandpick-slot. A run waiting for a slot has therefore already started. A run that staysqueuednever got a runner for its first job.queuedwithin minutes on a hosted runner, and 60 leaves a wide margin.runsInFlightnow returns{title, status, created}records from the same five status listings, and both callers use them:recurrenceRefusal(reopened fix issues) leaves stale queued runs out of its "runs that name no issue" count. Before, the lost runs refused every reopened fix issue with "cannot tell whether a lane run for it is in flight". Its title match (endsWith(" #N")) still counts every run, stale or not, because a run that names the issue may still be that issue's run, and ignoring it could relabel the issue twice.created_atparses to NaN and is never treated as stale, so that run still counts (fails safe).limits.mjs,resolve.mjslimitsOf,resolve.test.mjs, the schema (1-1440),pr-pipeline.yamlwith its reason, the README limits table, and apr-pipelinechangelog fragment (bump: minor).Per R461: zero added GitHub calls. The filter reads
created_atfrom theworkflow_runspayload the five existingruns?status=…listings already return. The diff adds noactions(/github(call site.Verification
node --test .github/scripts/work-unblock/label-unblocked.test.mjs .github/actions/resolve-config/resolve.test.mjs .github/actions/resolve-config/live-config.test.mjs: tests 621, pass 621, fail 0.New cases:
in_progressorpendingfor four hours, and queued with no readable creation time.stale-queued-minutes: 120moves the cutoff.#30still counts as in flight.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01VQb9Q1HHi6JACp77x2ZbE7