Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
bump: major
---

### Changed

- **Breaking:** recurring items link to their schedule row by a `<!-- recurring-schedule id=<id> -->` body line plus the `recurring-maintenance` label, never by title. `track add --recurring` writes the line and gives the item a Conventional Commits title (`chore(<scope>): <summary>`) in place of the `[Maintenance]` prefix; `due`, `recheck`, `done`, `audit`, `setup` and `work` candidate discovery match by the line, and a repository's recurring-issues automation must write it too. An open recurring item with no line matches no row: `due` and `audit` report it as unlinked, and `work` creates no recurring item while one exists. Migrate by adding the line, naming the row's `id`, to each open `[Maintenance]` item.
8 changes: 4 additions & 4 deletions .github/recurring-schedule.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"triggers": [],
"last_checked": "2026-11-06",
"next_due": "2027-02-04",
"notes": "Report-only self-maintenance routine (digest menu #9 pilot). Run skill-quality's check-listing-budget.sh pooled over plugins/*/skills from a current main checkout; record aggregate, skill count, delta vs prior cycle, and top-10 contributors on the open [Maintenance] issue (#2023 is the first instance). Baseline and the pending target decision live in #2022. Never edits descriptions — findings route to issues.",
"notes": "Report-only self-maintenance routine (digest menu #9 pilot). Run skill-quality's check-listing-budget.sh pooled over plugins/*/skills from a current main checkout; record aggregate, skill count, delta vs prior cycle, and top-10 contributors on the open recurring issue (#2023 is the first instance). Baseline and the pending target decision live in #2022. Never edits descriptions — findings route to issues.",
"close_previous": true
},
{
Expand All @@ -38,7 +38,7 @@
"triggers": [],
"last_checked": "2026-11-06",
"next_due": "2027-02-04",
"notes": "Report-only self-maintenance routine (digest menu #9 pilot). Sweep docs/ and top-level repo docs for references to files/checks/skills that no longer exist, stale version claims, and moved official-docs.md pages (review:doc-drift-detector or docs-hygiene audits); verify generated CATALOG/skill-cheat-sheet freshness on a scratch branch. File one issue per confirmed drift cluster or comment no-drift on the open [Maintenance] issue (#2024 is the first instance). Never edits docs directly from the routine.",
"notes": "Report-only self-maintenance routine (digest menu #9 pilot). Sweep docs/ and top-level repo docs for references to files/checks/skills that no longer exist, stale version claims, and moved official-docs.md pages (review:doc-drift-detector or docs-hygiene audits); verify generated CATALOG/skill-cheat-sheet freshness on a scratch branch. File one issue per confirmed drift cluster or comment no-drift on the open recurring issue (#2024 is the first instance). Never edits docs directly from the routine.",
"close_previous": true
},
{
Expand All @@ -62,7 +62,7 @@
"triggers": [],
"last_checked": "2026-10-24",
"next_due": "2026-11-24",
"notes": "Check rhysd/actionlint releases after v1.7.12 (and actionlint issues #711/#732) for one that parses uses: $/... . None: comment unmet on the [Maintenance] issue, change nothing. One: file an issue to repin the ci-workflows actionlint action (pr-require-checks.yml), re-count the zizmor: ignore[self-repository] sites (137 on 2026-10-24), run zizmor --fix=safe --persona=regular -- ., delete every zizmor: ignore[self-repository] and the comment above the Run zizmor step in pr-require-checks.yml; accept when zizmor and actionlint both exit 0, never a repo-wide disable. Spec: #4130.",
"notes": "Check rhysd/actionlint releases after v1.7.12 (and actionlint issues #711/#732) for one that parses uses: $/... . None: comment unmet on the recurring issue, change nothing. One: file an issue to repin the ci-workflows actionlint action (pr-require-checks.yml), re-count the zizmor: ignore[self-repository] sites (137 on 2026-10-24), run zizmor --fix=safe --persona=regular -- ., delete every zizmor: ignore[self-repository] and the comment above the Run zizmor step in pr-require-checks.yml; accept when zizmor and actionlint both exit 0, never a repo-wide disable. Spec: #4130.",
"close_previous": true
},
{
Expand Down Expand Up @@ -98,7 +98,7 @@
"triggers": [],
"last_checked": "2026-10-26",
"next_due": "2026-11-26",
"notes": "Run gh run list -R melodic-software/claude-code-plugins --workflow pr-verify.yml --branch main --status failure -L 50 and read each failed run's log for ::error::no verdict: the run hit N permission denial(s) or ::error::no verdict: the run's legs hit N permission denial(s) (write-verdict.mjs); list the lane PRs the merge lane refused verify:missing behind those heads. A person decides, per denial, whether it was a benign read (the model reaching for a path outside pr-verify-data) or injected PR text. Injected PR text: the refusal worked; keep it and change nothing. Benign reads recurring (2 or more lane PRs refused verify:missing from benign-read denials in 30 days): file a fix issue, trying first an automatic pr-require-checks rerun on the stalled head, since it leaves the injection refusal intact, then a tighter prompt. Below that: comment the counts on the [Maintenance] issue and change nothing. Rejected for now (#8432): a fail verdict with the reason, which refuses that head verify:fail, holds the PR's later heads verify:earlier-fail until a later pass on a different change clears them, and counts toward the verify:repeated-fail cap; and ignoring denials, which lets an injected read still be judged. Spec: #8432.",
"notes": "Run gh run list -R melodic-software/claude-code-plugins --workflow pr-verify.yml --branch main --status failure -L 50 and read each failed run's log for ::error::no verdict: the run hit N permission denial(s) or ::error::no verdict: the run's legs hit N permission denial(s) (write-verdict.mjs); list the lane PRs the merge lane refused verify:missing behind those heads. A person decides, per denial, whether it was a benign read (the model reaching for a path outside pr-verify-data) or injected PR text. Injected PR text: the refusal worked; keep it and change nothing. Benign reads recurring (2 or more lane PRs refused verify:missing from benign-read denials in 30 days): file a fix issue, trying first an automatic pr-require-checks rerun on the stalled head, since it leaves the injection refusal intact, then a tighter prompt. Below that: comment the counts on the recurring issue and change nothing. Rejected for now (#8432): a fail verdict with the reason, which refuses that head verify:fail, holds the PR's later heads verify:earlier-fail until a later pass on a different change clears them, and counts toward the verify:repeated-fail cap; and ignoring denials, which lets an injected read still be judged. Spec: #8432.",
"close_previous": true
},
{
Expand Down
32 changes: 21 additions & 11 deletions .github/scripts/intake-triage/admit.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@
// sub-issue (splitChildBody); any other issue the App filed holds for a
// listed human to file as their own (owner decision on #10735);
// - no body line opens with `Hold:` (BODY_HOLD), a person's hold;
// - a `recurring` item's schedule row, read from the default branch's
// .github/recurring-schedule.json, does not set
// requires_operator_confirmation (operatorConfirmation);
// - a `recurring` item's body has a `<!-- recurring-schedule id=<id> -->`
// line naming a row of the default branch's .github/recurring-schedule.json,
// and that row does not set requires_operator_confirmation
// (operatorConfirmation);
// - the body was not edited after the lane comment the verdict came from;
// - on the work-unblock sweep, which passes no verdict comment, a deferred
// issue carries neither do-not-merge nor needs-human, and neither gained
Expand Down Expand Up @@ -248,20 +249,29 @@ export function readSchedule(path = fileURLToPath(new URL("../../recurring-sched
}
}

// The schedule row ids a body names on a `<!-- recurring-schedule id=<id> -->`
// line, the marker that links a recurring issue to its row whatever its title.
const SCHEDULE_MARKER = /^<!-- recurring-schedule id=(\S+) -->\r?$/gm;
const scheduleIds = (body) => [...String(body ?? "").matchAll(SCHEDULE_MARKER)].map((match) => match[1]);

// Why a `recurring` item needs a person, or null: its schedule row (the one
// titled `[Maintenance] {title}`) sets requires_operator_confirmation, which
// autonomous lanes must skip, or the schedule was not read. Pure.
export function operatorConfirmation({ schedule, labels, title }) {
// its body's marker names) sets requires_operator_confirmation, which
// autonomous lanes must skip, or the schedule was not read, or no marker
// names a row (a pre-marker item may be a confirming row's). Pure.
export function operatorConfirmation({ schedule, labels, body }) {
if (!labels.includes(RECURRING)) {
return null;
}
if (!Array.isArray(schedule?.items)) {
return "it carries recurring and .github/recurring-schedule.json could not be read, so admission cannot tell whether its schedule row needs an operator's confirmation";
}
const row = schedule.items.find((item) => `[Maintenance] ${item?.title}` === title);
return row?.precondition?.requires_operator_confirmation === true
? `its recurring schedule row ${row.id} needs an operator's confirmation (requires_operator_confirmation)`
: null;
const ids = scheduleIds(body);
const rows = schedule.items.filter((item) => ids.includes(item?.id));
if (rows.length === 0) {
return "it carries recurring and no `<!-- recurring-schedule id=<id> -->` line names a row of .github/recurring-schedule.json, so admission cannot tell whether its schedule row needs an operator's confirmation";
}
const row = rows.find((item) => item?.precondition?.requires_operator_confirmation === true);
return row ? `its recurring schedule row ${row.id} needs an operator's confirmation (requires_operator_confirmation)` : null;
}

// The issues and pull requests GitHub lists as blocking the issue at `base`
Expand Down Expand Up @@ -1608,7 +1618,7 @@ export function decide({ issue, verdict, rules, parent, blockers, trustedCloses,
if (lapsed.hold) holdFor(lapsed.reason.startsWith(UNTRUSTED) || lapsed.reason.startsWith(SECURITY_AREA) ? "security" : "intent");
}
}
const confirm = operatorConfirmation({ schedule, labels, title: issue.title });
const confirm = operatorConfirmation({ schedule, labels, body: issue.body });
if (confirm) {
refuse.push(confirm);
}
Expand Down
39 changes: 33 additions & 6 deletions .github/scripts/intake-triage/admit.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -700,23 +700,50 @@ describe("decide", () => {
assert.doesNotMatch(text, /agent-ready/);
});

// A standing recurring item links to its schedule row by `[Maintenance] {title}`.
// A recurring item links to its schedule row by its body's marker, never its title.
describe("a recurring item whose schedule row needs an operator", () => {
const row = (id, precondition) => ({ id, title: "Re-run the ablation", cadence: "quarterly", ...(precondition && { precondition }) });
const recurring = issueOf({ title: "[Maintenance] Re-run the ablation", labels: [{ name: READY }, { name: "recurring" }] });
const recurring = issueOf({
title: "chore(harness-config): re-run the ablation",
body: `<!-- recurring-schedule id=ablation -->\n${BODY}`,
labels: [{ name: READY }, { name: "recurring" }],
});
const CONFIRM = "its recurring schedule row ablation needs an operator's confirmation (requires_operator_confirmation)";
const confirming = { items: [row("ablation", { id: "frontier-release-since-last-checked", requires_operator_confirmation: true })] };

test("is refused when its row sets requires_operator_confirmation", () => {
const schedule = { items: [row("ablation", { id: "frontier-release-since-last-checked", requires_operator_confirmation: true })] };
assert.deepEqual(decide(facts({ issue: recurring, schedule })), { verdict: "refuse", reasons: [CONFIRM] });
assert.deepEqual(decide(facts({ issue: recurring, schedule: confirming })), { verdict: "refuse", reasons: [CONFIRM] });
});

test("is admitted when its row has no such flag, or no row matches its title", () => {
for (const items of [[row("ablation")], [row("ablation", { id: "x", requires_operator_confirmation: false })], [{ ...row("other"), title: "Something else" }], []]) {
test("is admitted when its row has no such flag", () => {
for (const items of [[row("ablation")], [row("ablation", { id: "x", requires_operator_confirmation: false })]]) {
assert.deepEqual(decide(facts({ issue: recurring, schedule: { items } })), { verdict: "admit", reasons: [] }, JSON.stringify(items));
}
});

test("is refused when no marker names a schedule row", () => {
const legacy = issueOf({ title: "[Maintenance] Re-run the ablation", labels: recurring.labels });
const inline = { ...recurring, body: `see <!-- recurring-schedule id=ablation --> above\n${BODY}` };
const cases = [
[recurring, { items: [{ ...row("other"), title: "Something else" }] }],
[recurring, { items: [] }],
[legacy, { items: [row("ablation")] }],
[inline, { items: [row("ablation")] }],
];
for (const [issue, schedule] of cases) {
const result = decide(facts({ issue, schedule }));
assert.equal(result.verdict, "refuse", issue.body);
assert.match(result.reasons.join(), /no `<!-- recurring-schedule id=<id> -->` line names a row/);
}
});

test("matches by the marker, not the title", () => {
const retitled = { ...recurring, title: "chore: something unrelated" };
assert.deepEqual(decide(facts({ issue: retitled, schedule: confirming })), { verdict: "refuse", reasons: [CONFIRM] });
const crlf = { ...recurring, body: `<!-- recurring-schedule id=ablation -->\r\n${BODY}` };
assert.deepEqual(decide(facts({ issue: crlf, schedule: confirming })), { verdict: "refuse", reasons: [CONFIRM] });
});

test("is refused when the schedule could not be read", () => {
for (const schedule of [null, undefined, { rows: [] }]) {
const result = decide(facts({ issue: recurring, schedule }));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ expected_outcome: 'The run would claim #150: the due recurring item''s tier 1 is
{
"items": [
{
"id": "ci-workflow-pins-review",
"title": "Review CI workflow pins",
"next_due": "2026-11-01",
"cadence_days": 30
Expand All @@ -29,7 +30,8 @@ Open items with the recurring-maintenance label:
[
{
"number": 150,
"title": "[Maintenance] Review CI workflow pins",
"title": "chore: review CI workflow pins",
"body": "<!-- recurring-schedule id=ci-workflow-pins-review -->\nCheck each pinned action for a newer release.",
"created_at": "2026-11-01T06:00:00Z",
"labels": [
"recurring-maintenance",
Expand Down
23 changes: 21 additions & 2 deletions plugins/work-items/reference/issue-conventions.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,27 @@ membership comment on the item, post the matching membership comment on the umbr
the `blocked-by` edge, then strip the raw marker. Never stop after the item-side comment alone
(#633).

Recurring maintenance items keep the `[Maintenance] {title}` shape owned by `track add --recurring`
(the due / work / recheck flows exact-match that prefix); they are exempt from the two prefix dialects.
Recurring maintenance items take the conventional-commit form too: `chore(<scope>): <summary>` by
default, the summary being the schedule row's `title` with a lowercase first letter, `<scope>` the
row's first `area` entry, and `chore:` alone when `area` is empty. The title never links an item to its schedule row; the
[recurring marker](#recurring-marker) does.

### Recurring marker

A recurring item's body carries one line, on its own, that names its schedule row's `id`:

```text
<!-- recurring-schedule id=<id> -->
```

An item matches a row when it carries the resolved `recurring-maintenance` label
([`label-taxonomy.md`](label-taxonomy.md) "Canonical roles") **and** its body has that line with
the row's `id`, exactly. Never match by title: a title edit cannot break the link, and a row whose
title is a prefix of another's cannot claim the other's item. `track add --recurring` writes the
line; the `due`, `recheck`, `done`, `audit` and `setup` flows and `work`'s candidate discovery read
it. The line must appear alone on its line; the same text inside a sentence is not a marker. An
open recurring item with no marker matches no row: report it for retitling and a marker, never
guess its row from the title.

## Body

Expand Down
14 changes: 7 additions & 7 deletions plugins/work-items/reference/label-taxonomy.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,18 +84,18 @@ Two strings adjacent to the `recurring-maintenance` role are **fixed by design t
binding key remaps them (recorded posture per the consumer-configurability doctrine; #2942
F3.7):

- **`[Maintenance]` title prefix**: the exact-match key `due`/`work` use to reconcile a
schedule row with its open tracker item. Making it configurable is deferred until a consumer
asks for a different prefix; when that request lands it joins the binding as a sibling of
`config.role_labels` (a `config` key, not a parallel mechanism), and every reader named in
[`../skills/track/actions/due.md`](../skills/track/actions/due.md) and the setup
reconciliation steps resolves it the same way role labels resolve.
- **`<!-- recurring-schedule id=<id> -->` body marker**: the exact-match key the recurring flows
use to reconcile a schedule row with its open tracker item
([`issue-conventions.md`](issue-conventions.md) "Recurring marker"). Making it configurable is
deferred until a consumer asks for a different marker; when that request lands it joins the
binding as a sibling of `config.role_labels` (a `config` key, not a parallel mechanism), and
every reader that convention names resolves it the same way role labels resolve.
- **`.github/recurring-schedule.json` path**: the schedule file's location. Deferred on the
same first-request trigger; a future remap is a binding `config` key resolved once per
invocation, never a second discovery climb.

Both strings participate in exact-match lookups against provider data, so a repo changing
either today would orphan existing `[Maintenance]` items and schedules, which is why the
either today would orphan existing recurring items and schedules, which is why the
remap, when it comes, arrives with a reconciliation step, not as a bare string swap.

## Project-specific axes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Before claiming (tier 4) or recheck-closing:
2. Ask whether a Claude model release of the class the row's `prompt` names occurred
**after** that date.
3. If **no** (or unknown): **do not claim, do not recheck-close**. Leave the open
`[Maintenance]` issue open and report the `prompt` text inline.
recurring issue open and report the `prompt` text inline.
4. If **yes**: proceed, and record in the claim/recheck comment that the operator
confirmed a post-`last_checked` release.

Expand Down
7 changes: 5 additions & 2 deletions plugins/work-items/reference/tracker-seam.md
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,11 @@ rather than silently querying the default.
## Recurring schedule

Recurring items are defined in `.github/recurring-schedule.json` and created as items by the
consuming repo's recurring-issues automation when they come due. The `/work-items:track recheck`
action updates this schedule after completing a periodic check.
consuming repo's recurring-issues automation when they come due. That automation writes each item
in the recurring shape, the `<!-- recurring-schedule id=<id> -->` body line included
([`issue-conventions.md`](issue-conventions.md) "Recurring marker"): an item without it is matched
to no row. The `/work-items:track recheck` action updates this schedule after completing a
periodic check.

## Memory-tier writes

Expand Down
Loading
Loading