Skip to content

docs(evals): record the 2.1.318 recheck of the worktree eval guard - #13381

Merged
kyle-sexton merged 2 commits into
mainfrom
docs/5696-recheck-2-1-318
Nov 4, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
docs/5696-recheck-2-1-318

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Refs: #5696

Summary

Reran the worktree eval-guard recheck on Claude Code 2.1.318 (Linux/WSL2, 2026-11-04). A claude -p --worktree session still refuses claude plugin eval --help with the same message. A normal claude -p session runs it and prints the usage line.

Fix

  • plugins/evals/skills/plugin-eval/reference/records.md: adds the 2.1.318 recheck line under Worktrees.
  • plugins/evals/skills/plugin-eval/SKILL.md: the worktree guard row now cites 2.1.318, 2026-11-04.
  • .changes/evals/: patch fragment.

Verification

Probe, --permission-mode auto, with an echo ok control in each shape:

  • claude -p --worktree probe-5696-318: echo ok ran; claude plugin eval --help was refused with "this command runs a string through eval, which can't be verified to stay inside the worktree".
  • Plain claude -p started in a git worktree add worktree: both ran; it printed Usage: claude plugin eval [options] [command] [target]. A plain session in the main checkout ran it too.

Remaining

#5696 stays open: it closes on a release where the --worktree shape passes.

Related

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T21:55:14.320738Z 41a28d2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 1608a961979d669252221da917fc5ac08ad2d549: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review (incremental): no security issues found

This review covers only the change since 41a28d2c76cfd5037a3bbb4d50137a2ed5f5a69a. I read the one hunk in the one listed file, plugins/evals/skills/plugin-eval/reference/records.md.

The change: one line in the 2.1.318 recheck bullet under Worktrees now reads "a normal session in a git worktree add worktree allowed" instead of "a normal session in the main checkout allowed". This matches the PR description's Verification section and the wording of the 2.1.316 bullet above it.

What I checked:

  • Trusted paths: the file matches no TRUSTED PATHS glob.
  • Instruction surface: this file is a reference record of observed behaviour. No standing instruction is deleted, narrowed or softened.
  • Trust controls and plugin manifests: none are touched.
  • Code, billing and new executable surface: there is no code or config change and nothing that runs or can bill.
  • PR context: no embedded directives.

Prior findings: the lane's earlier summary comment reported no findings, so nothing is repeated. This review was blocking only (an earlier head was already reviewed), so only CRITICAL and IMPORTANT findings would have been posted, and there are none.

critical-findings: 0

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude-review: 1 inline finding(s) on 41a28d2c76cfd5037a3bbb4d50137a2ed5f5a69a; the summary is in this lane's pull request comment.

claude-lane: claude-review

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed 1608a961979d669252221da917fc5ac08ad2d549: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code review: PR #13381, incremental (41a28d2 → 1608a96)

This review covers only the change since 41a28d2, and it reports blocking findings only, because this lane already reviewed an earlier head. I read the one file in scope: the single hunk in plugins/evals/skills/plugin-eval/reference/records.md.

0 findings.

The earlier finding is fixed. It said the 2.1.318 recheck was labelled "same probe shape" even though its normal session ran in the main checkout. That entry now reads "a normal session in a git worktree add worktree allowed" (records.md#L108-L110). That matches:

  • the recheck instruction at L103-104;
  • the 2.1.316 entry at L105-107;
  • the updated PR body, which says the plain claude -p probe was started in a git worktree add worktree.

So the SKILL.md row is right to date its claim about which session shapes the guard covers to 2.1.318. The thread is resolved with an owner reply, and its lines haven't changed since, so it stays settled.

Other checks:

  • No plugin manifest changed in this push, so there are no manifest lines.
  • The PR context gives Refs: #5696, not a closing issue, so there are no acceptance criteria to check.
  • I found no embedded instructions in the PR context, the settled-threads file or the prior-findings file.
  • The probe results are the author's claims. I did not reproduce them.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit d585029 Nov 4, 2026
57 checks passed
@kyle-sexton
kyle-sexton deleted the docs/5696-recheck-2-1-318 branch November 4, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant